clayborg added a comment.
This should be in great shape now. Can anyone find time for this?
https://reviews.llvm.org/D50365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added inline comments.
Comment at: tools/lldb-vscode/BreakpointBase.cpp:13-21
+uint64_t string_to_unsigned(const char *s, int base, uint64_t fail_value) {
+ if (s && s[0]) {
+char *end = nullptr;
+uint64_t uval = strtoull(s, &end, base);
+if (*end == '\0')
+
Apologies for double-posting, but I'm not sure that my Phab comment made it to
you.
---
/lldb/trunk/source/Utility/ConstString.cpp:130 Great catch!
I wonder, what does it mean for the entry value to be non-null but empty?
vedant
> On Aug 14, 2018, at 12:38 PM, Stefan Granitz via lldb-commits
acoomans created this revision.
acoomans added a reviewer: lldb-commits.
This adds autocompletion for the `expression` (and thus `print` and `p`)
commands. Variables and symbols are suggested.
For example: let's assume we have a struct called //my_struct//. We break, then
run:
(lldb) p my_ [
magardne added a comment.
@labath Eugene asked me to help add a unit test for this. I have the updated
diff, but I can't seem to attach it to this code review -- it must be because
I'm not the original author? I'll attach the diff to this comment and maybe you
can try to update the review. Othe
teemperor added a comment.
I think https://reviews.llvm.org/D48465 is doing the same thing (and more).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D50802
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: gclayton
Date: Wed Aug 15 14:21:22 2018
New Revision: 339817
URL: http://llvm.org/viewvc/llvm-project?rev=339817&view=rev
Log:
Fix doc string variable name to quiet a compiler warning.
Modified:
lldb/trunk/include/lldb/API/SBProcess.h
Modified: lldb/trunk/include/lldb/API/SBProcess.
clayborg added inline comments.
Comment at: tools/lldb-vscode/BreakpointBase.cpp:21
+ return fail_value;
+}
+} // namespace
Sure thing
Comment at: tools/lldb-vscode/ExceptionBreakpoint.cpp:22
+
+void ExceptionBreakpoint::ClearBreakpoint() {
+
zturner added inline comments.
Comment at: tools/lldb-vscode/JSONUtils.h:142
+std::vector GetStrings(const llvm::json::Object *obj,
+llvm::StringRef key);
+
clayborg wrote:
> Need to keep as is because as noted in the descripti
Author: teemperor
Date: Wed Aug 15 15:31:44 2018
New Revision: 339825
URL: http://llvm.org/viewvc/llvm-project?rev=339825&view=rev
Log:
[ASTImporter] Add test for IfStmt
Reviewers: a.sidorin, hiraditya
Reviewed By: hiraditya
Subscribers: hiraditya, martong, cfe-commits
Differential Revision: h
Author: teemperor
Date: Wed Aug 15 15:32:35 2018
New Revision: 339826
URL: http://llvm.org/viewvc/llvm-project?rev=339826&view=rev
Log:
Revert "[ASTImporter] Add test for IfStmt"
That's actually a clang patch, sorry.
Removed:
lldb/trunk/test/Import/if-stmt/Inputs/F.cpp
lldb/trunk/test/Im
Author: adrian
Date: Wed Aug 15 15:48:48 2018
New Revision: 339828
URL: http://llvm.org/viewvc/llvm-project?rev=339828&view=rev
Log:
Add libc++ data formatters for std::optional.
Patch by Shafik Yaghmour!
This reapplies an earlier version after addressing some post-commit feedback.
Differential
Author: jingham
Date: Wed Aug 15 16:10:32 2018
New Revision: 339833
URL: http://llvm.org/viewvc/llvm-project?rev=339833&view=rev
Log:
Fix a little thinko in generating ___lldb_unnamed_symbol symbols
when we have only an in-memory copy of the binary.
Also added a test for the generation of these
clayborg marked 23 inline comments as done.
clayborg added inline comments.
Comment at: tools/lldb-vscode/SourceBreakpoint.h:24
+ // Set this breakpoint in LLDB as a new breakpoint
+ void SetBreakpoint(const char *source_path);
+};
zturner wrote:
> clayborg wro
On Wed, Aug 15, 2018 at 4:48 PM Greg Clayton via Phabricator <
revi...@reviews.llvm.org> wrote:
> clayborg marked 23 inline comments as done.
> clayborg added inline comments.
>
>
>
> Comment at: tools/lldb-vscode/SourceBreakpoint.h:24
> + // Set this breakpoint in LLDB as a new
On Wed, Aug 15, 2018 at 4:59 PM Zachary Turner wrote:
>
>
> On Wed, Aug 15, 2018 at 4:48 PM Greg Clayton via Phabricator <
> revi...@reviews.llvm.org> wrote:
>
>> clayborg marked 23 inline comments as done.
>> clayborg added inline comments.
>>
>>
>>
>> Comment at: tools/lldb-vsc
zturner added a comment.
Looking pretty good, I went over it again and found a few more things. There's
a bit more `auto` than I'm comfortable with, but I'm not gonna make a big deal
about it. it does make the code a bit hard to read when it's used for trivial
return values though.
===
17 matches
Mail list logo
