Apologies for double-posting, but I'm not sure that my Phab comment made it to you.
--- /lldb/trunk/source/Utility/ConstString.cpp:130 Great catch! I wonder, what does it mean for the entry value to be non-null but empty? vedant > On Aug 14, 2018, at 12:38 PM, Stefan Granitz via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > Author: stefan.graenitz > Date: Tue Aug 14 12:38:54 2018 > New Revision: 339716 > > URL: http://llvm.org/viewvc/llvm-project?rev=339716&view=rev > Log: > Remove asseration from ConstString::GetConstCStringAndSetMangledCounterPart() > to fix more tests first > > Modified: > lldb/trunk/source/Utility/ConstString.cpp > > Modified: lldb/trunk/source/Utility/ConstString.cpp > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/ConstString.cpp?rev=339716&r1=339715&r2=339716&view=diff > ============================================================================== > --- lldb/trunk/source/Utility/ConstString.cpp (original) > +++ lldb/trunk/source/Utility/ConstString.cpp Tue Aug 14 12:38:54 2018 > @@ -123,11 +123,6 @@ public: > StringPool &map = m_string_pools[h].m_string_map; > StringPoolEntryType &entry = *map.try_emplace(demangled).first; > > - assert((entry.second == nullptr || entry.second == mangled_ccstr || > - strlen(entry.second) == 0) && > - "The demangled string must have a unique counterpart or > otherwise " > - "it must be empty"); > - > entry.second = mangled_ccstr; > > // Extract the const version of the demangled_cstr > > > _______________________________________________ > lldb-commits mailing list > lldb-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
