labath updated this revision to Diff 159649.
labath added a comment.
Updating the module map too (thanks).
https://reviews.llvm.org/D50384
Files:
include/lldb/Core/Event.h
include/lldb/Core/IOHandler.h
include/lldb/Host/Editline.h
include/lldb/Host/Predicate.h
include/lldb/Host/Socket
sgraenitz updated this revision to Diff 159654.
sgraenitz added a comment.
Add unit tests for RichManglingContext
https://reviews.llvm.org/D50071
Files:
include/lldb/Core/Mangled.h
include/lldb/Core/RichManglingContext.h
include/lldb/Symbol/Symtab.h
include/lldb/lldb-forward.h
lldb.xc
sgraenitz added inline comments.
Comment at: source/Core/RichManglingContext.cpp:133
+ case PluginCxxLanguage:
+m_cxx_method_str = ConstString(
+
get(m_cxx_method_parser)->GetBasename());
labath wrote:
> I thought we were going to get rid of this Con
labath edited reviewers, added: zturner, davide; removed: labath.
labath added a comment.
I am not sure I'll have the resources to see this review through, so I'd prefer
to leave this to someone else.
The thoughts I have had so far are:
- the patch is very big and probably runs afoul of the "yo
labath added inline comments.
Comment at: source/Core/RichManglingContext.cpp:133
+ case PluginCxxLanguage:
+m_cxx_method_str = ConstString(
+
get(m_cxx_method_parser)->GetBasename());
sgraenitz wrote:
> labath wrote:
> > I thought we were going to g
sgraenitz updated this revision to Diff 159678.
sgraenitz added a comment.
Polishing
https://reviews.llvm.org/D50071
Files:
include/lldb/Core/Mangled.h
include/lldb/Core/RichManglingContext.h
include/lldb/Symbol/Symtab.h
include/lldb/lldb-forward.h
lldb.xcodeproj/project.pbxproj
sou
sgraenitz marked an inline comment as done.
sgraenitz added a comment.
Tests, polishing and renaming (as discussed with @jingham).
If you have more comments on this, please let me know.
Otherwise I'd be fine with keeping it like this.
https://reviews.llvm.org/D50071
_
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I think this looks great. I am very happy with the final result. Thank you for
your patience, and thanks again for taking on this task.
https://reviews.llvm.org/D50071
labath added a comment.
To end things on a positive note: I think the test coverage is pretty good (I'm
sure somebody will suggest switching to lit), and I think a VS code plugin
would be a great addition to lldb.
https://reviews.llvm.org/D50365
_
How does this differ from VS Code's builtin LLDB MI support?
On Wed, Aug 8, 2018 at 8:15 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added a comment.
>
> To end things on a positive note: I think the test coverage is pretty good
> (I'm sure somebody will suggest sw
zturner added a comment.
How does this differ from VS Code's builtin LLDB MI support?
https://reviews.llvm.org/D50365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
To elaborate, if you install the C/C++ plugin, and you go to Debug ->
Configurations, and you go down to the MICmdMode property, it is by default
set to "gdb". But you can change this to "lldb" and it works out of the
box.
On Wed, Aug 8, 2018 at 8:30 AM Zachary Turner wrote:
> How does this dif
zturner added a comment.
To elaborate, if you install the C/C++ plugin, and you go to Debug ->
Configurations, and you go down to the MICmdMode property, it is by default
set to "gdb". But you can change this to "lldb" and it works out of the
box.
https://reviews.llvm.org/D50365
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
lgtm, although Predicate is simple enough that I wonder if one day we should
try to just delete it entirely.
https://reviews.llvm.org/D50384
_
It is a different protocol. The LLDB MI plugin didn't work very well as was
quite flaky when I tested it a while back. Then I grabbed the CodeLLDB plugin
by Vadim Chugunov and it worked very well. When I looked more closely at this
plugin, it was using a javascript/typescript plug-in to launch a
clayborg added a comment.
In https://reviews.llvm.org/D50365#1192447, @zturner wrote:
> To elaborate, if you install the C/C++ plugin, and you go to Debug ->
> Configurations, and you go down to the MICmdMode property, it is by default
> set to "gdb". But you can change this to "lldb" and it w
Ok sounds good then, mostly just wanted to make sure you weren't
re-inventing something that already existed :) Do you plan to publish this
on the VSCode marketplace?
On Wed, Aug 8, 2018 at 8:38 AM Greg Clayton wrote:
> It is a different protocol. The LLDB MI plugin didn't work very well as
> w
> On Aug 8, 2018, at 8:40 AM, Zachary Turner wrote:
>
> Ok sounds good then, mostly just wanted to make sure you weren't re-inventing
> something that already existed :) Do you plan to publish this on the VSCode
> marketplace?
I would like to. Not sure how this works with native binaries as
JDevlieghere added a comment.
This looks really cool :-)
I started doing a superficial pass but I have a hard time following what
everything is doing. I think it could really help if you added more
structure/abstraction. Can you also run clang-format over the new files?
Comm
jkorous added a comment.
Hi Greg, this looks interesting! I got curious about your patch since I am
dealing with another protocol from the same "family" - LSP.
Comment at: tools/lldb-vscode/lldb-vscode.cpp:1424
+//---
jingham added a comment.
You and Pavel have done great work getting this all straight. I don't have
much to add except some trivial quibbles about variable naming, a grammar error
and some other inessentials.
Comment at: include/lldb/Core/Mangled.h:323-325
+ /// @return
+
sgraenitz updated this revision to Diff 159767.
sgraenitz marked 5 inline comments as done.
sgraenitz added a comment.
Addressed Jim's feedback
https://reviews.llvm.org/D50071
Files:
include/lldb/Core/Mangled.h
include/lldb/Core/RichManglingContext.h
include/lldb/Symbol/Symtab.h
include
sgraenitz marked an inline comment as done.
sgraenitz added inline comments.
Comment at: source/Core/Mangled.cpp:239-240
+//--
+namespace {
+
+char *GetMSVCDemangledStr(const char *M) {
jingham w
sgraenitz created this revision.
sgraenitz added a reviewer: erik.pilkington.
Herald added a subscriber: llvm-commits.
Show the behavior of print operations in the ItaniumPartialDemangler. It's a
summary of what the current integration in LLDB assumes. For new users this may
be a useful example.
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
Looks reasonable to me.
https://reviews.llvm.org/D50271
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
clayborg added a comment.
In https://reviews.llvm.org/D50365#1191944, @labath wrote:
> I am not sure I'll have the resources to see this review through, so I'd
> prefer to leave this to someone else.
>
> The thoughts I have had so far are:
>
> - the patch is very big and probably runs afoul of t
erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for doing this!
Comment at: unittests/Demangle/PartialDemangleTest.cpp:188
+size_t N = OriginalSize;
+char *Res = D.getFunctionName(Buf
vsk created this revision.
Herald added a subscriber: JDevlieghere.
This is a prototype of tail call frame support for lldb based on
compiler support from https://reviews.llvm.org/D49887. It isn't ready for
review. I'm sharing the
proof-of-concept to give a heads-up about this coming down the pip
jingham accepted this revision.
jingham added a comment.
Looks good.
https://reviews.llvm.org/D50071
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: vedantk
Date: Wed Aug 8 14:26:49 2018
New Revision: 339290
URL: http://llvm.org/viewvc/llvm-project?rev=339290&view=rev
Log:
[IRMemoryMap] Shrink Allocation and make it move-only (NFC)
Profiling data show that Allocation::operator= is hot (see the data
attached to the Phab review).
Reor
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339290: [IRMemoryMap] Shrink Allocation and make it
move-only (NFC) (authored by vedantk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D5027
Author: stefan.graenitz
Date: Wed Aug 8 14:57:42 2018
New Revision: 339292
URL: http://llvm.org/viewvc/llvm-project?rev=339292&view=rev
Log:
Add ConstString test FromMidOfBufferStringRef
Summary: It was not immediately clear to me whether or not non-null-terminated
StringRef's are supported in
Author: stefan.graenitz
Date: Wed Aug 8 14:57:37 2018
New Revision: 339291
URL: http://llvm.org/viewvc/llvm-project?rev=339291&view=rev
Log:
Use rich mangling information in Symtab::InitNameIndexes()
Summary:
I set up a new review, because not all the code I touched was marked as a
change in ol
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339291: Use rich mangling information in
Symtab::InitNameIndexes() (authored by stefan.graenitz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB339292: Add ConstString test FromMidOfBufferStringRef
(authored by stefan.graenitz, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50334?vs=159298&id=159806#toc
Repository:
rLL
sgraenitz added inline comments.
Comment at: unittests/Demangle/PartialDemangleTest.cpp:188
+size_t N = OriginalSize;
+char *Res = D.getFunctionName(Buf, &N);
+EXPECT_EQ(nullptr, Res);
erik.pilkington wrote:
> Does LLDB actually pass in a N that is le
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339297: [Demangle] Add another test for
ItaniumPartialDemangler (authored by stefan.graenitz, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D50473
Files:
llvm/trunk/unittests/Demangle
teemperor created this revision.
Calling any non-libc builtin function in the expression command currently just
causes Clang
to state that the function is not known. The reason for this is that we
actually never
initialize the list of builtin functions in the Builtin::Context.
This patch just c
teemperor added a reviewer: jingham.
teemperor added a comment.
I didn't disable Windows on the test as it shouldn't call any function in the
target process. Just because I don't want to x-fail every test on Windows.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D50481
_
>
> The LLDB MI plugin didn't work very well as was quite flaky when I tested
> it a while back.
>
Just curious, what was the flaky part, the debug adapter or the LLDB MI
interface?
On Wed, Aug 8, 2018 at 8:40 AM, Greg Clayton via Phabricator <
revi...@reviews.llvm.org> wrote:
> clayborg added a
lemo added a subscriber: zturner.
lemo added a comment.
> The LLDB MI plugin didn't work very well as was quite flaky when I tested
> it a while back.
Just curious, what was the flaky part, the debug adapter or the LLDB MI
interface?
https://reviews.llvm.org/D50365
_
jasonmolenda added a comment.
Haven't had time to read through the main part of the patch, but I think the
changes to debugserver's JSON parser would be good additions even if you've
switched away from using it. The debugserver JSON parser is a copy of lldb's
with all the StringRef etc llvm cl
teemperor created this revision.
Instead of just printing the current "False is not True, ..." message when we
fail to run a certain command, this patch also adds the actual command output or
error output that we received to the assertion message.
Repository:
rLLDB LLDB
https://reviews.llvm.o
43 matches
Mail list logo
