labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good. I'm really happy with how this turned out. Thank you for your
patience.
https://reviews.llvm.org/D48060
___
lldb-commits mailing lis
labath created this revision.
labath added reviewers: clayborg, zturner.
Instead of a function taking an enum value determining which path to
return, we now have a suite of functions, each returning a single path
kind. This makes it easy to move the python-path function into a
specific plugin in a
polyakov.alex updated this revision to Diff 151682.
polyakov.alex retitled this revision from "[lldb, lldb-mi] Add method
AddCurrentTargetSharedObjectPath to the SBDebugger." to "[WIP] New class
SBTargetSettings to store and manipulate all target's properties.".
polyakov.alex edited the summary o
Author: labath
Date: Mon Jun 18 08:02:23 2018
New Revision: 334950
URL: http://llvm.org/viewvc/llvm-project?rev=334950&view=rev
Log:
Use llvm::VersionTuple instead of manual version marshalling
Summary:
This has multiple advantages:
- we need only one function argument/instance variable instead o
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334950: Use llvm::VersionTuple instead of manual version
marshalling (authored by labath, committed by ).
Herald added a s
Author: labath
Date: Mon Jun 18 08:29:42 2018
New Revision: 334952
URL: http://llvm.org/viewvc/llvm-project?rev=334952&view=rev
Log:
Attempt to fix windows&freebsd builds broken by r334950
Modified:
lldb/trunk/source/Host/freebsd/HostInfoFreeBSD.cpp
lldb/trunk/source/Host/windows/HostInfo
Author: labath
Date: Mon Jun 18 08:44:36 2018
New Revision: 334953
URL: http://llvm.org/viewvc/llvm-project?rev=334953&view=rev
Log:
Fix netbsd build broken by r334950
This also includes one more build fix for windows.
Modified:
lldb/trunk/source/Host/netbsd/HostInfoNetBSD.cpp
lldb/trunk
Author: labath
Date: Mon Jun 18 09:10:20 2018
New Revision: 334955
URL: http://llvm.org/viewvc/llvm-project?rev=334955&view=rev
Log:
Fix macosx build broken by the VersionTuple refactor
I actually did check that macos builds before committing, but this error
was in conditionally compiled code tha
clayborg added a comment.
In https://reviews.llvm.org/D47992#1134120, @apolyakov wrote:
> If you look at `bool CMICmdCmdExecContinue::Execute()`, you'll see that there
> are cases in which we need a flexible way to finish MI command(specific
> action in error case for example). We have a few op
clayborg added a comment.
Indeed!!! So happy to see this work getting done. Great stuff. Will be great to
not have to maintain the Xcode project as some point in the near future.
https://reviews.llvm.org/D48060
___
lldb-commits mailing list
lldb-co
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good. My only question is do we not require people to only fill in the
directory portion of the FileSpec anymore for these functions? I am fine with
way since hopefully FileSpec::App
Author: xiaobai
Date: Mon Jun 18 11:27:16 2018
New Revision: 334968
URL: http://llvm.org/viewvc/llvm-project?rev=334968&view=rev
Log:
Introduce lldb-framework CMake target and centralize its logic
Summary:
In this patch I aim to do the following:
1) Create an lldb-framework target that acts as t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334968: Introduce lldb-framework CMake target and centralize
its logic (authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48060
xiaobai added a comment.
Thank you @labath for your help. I'm much happier with this!
Repository:
rL LLVM
https://reviews.llvm.org/D48060
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lld
apolyakov updated this revision to Diff 151773.
apolyakov edited the summary of this revision.
apolyakov added a comment.
I removed comments about optional arguments since I didn't find any info about
it in LLVM coding style.
https://reviews.llvm.org/D47991
Files:
include/lldb/API/SBThread.h
apolyakov created this revision.
apolyakov added reviewers: aprantl, clayborg, labath.
Herald added a subscriber: ki.stfu.
The new method takes one parameter of type SBError and, if it has an error,
sets error message and returns MIstatus::failure,
returns MIstatus::success otherwise.
https://r
Author: teemperor
Date: Mon Jun 18 13:11:38 2018
New Revision: 334978
URL: http://llvm.org/viewvc/llvm-project?rev=334978&view=rev
Log:
Fixed file completion for paths that start with '~'.
We didn't add the remaining path behind the '~' to the completion string,
causing it to just complete direct
apolyakov added a comment.
This approach is quite simple and can be used in `-exec-...`, `-target-...`
and future commands.
Also, I've been thinking about another approach with having a method in
CMICmdBase that takes two parameters: pointers to a functions in which user
could specify needed
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
Comment at: tools/lldb-mi/MICmdBase.cpp:221
+// Args:error - (R) Error description object.
+// Return: None.
+// Throws: None.
It returns a bool,
aprantl added a comment.
> Also, I've been thinking about another approach with having a method in
> CMICmdBase that takes two parameters: pointers to a functions in which user
> could specify needed actions. But the main problem is that we don't have a
> knowledge about these functions, they m
apolyakov added inline comments.
Comment at: tools/lldb-mi/MICmdBase.cpp:221
+// Args:error - (R) Error description object.
+// Return: None.
+// Throws: None.
aprantl wrote:
> It returns a bool, right?
>
> At some point it sure would be nice if we could c
aprantl added inline comments.
Comment at: tools/lldb-mi/MICmdBase.cpp:221
+// Args:error - (R) Error description object.
+// Return: None.
+// Throws: None.
apolyakov wrote:
> aprantl wrote:
> > It returns a bool, right?
> >
> > At some point it sure woul
apolyakov added a comment.
I got an idea how to deal with different number of parameters: what if we
suggest to user to create own lambda functions(where he can specify needed
actions) without parameters, but with capturing required variables by reference
or by value? `auto f = [&x1, &x2...]{do
aprantl added a comment.
Can you post a more concrete example? I think this sounds like a good idea.
https://reviews.llvm.org/D48295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
apolyakov added a comment.
Sure. For example we may look at `bool CMICmdCmdExecContinue::Execute()`, there
we may see following code:
if (error.Success()) {
// CODETAG_DEBUG_SESSION_RUNNING_PROG_RECEIVED_SIGINT_PAUSE_PROGRAM
if (!CMIDriver::Instance().SetDriverStateRunningDebugging
apolyakov added a comment.
SuccessHandler and ErrorHandler will be a member variables of CMICmdBase.
https://reviews.llvm.org/D48295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
jasonmolenda created this revision.
jasonmolenda added a reviewer: JDevlieghere.
Herald added a subscriber: llvm-commits.
There's a small perf issue after the changes to r334205; the patch is intended
to search all the executables in a kext bundle to discover variants, e.g.
/System/Library/Exten
aprantl added a comment.
That sounds like a good overall direction, though I probably wouldn't
communicate the function pointers via member variables but rather prefer them
to be passed as function arguments or return values. This makes the flow a
little more obvious for readers.
https://revi
xiaobai added a comment.
Friendly ping!
https://reviews.llvm.org/D47792
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jmolenda
Date: Mon Jun 18 16:30:03 2018
New Revision: 334995
URL: http://llvm.org/viewvc/llvm-project?rev=334995&view=rev
Log:
Some NFC changes to how we scan of kexts & kernels in memory in the
DynamicLoaderDarwinKernel plugin. Created a new function ReadMachHeader
and instead of reading
teemperor created this revision.
If we have an xvalue here, we will always hit the
`err_typecheck_invalid_lvalue_addrof` error
in 'Sema::CheckAddressOfOperand' when trying to take the address of the result.
This patch
uses the fallback code path where we store the result in a local variable
ins
sas accepted this revision.
sas added a comment.
This revision is now accepted and ready to land.
LGTM for now.
https://reviews.llvm.org/D47792
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
clayborg accepted this revision.
clayborg added a comment.
Looks good to me as long as Xcode still produces the same Info.plist in its
LLDB.framework after your changes.
https://reviews.llvm.org/D47792
___
lldb-commits mailing list
lldb-commits@lis
teemperor planned changes to this revision.
teemperor added a comment.
- Needs a test
https://reviews.llvm.org/D48303
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
teemperor updated this revision to Diff 151827.
teemperor added a comment.
- Added test case
https://reviews.llvm.org/D48303
Files:
packages/Python/lldbsuite/test/expression_command/xvalue/Makefile
packages/Python/lldbsuite/test/expression_command/xvalue/TestXValuePrinting.py
packages/Pyt
teemperor updated this revision to Diff 151828.
teemperor added a comment.
- Removed now unnecessary brackets.
https://reviews.llvm.org/D48303
Files:
packages/Python/lldbsuite/test/expression_command/xvalue/Makefile
packages/Python/lldbsuite/test/expression_command/xvalue/TestXValuePrinting
xiaobai updated this revision to Diff 151840.
xiaobai added a comment.
Rebasing this commit after my framework refactor
https://reviews.llvm.org/D47792
Files:
CMakeLists.txt
cmake/modules/LLDBFramework.cmake
resources/LLDB-Info.plist
Index: resources/LLDB-Info.plist
Author: xiaobai
Date: Mon Jun 18 19:59:30 2018
New Revision: 335014
URL: http://llvm.org/viewvc/llvm-project?rev=335014&view=rev
Log:
Fix up Info.plist when building LLDB.framework with CMake
Summary:
We weren't using the Info.plist template in resources previously.
When using that template, some
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335014: Fix up Info.plist when building LLDB.framework with
CMake (authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47792
Fil
39 matches
Mail list logo
