JDevlieghere added a comment.
A few nits/stylistic comments
Comment at: tools/lldb-test/lldb-test.cpp:86
+};
+static cl::opt Lookup(
+"lookup", cl::desc("Choose lookup type:"),
It's a bit unfortunate that these argument names are different from the ones we
JDevlieghere updated this revision to Diff 144853.
JDevlieghere retitled this revision from "[lit] Make debugserver available to
lit test" to "[CMake] Unify and relayer testing".
JDevlieghere edited the summary of this revision.
JDevlieghere added reviewers: labath, aprantl.
JDevlieghere added a c
JDevlieghere added a comment.
@stella.stamenova Would you mind applying this locally and verify if it works
for the MSVC generator? It seems to work for the Xcode generator but it's
always possible that I missed something.
https://reviews.llvm.org/D46334
labath added a comment.
Looks fine to me, but I don't use multi-config generators. I'll let you and
Stella work out the details there.
https://reviews.llvm.org/D46334
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
labath accepted this revision.
labath added a comment.
I think this is fine. I would have preferred a constructor solution, but the
situation there does appear to be a bit messy. I like how you were able to
place the SetUUID method next to SetArchitecture. Thanks for your patience.
==
Author: labath
Date: Wed May 2 06:14:18 2018
New Revision: 331350
URL: http://llvm.org/viewvc/llvm-project?rev=331350&view=rev
Log:
Predicate.h: remove unused functions
The functions are unused, their comments are out of date with the
implementation, and the implementation is out of date with th
alur updated this revision to Diff 144889.
https://reviews.llvm.org/D45628
Files:
packages/Python/lldbsuite/test/linux/compressed-debug-info/Makefile
packages/Python/lldbsuite/test/linux/compressed-debug-info/TestCompressedDebugInfo.py
packages/Python/lldbsuite/test/linux/compressed-debug-
labath added inline comments.
Comment at: lit/SymbolFile/DWARF/basic-function-lookup.cpp:23
+void foo() {}
+// BASE-DAG: name = "foo()", mangled = "_Z3foov"
+// FULL-DAG: name = "foo()", mangled = "_Z3foov"
zturner wrote:
> I personally find it a little confusing
labath updated this revision to Diff 144890.
labath marked 3 inline comments as done.
labath added a comment.
Address review comments.
https://reviews.llvm.org/D46318
Files:
include/lldb/Symbol/VariableList.h
lit/CMakeLists.txt
lit/SymbolFile/DWARF/find-basic-function.cpp
lit/SymbolFile
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I don't really have an opinion on this, but I don't see why not.
https://reviews.llvm.org/D46321
___
lldb-commits mailing list
lldb-commits@lists
JDevlieghere accepted this revision.
JDevlieghere added a comment.
Thanks Adrian, this is great. Did you run your reflow script over this patch
again after this change?
https://reviews.llvm.org/D46321
___
lldb-commits mailing list
lldb-commits@list
stella.stamenova added a comment.
I am going to run the tests after you make the last few changes. I want to make
sure the compiler path is no longer being overwritten by the test cmake before
I run them.
Comment at: test/CMakeLists.txt:138
if(CMAKE_HOST_APPLE)
- list(APPEN
JDevlieghere added inline comments.
Comment at: tools/lldb-test/lldb-test.cpp:86
+};
+static cl::opt Lookup(
+"lookup", cl::desc("Choose lookup type:"),
labath wrote:
> JDevlieghere wrote:
> > It's a bit unfortunate that these argument names are different fro
JDevlieghere updated this revision to Diff 144893.
JDevlieghere marked 4 inline comments as done.
JDevlieghere added a comment.
- Address review feedback Stella
https://reviews.llvm.org/D46334
Files:
CMakeLists.txt
lit/CMakeLists.txt
lit/Suite/lit.site.cfg.in
test/CMakeLists.txt
test/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331373: Enable AUTOBRIEF in doxygen configuration. (authored
by adrian, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46321?vs=144739&id=144
Author: labath
Date: Wed May 2 10:00:33 2018
New Revision: 331374
URL: http://llvm.org/viewvc/llvm-project?rev=331374&view=rev
Log:
Fix gdb-remote qMemoryRegionInfo unit tests for xml-enabled builds
In case we are building with xml enabled, the GetMemoryRegionInfo
function will send extra packet
Author: adrian
Date: Wed May 2 10:11:43 2018
New Revision: 331375
URL: http://llvm.org/viewvc/llvm-project?rev=331375&view=rev
Log:
Silence compiler warning.
Modified:
lldb/trunk/tools/debugserver/source/RNBRemote.cpp
Modified: lldb/trunk/tools/debugserver/source/RNBRemote.cpp
URL:
http://
lemo marked an inline comment as done.
lemo added inline comments.
Comment at: source/Commands/CommandObjectTarget.cpp:1390
+else {
+ strm.Printf("No object file for module: %s\n",
+ module->GetFileSpec().GetFilename().GetCString());
That's kind of true, but also not really.. :)
If I were writing this test in dotest style (*), I would probably write
these as multiple **assertions** within a single test. So it would be
something like:
def single_test():
module = prepare()
assertEquals(module.operation1(), ["result1a", "re
labath updated this revision to Diff 144904.
labath marked 4 inline comments as done.
labath added a comment.
More review feedback.
https://reviews.llvm.org/D46318
Files:
include/lldb/Symbol/VariableList.h
lit/CMakeLists.txt
lit/SymbolFile/DWARF/find-basic-function.cpp
lit/SymbolFile/DW
labath added inline comments.
Comment at: tools/lldb-test/lldb-test.cpp:260
+if (!RE.IsValid()) {
+ errs() << "ERROR: `" << Name << "` is not a valid regular expression.\n";
+ return;
JDevlieghere wrote:
> JDevlieghere wrote:
> > You can use `WithCo
stella.stamenova added a comment.
The tests passed, but check-single was not created correctly. I added a comment
above.
Comment at: test/CMakeLists.txt:101
${LLDB_SOURCE_DIR}/test/dotest.py
"--no-multiprocess;${LLDB_DOTEST_ARGS}"
"Testing LLDB with args: ${LLDB_DOTES
aprantl created this revision.
aprantl added a reviewer: clayborg.
Herald added a subscriber: JDevlieghere.
This is a change that only affects Swift and is NFC for the language plugins on
llvm.org. In Swift, we can have global variables with a location such as
DW_OP_addr DW_OP_deref. The DWARF
This revision was automatically updated to reflect the committed changes.
lemo marked an inline comment as done.
Closed by commit rL331394: Use the UUID from the minidump's CodeView
Record for placeholder modules (authored by lemo, committed by ).
Herald added a subscriber: llvm-commits.
Changed
Author: lemo
Date: Wed May 2 13:06:17 2018
New Revision: 331394
URL: http://llvm.org/viewvc/llvm-project?rev=331394&view=rev
Log:
Use the UUID from the minidump's CodeView Record for placeholder modules
This change adds support for two types of Minidump CodeView records:
PDB70 (reference:
http
Author: rsmith
Date: Wed May 2 15:21:11 2018
New Revision: 331406
URL: http://llvm.org/viewvc/llvm-project?rev=331406&view=rev
Log:
Use conventional spelling of always-failing assert.
Fixes -Wstring-conversion warning that was breaking -Werror builds.
Modified:
lldb/trunk/source/Core/Module
JDevlieghere added inline comments.
Comment at: test/CMakeLists.txt:101
${LLDB_SOURCE_DIR}/test/dotest.py
"--no-multiprocess;${LLDB_DOTEST_ARGS}"
"Testing LLDB with args: ${LLDB_DOTEST_ARGS}"
stella.stamenova wrote:
> LLDB_DOTEST_ARGS are passed here, bu
Author: davide
Date: Wed May 2 16:36:07 2018
New Revision: 331415
URL: http://llvm.org/viewvc/llvm-project?rev=331415&view=rev
Log:
[NSDictionary] Simplify the formatter. NFCI.
Modified:
lldb/trunk/source/Plugins/Language/ObjC/NSDictionary.cpp
Modified: lldb/trunk/source/Plugins/Language/Ob
Is this really simpler? We could write it
if (name == g_zero)
return 0;
else
return UINT32_MAX;
or we could do it that way, or it could be done the way it was originally
written.
tbh it seems like a style choice, and whoever wrote it originally may have
preferred it being expressed that w
On Wed, May 2, 2018 at 4:51 PM, Jason Molenda via lldb-commits
wrote:
> Is this really simpler? We could write it
>
> if (name == g_zero)
> return 0;
> else
> return UINT32_MAX;
>
> or we could do it that way, or it could be done the way it was originally
> written.
>
> tbh it seems like a s
On Wed, May 2, 2018 at 4:56 PM, Davide Italiano wrote:
> On Wed, May 2, 2018 at 4:51 PM, Jason Molenda via lldb-commits
> wrote:
>> Is this really simpler? We could write it
>>
>> if (name == g_zero)
>> return 0;
>> else
>> return UINT32_MAX;
>>
>> or we could do it that way, or it could be
> On May 2, 2018, at 4:58 PM, Davide Italiano wrote:
>
> On Wed, May 2, 2018 at 4:56 PM, Davide Italiano wrote:
>> On Wed, May 2, 2018 at 4:51 PM, Jason Molenda via lldb-commits
>> wrote:
>>> Is this really simpler? We could write it
>>>
>>> if (name == g_zero)
>>> return 0;
>>> else
>>>
kbaladurin added a comment.
Thank you very much!
Repository:
rL LLVM
https://reviews.llvm.org/D44998
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
33 matches
Mail list logo
