[Lldb-commits] [PATCH] D43333: Add SBDebugger::GetBuildConfiguration and use it to skip an XML test

2018-02-15 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: zturner, jingham, clayborg, davide. This adds a SBDebugger::GetBuildConfiguration static function, which returns a SBStructuredData describing the the build parameters of liblldb. Right now, it just contains one entry: whether we were built wit

[Lldb-commits] [PATCH] D43335: [dosep] Run tests in a more parallel fashion

2018-02-15 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added a reviewer: aprantl. Due to in-tree builds, we were parallelizing the tests at the directory level. Now that the tests are built out-of-tree, we can remove this limitation and paralelize at file level instead. This decreases test suite time by about 10%

[Lldb-commits] [lldb] r325250 - @skipIfRemote TestTargetXMLArch

2018-02-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Feb 15 07:24:32 2018 New Revision: 325250 URL: http://llvm.org/viewvc/llvm-project?rev=325250&view=rev Log: @skipIfRemote TestTargetXMLArch The test does not actually connect to any remote targets. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/

Re: [Lldb-commits] [lldb] r324792 - Add test case for x86_64 architecture recognition in the

2018-02-15 Thread Pavel Labath via lldb-commits
This test was failing when run against a "remote" target (at least android, but possibly others). I've skipped it because it's not really applicable to the remote test suite, but I did notice something you may want to know about while investigating: The test verifies that the target triple is dedu

[Lldb-commits] [PATCH] D43335: [dosep] Run tests in a more parallel fashion

2018-02-15 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This is very cool! I imagine that this will help a lot with TestIntegerTypes and other really long-running ones. Thanks. https://reviews.llvm.org/D43335 _

[Lldb-commits] [PATCH] D43333: Add SBDebugger::GetBuildConfiguration and use it to skip an XML test

2018-02-15 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Think if we want to cache the configuration in case we start using this a lot more in the test suite. Doesn't need to be done now. Comment at: packages/Python/lldbsuite/

[Lldb-commits] [PATCH] D43333: Add SBDebugger::GetBuildConfiguration and use it to skip an XML test

2018-02-15 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. Caching this value wouldn't hurt, but the the multi-process runner will mostly defeat that so it doesn't seem crucial. The API is fine, the name is pretty obvious, but still some doc wouldn't hurt. I was wondering if there was a straightf

[Lldb-commits] [PATCH] D43335: [dosep] Run tests in a more parallel fashion

2018-02-15 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. Very nice! Thanks for working on this! https://reviews.llvm.org/D43335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D43333: Add SBDebugger::GetBuildConfiguration and use it to skip an XML test

2018-02-15 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added inline comments. Comment at: source/API/SBDebugger.cpp:497 + auto config_up = llvm::make_unique(); + config_up->AddBooleanItem("xml", XMLDocument::XMLEnabled()); + Do we want a more self documenting format of the JSON? Maybe "xml" is a dictionar