jingham accepted this revision.
jingham added a comment.

Caching this value wouldn't hurt, but the the multi-process runner will mostly 
defeat that so it doesn't seem crucial.

The API is fine, the name is pretty obvious, but still some doc wouldn't hurt.

I was wondering if there was a straightforward way we could document the 
elements.  Be nice not to have to read source to see what these mean.  OTOH, I 
don't think we want to produce it in this dictionary, that makes the checks 
more expensive.  So if we find we need it we can add a doc API that generates a 
parallel doc tree.  But I don't think it's necessary to do that right now.


https://reviews.llvm.org/D43333



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to