[Lldb-commits] [lldb] r323855 - Fix TestTargetSymbolsAddCommand makefile

Author: labath Date: Wed Jan 31 01:14:12 2018 New Revision: 323855 URL: http://llvm.org/viewvc/llvm-project?rev=323855&view=rev Log: Fix TestTargetSymbolsAddCommand makefile We started passing the "all" target to make, which rendered the "localall" trick in this Makefile inoperable. I implement

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

labath added a comment. In https://reviews.llvm.org/D42145#992289, @owenpshaw wrote: > > So the main question is: do we want WriteMemory to work anywhere and always > > try to do the right thing, or return an error an the user would be expected > > to know to check the memory region you are wri

[Lldb-commits] [lldb] r323879 - [lldb] Enable debugging of binaries with mixed (splitted/regular) dwarf

Author: davide Date: Wed Jan 31 07:17:47 2018 New Revision: 323879 URL: http://llvm.org/viewvc/llvm-project?rev=323879&view=rev Log: [lldb] Enable debugging of binaries with mixed (splitted/regular) dwarf This recommits the patch, now that I verified that the bot instability is due to something e

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

labath added a comment. In https://reviews.llvm.org/D42281#992359, @aprantl wrote: > In https://reviews.llvm.org/D42281#992295, @aprantl wrote: > > > There are a few test failures, but they look manageable. I will need help > > resolving them though: > > > Updated list: > > http://lab.llvm.org:8

[Lldb-commits] [lldb] r323884 - Fix TestMixedDwarfBinary.py

Author: labath Date: Wed Jan 31 08:23:24 2018 New Revision: 323884 URL: http://llvm.org/viewvc/llvm-project?rev=323884&view=rev Log: Fix TestMixedDwarfBinary.py As of yesterday, tests need to use self.getBuildArtifact() to get the built executable. Modified: lldb/trunk/packages/Python/lldbs

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

aprantl added a comment. Thanks a lot for your help, Pavel! We also discovered the most amazing test failure on the green dragon bots yesterday (fix still underway) that was made much worse by my patch. On Darwin LLDB automatically tries to find a .dSYM bundle for an executable by querying the

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

owenpshaw added a comment. > How does the flash memory behave from the POV of the debugged process? Just tested on a couple targets and they both silently failed to change the flash memory. So no exception, but no flash write either. Unless there are objections, I'll work on some changes along

[Lldb-commits] [PATCH] D42443: [SymbolFilePDB] Add support for function symbols

zturner added inline comments. Comment at: lit/SymbolFile/PDB/Inputs/FuncSymbols.cpp:2 +// Static function +static long StaticFunction(int a) +{ Would it be worth trying one in an anonymous namespace? Comment at: lit/SymbolFile/PDB/func-symbols

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

owenpshaw updated this revision to Diff 132260. owenpshaw added a comment. - Remove Begin/End memory batch API - Add Process::WriteObjectFile(llvm::ArrayRef) method. Open to other names since it's not necessarily specific to object files, but wanted to somehow indicate that the method may do an

[Lldb-commits] [lldb] r323917 - replace os.mkdirs with lldbutil.mkdir_p (NFC)

Author: adrian Date: Wed Jan 31 13:39:00 2018 New Revision: 323917 URL: http://llvm.org/viewvc/llvm-project?rev=323917&view=rev Log: replace os.mkdirs with lldbutil.mkdir_p (NFC) Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py lldb

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

aprantl created this revision. aprantl added reviewers: labath, zturner, jingham. Herald added subscribers: JDevlieghere, eraman. This patch creates a .dwarf, .dwo, etc., build directory for each testcase variant. Most importantly, this eliminates the need for the per-test lock file in the sourc

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

xiaobai added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/breakpoint/comp_dir_symlink/TestCompDirSymLink.py:39-40 (_COMP_DIR_SYM_LINK_PROP, pwd_symlink)) -lldbutil.run_break_set_by_file_and_line(self, self.src_path, self.line)

[Lldb-commits] [PATCH] D39307: Fix global data symbol resolution

xiaobai abandoned this revision. xiaobai added a comment. It's clear this is not the way forward. The problem I am trying to solve should be attacked differently. Thanks everyone for your input! https://reviews.llvm.org/D39307 ___ lldb-commits mail

[Lldb-commits] [PATCH] D39307: Fix global data symbol resolution

jingham added a comment. @rsmith: lldb does as you suggest, if it can find a name in the local context, it returns that, if it can find it in the current CU, it returns that, etc... It only returns multiple matches if it can't find a single instance along that chain. The problem with this cas

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

xiaobai added a comment. Oh, FWIW I tested this on Linux (specifically CentOS) and the test result summary showed no difference in Success/Failure rate. https://reviews.llvm.org/D42763 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http: