Re: [Lldb-commits] [lldb] r322339 - When parsing the target.xml register file, if no architecture has

The budding gdb-client test suite might be an option for this. On 29 January 2018 at 18:17, Jason Molenda via lldb-commits wrote: > > >> On Jan 28, 2018, at 9:59 PM, Davide Italiano wrote: >> >> On Thu, Jan 11, 2018 at 5:26 PM, Davide Italiano >> wrote: >>> On

[Lldb-commits] [lldb] r323736 - Skip TestWithModuleDebugging on i386 linux (pr36146)

Author: labath Date: Tue Jan 30 01:39:22 2018 New Revision: 323736 URL: http://llvm.org/viewvc/llvm-project?rev=323736&view=rev Log: Skip TestWithModuleDebugging on i386 linux (pr36146) It fails due to an assertion (if these are enabled). Modified: lldb/trunk/packages/Python/lldbsuite/test/

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

labath added a comment. I'll leave it up to others to say whether this solution is fully correct, but I have to say that it looks much cleaner than the previous one. Comment at: packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/Makefile:1-17 +.PHONY : all +.PHO

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

labath added a comment. I still like my `WriteMemory(ArrayRef)` proposal the best. If you don't have any special writing requirements, it can be viewed as a convenience wrapper for the one-shot `WriteMemory`, and if a subclass needs special handling, it can implement it in a smarter way (while

[Lldb-commits] [lldb] r323744 - Fix TestGDBRemoteClient on windows

Author: labath Date: Tue Jan 30 02:41:46 2018 New Revision: 323744 URL: http://llvm.org/viewvc/llvm-project?rev=323744&view=rev Log: Fix TestGDBRemoteClient on windows The logic was incorrect because on windows, we need to look for yaml2obj.EXE. I implement the search in terms of distutils.spawn.

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

alexshap updated this revision to Diff 131938. alexshap added a comment. Update makefile Repository: rL LLVM https://reviews.llvm.org/D42563 Files: packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/Makefile packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/

[Lldb-commits] [PATCH] D42182: Add LLDB_LOG_ERROR (?)

labath added a comment. It looks like we haven't come up with a better name, and there's new code in https://reviews.llvm.org/D42468 which would benefit a lot from this functionality, so I'm going to land this. I don't expect hundreds of uses of this macro appearing any time soon, so it should

[Lldb-commits] [lldb] r323753 - Add LLDB_LOG_ERROR macro

Author: labath Date: Tue Jan 30 04:19:34 2018 New Revision: 323753 URL: http://llvm.org/viewvc/llvm-project?rev=323753&view=rev Log: Add LLDB_LOG_ERROR macro Summary: The difference between this and regular LLDB_LOG is that this one clears the error object unconditionally. This was inspired by t

[Lldb-commits] [PATCH] D42182: Add LLDB_LOG_ERROR (?)

This revision was automatically updated to reflect the committed changes. Closed by commit rL323753: Add LLDB_LOG_ERROR macro (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42182?vs=130176&id=131944#toc Repositor

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

tberghammer accepted this revision. tberghammer added a comment. Thank you for looking into this. The change looks good on Linux with both normal-dwarf, split-dwarf and mixed-dwarf (as well as with dwp) but can you (or somebody from Apple) please make sure it doesn't break MachO and/or dSym (I

[Lldb-commits] [lldb] r323763 - One more TestGDBRemoteClient/windows fix

Author: labath Date: Tue Jan 30 06:33:54 2018 New Revision: 323763 URL: http://llvm.org/viewvc/llvm-project?rev=323763&view=rev Log: One more TestGDBRemoteClient/windows fix We also need to be .EXE-aware when searching for the clang binary. Modified: lldb/trunk/packages/Python/lldbsuite/test

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

labath accepted this revision. labath added a comment. Right, so I tried this out on windows today (targetting android, because I know the state of that target, but I think this should catch problems with windows host builds as well). The main problem i ran into is that `$(realpath)` is just br

[Lldb-commits] [lldb] r323789 - Enforce that tests building with buildDefault set NO_DEBUG_INFO_TESTCASE

Author: adrian Date: Tue Jan 30 09:02:42 2018 New Revision: 323789 URL: http://llvm.org/viewvc/llvm-project?rev=323789&view=rev Log: Enforce that tests building with buildDefault set NO_DEBUG_INFO_TESTCASE and fix resulting errors. This is a prerequisite for building each test variant in its own

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

owenpshaw added a comment. This discussion has got me questioning if WriteMemory is even the best place to put the flash commands. It seems like some of the concern here is around the behavior of arbitrary memory writes to flash regions, which isn't really the main objective of this patch (sup

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

aprantl added a comment. Let's see how this fares on the bots. As I mentioned in the commit message, please don't hesitate to revert this patch. I'm watching all bots connected to lab.llvm.org, and green.lab.llvm.org but please let me know if I'm missing something. Repository: rL LLVM http

[Lldb-commits] [lldb] r323805 - Rewrite this test not to use pexpect.

Author: jingham Date: Tue Jan 30 10:43:31 2018 New Revision: 323805 URL: http://llvm.org/viewvc/llvm-project?rev=323805&view=rev Log: Rewrite this test not to use pexpect. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/completion/TestCompletion.py Modified: lldb/trunk/

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

alexshap added inline comments. Comment at: packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/Makefile:10-12 +.PHONY: clean +clean:: + $(RM) -f a.dwo a.o b.o main tberghammer wrote: > Do you need this? I think Makefile.rules should generate

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

davide accepted this revision. davide added a subscriber: aprantl. davide added a comment. This revision is now accepted and ready to land. This looks good. Feel free to go ahead and commit, but please coordinate with @aprantl as he just landed his changes for the testsuite (so you might need to

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

clayborg added a comment. In https://reviews.llvm.org/D42145#991459, @owenpshaw wrote: > Thanks. What I'm struggling to reconcile are your statements that users > should not have to know how things must happen, but then that we should make > ObjectFile::Load smart so it doesn't result in an un

[Lldb-commits] [lldb] r323808 - Add more diagnostics to help diagnose flaky test

Author: adrian Date: Tue Jan 30 11:40:09 2018 New Revision: 323808 URL: http://llvm.org/viewvc/llvm-project?rev=323808&view=rev Log: Add more diagnostics to help diagnose flaky test Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/TestBadAddr

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

clayborg added a comment. In https://reviews.llvm.org/D42145#991985, @owenpshaw wrote: > This discussion has got me questioning if WriteMemory is even the best place > to put the flash commands. It seems like some of the concern here is around > the behavior of arbitrary memory writes to flash

[Lldb-commits] [lldb] r323809 - PR25934: Skip EventAPITestCase. It still SEGV's on Darwin.

Author: vedantk Date: Tue Jan 30 11:49:05 2018 New Revision: 323809 URL: http://llvm.org/viewvc/llvm-project?rev=323809&view=rev Log: PR25934: Skip EventAPITestCase. It still SEGV's on Darwin. See: https://ci.swift.org/job/swift-lldb-PR-osx/39 llvm.org/PR25934 Modified: lldb/trunk/packages/

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

owenpshaw added a comment. > So the main question is: do we want WriteMemory to work anywhere and always > try to do the right thing, or return an error an the user would be expected > to know to check the memory region you are writing to and know to call > "Process::WriteFlash(...)". I vote to

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

aprantl added a comment. There are a few test failures, but they look manageable. I will need help resolving them though: http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/7843 FAIL: TestLoadUnload.LoadUnloadTestCase.test_lldb_process_load_and_unload_commands_dwarf http://lab.llvm

Re: [Lldb-commits] [lldb] r323809 - PR25934: Skip EventAPITestCase. It still SEGV's on Darwin.

Nice, I wanted to do the same. -- Davide On Tue, Jan 30, 2018 at 11:49 AM, Vedant Kumar via lldb-commits wrote: > Author: vedantk > Date: Tue Jan 30 11:49:05 2018 > New Revision: 323809 > > URL: http://llvm.org/viewvc/llvm-project?rev=323809&view=rev > Log: > PR25934: Skip EventAPITestCase. It s

[Lldb-commits] [lldb] r323817 - XUnit Formatter: Handle UTF-8 decode errors on invalid XML

Author: vedantk Date: Tue Jan 30 13:16:42 2018 New Revision: 323817 URL: http://llvm.org/viewvc/llvm-project?rev=323817&view=rev Log: XUnit Formatter: Handle UTF-8 decode errors on invalid XML Strings which contain garbage data can trigger an exception in the XUnit plugin at the UTF-8 decode step

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

aprantl added a comment. In https://reviews.llvm.org/D42281#992295, @aprantl wrote: > There are a few test failures, but they look manageable. I will need help > resolving them though: Updated list: http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/7843 FAIL: TestLoadUnload.Load

Re: [Lldb-commits] [lldb] r323817 - XUnit Formatter: Handle UTF-8 decode errors on invalid XML

On Tue, Jan 30, 2018 at 1:16 PM, Vedant Kumar via lldb-commits wrote: > Author: vedantk > Date: Tue Jan 30 13:16:42 2018 > New Revision: 323817 > > URL: http://llvm.org/viewvc/llvm-project?rev=323817&view=rev > Log: > XUnit Formatter: Handle UTF-8 decode errors on invalid XML > > Strings which con

[Lldb-commits] [lldb] r323830 - Enforce that NO_DEBUG_INFO_TESTCASEs build using buildDefault().

Author: adrian Date: Tue Jan 30 15:15:49 2018 New Revision: 323830 URL: http://llvm.org/viewvc/llvm-project?rev=323830&view=rev Log: Enforce that NO_DEBUG_INFO_TESTCASEs build using buildDefault(). This is a prerequisite for building each test variant in its own subdirectory. Modified: lldb/

[Lldb-commits] [lldb] r323832 - [lldb] Enable debugging of binaries with mixed (splitted/regular) dwarf

Author: alexshap Date: Tue Jan 30 15:45:20 2018 New Revision: 323832 URL: http://llvm.org/viewvc/llvm-project?rev=323832&view=rev Log: [lldb] Enable debugging of binaries with mixed (splitted/regular) dwarf Initialize the default value of SymbolFileDWARF uuid with the appropriately shifted DW_IN

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

This revision was automatically updated to reflect the committed changes. Closed by commit rL323832: [lldb] Enable debugging of binaries with mixed (splitted/regular) dwarf (authored by alexshap, committed by ). Changed prior to commit: https://reviews.llvm.org/D42563?vs=131938&id=132067#toc R

Re: [Lldb-commits] [lldb] r323832 - [lldb] Enable debugging of binaries with mixed (splitted/regular) dwarf

On Tue, Jan 30, 2018 at 3:45 PM, Alexander Shaposhnikov via lldb-commits wrote: > Author: alexshap > Date: Tue Jan 30 15:45:20 2018 > New Revision: 323832 > > URL: http://llvm.org/viewvc/llvm-project?rev=323832&view=rev > Log: > [lldb] Enable debugging of binaries with mixed (splitted/regular) dwa

[Lldb-commits] [lldb] r323845 - Revert "[lldb] Enable debugging of binaries with mixed (splitted/regular) dwarf"

Author: davide Date: Tue Jan 30 20:13:37 2018 New Revision: 323845 URL: http://llvm.org/viewvc/llvm-project?rev=323845&view=rev Log: Revert "[lldb] Enable debugging of binaries with mixed (splitted/regular) dwarf" It might have caused some instability on the bots. Removed: lldb/trunk/packag

Re: [Lldb-commits] [lldb] r323832 - [lldb] Enable debugging of binaries with mixed (splitted/regular) dwarf

I went ahead for now and reverted in the hope this makes the bot green (again). Committing to https://llvm.org/svn/llvm-project/lldb/trunk ... commit f5d7ce2552c2003379bdbe78737f12dd50832b0d Author: Davide Italiano Date: Tue Jan 30 20:14:32 2018 -0800 Revert "[lldb] Enable debugging of bin

Re: [Lldb-commits] [lldb] r323832 - [lldb] Enable debugging of binaries with mixed (splitted/regular) dwarf

http://lab.llvm.org:8080/green/view/LLDB/job/lldb-xcode/4609/ (after the revert) - the same 4 failures or am I missing smth ? Thanks, Alexander On Tue, Jan 30, 2018 at 8:16 PM, Davide Italiano wrote: > I went ahead for now and reverted in the hope this makes the bot green > (again). > > Commit

Re: [Lldb-commits] [lldb] r323832 - [lldb] Enable debugging of binaries with mixed (splitted/regular) dwarf

yes, apologies. I'll recommit in a minute. -- Davide On Tue, Jan 30, 2018 at 9:47 PM, Александр Шапошников wrote: > http://lab.llvm.org:8080/green/view/LLDB/job/lldb-xcode/4609/ (after the > revert) - the same 4 failures or am I missing smth ? > > Thanks, > Alexander > > On Tue, Jan 30, 2018 at