[Lldb-commits] [lldb] r323081 - Fix unrepresentable float value in ScalarTest

Author: teemperor Date: Mon Jan 22 00:11:29 2018 New Revision: 323081 URL: http://llvm.org/viewvc/llvm-project?rev=323081&view=rev Log: Fix unrepresentable float value in ScalarTest Summary: float can't represent the given value in the literal, so we get this UB error: `runtime error: 1.23457e+4

[Lldb-commits] [PATCH] D42338: Fix unrepresentable float value in ScalarTest

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL323081: Fix unrepresentable float value in ScalarTest (authored by teemperor, committed by ). Herald added a subscriber: l

[Lldb-commits] [PATCH] D42348: Prevent unaligned memory read in parseMinidumpString

teemperor added a reviewer: davide. teemperor added a comment. Thanks, I think only this and the first GoParser patch ( https://reviews.llvm.org/D42339 ) needs some double checking, the others ( https://reviews.llvm.org/D42346, https://reviews.llvm.org/D42338 ) are trivial and I'll merge in the

[Lldb-commits] [PATCH] D42346: Fix use after free in DiskFilesOrDirectories

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL323082: Fix use after free in DiskFilesOrDirectories (authored by teemperor, committed by ). Herald added a subscriber: ll

[Lldb-commits] [lldb] r323082 - Fix use after free in DiskFilesOrDirectories

Author: teemperor Date: Mon Jan 22 01:17:16 2018 New Revision: 323082 URL: http://llvm.org/viewvc/llvm-project?rev=323082&view=rev Log: Fix use after free in DiskFilesOrDirectories Summary: We copy the local variable `Resolved` into `Storage` to keep it around. However, we then still let the `Se

[Lldb-commits] [PATCH] D42347: Fix memory leaks in MinidumpParserTest

teemperor updated this revision to Diff 130846. teemperor added a comment. - Using make_unique now. https://reviews.llvm.org/D42347 Files: unittests/Process/minidump/MinidumpParserTest.cpp Index: unittests/Process/minidump/MinidumpParserTest.cpp =

[Lldb-commits] [lldb] r323085 - Fix memory leaks in MinidumpParserTest

Author: teemperor Date: Mon Jan 22 01:48:40 2018 New Revision: 323085 URL: http://llvm.org/viewvc/llvm-project?rev=323085&view=rev Log: Fix memory leaks in MinidumpParserTest Summary: We never delete the allocated RegisterContext objects, causing those tests to fail with enabled memory sanitizer

[Lldb-commits] [PATCH] D42347: Fix memory leaks in MinidumpParserTest

This revision was automatically updated to reflect the committed changes. Closed by commit rL323085: Fix memory leaks in MinidumpParserTest (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42347?vs=130846&id=1308

[Lldb-commits] [lldb] r323086 - Fix TestTargetSymbolsAddCommand [getBuildArtifact refactor]

Author: labath Date: Mon Jan 22 01:55:30 2018 New Revision: 323086 URL: http://llvm.org/viewvc/llvm-project?rev=323086&view=rev Log: Fix TestTargetSymbolsAddCommand [getBuildArtifact refactor] Modified: lldb/trunk/packages/Python/lldbsuite/test/linux/add-symbols/TestTargetSymbolsAddCommand.p

[Lldb-commits] [PATCH] D42195: [lldb] Generic base for testing gdb-remote behavior

labath added subscribers: krytarowski, jingham, davide. labath added a comment. In https://reviews.llvm.org/D42195#982035, @owenpshaw wrote: > - Added yaml2obj dependency. It it okay to be an unconditional dependency? Yeah, it probably needs to be conditional (if(TARGET yaml2obj)), because st

[Lldb-commits] [lldb] r323100 - Add SysV Abi for PPC64le

Author: labath Date: Mon Jan 22 03:27:43 2018 New Revision: 323100 URL: http://llvm.org/viewvc/llvm-project?rev=323100&view=rev Log: Add SysV Abi for PPC64le Summary: This patch implements the ABI Plugin for PPC64le. It was based on the ABI for PPC64. It also enables LLDB to evaluate expressions

[Lldb-commits] [PATCH] D42280: Wrap all references to build artifacts in the LLDB testsuite in TestBase::getBuildArtifact()

labath added a comment. In https://reviews.llvm.org/D42280#982229, @jingham wrote: > I didn't intend to block this patch, just to point out that this was really > work you shouldn't have had to do, and that as we touch these files we should > clean them up so next time we don't have to. It wil

[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le

This revision was automatically updated to reflect the committed changes. Closed by commit rL323100: Add SysV Abi for PPC64le (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D41702?vs=130236&id=130860#toc Repositor

[Lldb-commits] [PATCH] D42339: Fix uninitialized variable in GoParser

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm (the go plugin is kinda unmaintained now...) https://reviews.llvm.org/D42339 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:

[Lldb-commits] [lldb] r323102 - Revert "[SymbolFilePDB] Fix null array access when parsing the type of a function without any arguments, i.e. 'int main()' and add support to test it"

Author: labath Date: Mon Jan 22 03:51:56 2018 New Revision: 323102 URL: http://llvm.org/viewvc/llvm-project?rev=323102&view=rev Log: Revert "[SymbolFilePDB] Fix null array access when parsing the type of a function without any arguments, i.e. 'int main()' and add support to test it" This reverts

[Lldb-commits] [PATCH] D41427: [SymbolFilePDB] Fix null array access when parsing the type of a function without any arguments, i.e. 'int main()' and add support to test it

labath added a comment. I have reverted this because this breaks the lldb-Unit::SymbolFilePDBTests.TestTypedefs test http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/7715. My guess is that this is because you did not update the checked-in exe to account for the changes in it's

[Lldb-commits] [PATCH] D42195: [lldb] Generic base for testing gdb-remote behavior

krytarowski added a comment. yaml2obj looks like a program from LLVM and we build and install it in pkgsrc. https://reviews.llvm.org/D42195 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [lldb] r323119 - Fix uninitialized variable in GoParser

Author: teemperor Date: Mon Jan 22 06:32:43 2018 New Revision: 323119 URL: http://llvm.org/viewvc/llvm-project?rev=323119&view=rev Log: Fix uninitialized variable in GoParser Summary: `m_last_tok` isn't initialized anywhere before it's used the first time (most likely in the `GoParser::Rule::err

[Lldb-commits] [PATCH] D42339: Fix uninitialized variable in GoParser

This revision was automatically updated to reflect the committed changes. Closed by commit rL323119: Fix uninitialized variable in GoParser (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42339?vs=130779&id=1308

[Lldb-commits] [PATCH] D42348: Prevent unaligned memory read in parseMinidumpString

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Did you run the testsuite? If it's clean, feel free to merge. https://reviews.llvm.org/D42348 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D42339: Fix uninitialized variable in GoParser

davide added a comment. LGTM. FWIW, if people are not maintaining the `Go` and the `Java` plugin we should consider removing them entirely. It's a huge amount of code and if there are no users/developers, it's really not worth the trouble. Repository: rL LLVM https://reviews.llvm.org/D42339

[Lldb-commits] [PATCH] D40283: lldb: Use the DWARF linkage name when importing C++ methods

clayborg added a comment. I am fine with checking this. The only issue on my end is the extra memory that will be needed to store these often huge mangled names in every AST context for the 0.0001% of the time it is actually needed. https://reviews.llvm.org/D40283 __

[Lldb-commits] [PATCH] D40283: lldb: Use the DWARF linkage name when importing C++ methods

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Thanks Greg. I'll wait another day and check this one in. Nelson, does the plan make sense to you? https://reviews.llvm.org/D40283 ___ lldb-comm

[Lldb-commits] [PATCH] D40283: lldb: Use the DWARF linkage name when importing C++ methods

aprantl added a comment. In https://reviews.llvm.org/D40283#983908, @clayborg wrote: > I am fine with checking this. The only issue on my end is the extra memory > that will be needed to store these often huge mangled names in every AST > context for the 0.0001% of the time it is actually neede

[Lldb-commits] [PATCH] D40283: lldb: Use the DWARF linkage name when importing C++ methods

davide added a comment. In https://reviews.llvm.org/D40283#983946, @aprantl wrote: > In https://reviews.llvm.org/D40283#983908, @clayborg wrote: > > > I am fine with checking this. The only issue on my end is the extra memory > > that will be needed to store these often huge mangled names in eve

[Lldb-commits] [PATCH] D40283: lldb: Use the DWARF linkage name when importing C++ methods

nelhage added a comment. > Thanks Greg. I'll wait another day and check this one in. Nelson, does the > plan make sense to you? Yep, sounds great. Thanks so much. I'd prefer to not gate this on !Darwin, since the added complexity seems unfortunate, and this isn't, strictly-speaking, only about

[Lldb-commits] [PATCH] D40283: lldb: Use the DWARF linkage name when importing C++ methods

aprantl added a comment. As Greg pointed out C++ (and Swift) mangled names can be enormous, so it would definitely have an impact on the memory footprint (unless we are only passing `StringRef`s around. Are we?) https://reviews.llvm.org/D40283 ___

[Lldb-commits] [PATCH] D42195: [lldb] Generic base for testing gdb-remote behavior

owenpshaw updated this revision to Diff 130920. owenpshaw added a comment. Added back socket close() It looks like the yaml2obj target hasn't been defined yet when the check-lldb target is defined, so if(TARGET yaml2obj) always returns false. Is there another way to do the conditional dependen

[Lldb-commits] [PATCH] D40283: lldb: Use the DWARF linkage name when importing C++ methods

clayborg added a comment. In https://reviews.llvm.org/D40283#983997, @aprantl wrote: > As Greg pointed out C++ (and Swift) mangled names can be enormous, so it > would definitely have an impact on the memory footprint (unless we are only > passing `StringRef`s around. Are we?) Most strings se

[Lldb-commits] [PATCH] D39967: Refactoring of MemoryWrite function

tatyana-krasnukha added a comment. Herald added a subscriber: llvm-commits. What about having 2 versions: 1. WriteMemory(..., bool force = false), that fails if there are breakpoints in the area. Let user decide what to do. If force == true just call DoWriteMemory without checking on breakpoint

[Lldb-commits] [lldb] r323138 - Fix memory leak in TestClangASTContext.TestRecordHasFields

Author: teemperor Date: Mon Jan 22 10:56:33 2018 New Revision: 323138 URL: http://llvm.org/viewvc/llvm-project?rev=323138&view=rev Log: Fix memory leak in TestClangASTContext.TestRecordHasFields Summary: We can't use unique_ptr's here because we use those variables as `out` parameters to some fu

[Lldb-commits] [PATCH] D42386: Fix memory leak in TestClangASTContext.TestRecordHasFields

teemperor created this revision. We can't use unique_ptr's here because we use those variables as `out` parameters to some functions. Discovered by the memory sanitizer. https://reviews.llvm.org/D42386 Files: unittests/Symbol/TestClangASTContext.cpp Index: unittests/Symbol/TestClangASTCont

[Lldb-commits] [PATCH] D39967: Refactoring of MemoryWrite function

clayborg added a comment. This will need a test, preferable covering all of the cases: - breakpoint right at start with extra data after - breakpoint right at start with no extra data after - breakpoint in middle of ranges with data before and after - breakpoint at end of range with no data after

[Lldb-commits] [PATCH] D42386: Fix memory leak in TestClangASTContext.TestRecordHasFields

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL323138: Fix memory leak in TestClangASTContext.TestRecordHasFields (authored by teemperor, committed by ). Herald added a

[Lldb-commits] [PATCH] D39969: Set error status in ObjectFile::LoadInMemory if it is not set

clayborg added a comment. I am not sure we can say for sure that a breakpoint intersected with the write here? I would rather just have an error saying something like "only %u of %u bytes in section %s were written". Extra credit for checking if there are overlapping breakpoints and appending "

[Lldb-commits] [PATCH] D39969: Set error status in ObjectFile::LoadInMemory if it is not set

tatyana-krasnukha added a comment. Yes, I see... There is some inconsistency between status and returned value. That is why I wandered about this https://reviews.llvm.org/D39967#984065 https://reviews.llvm.org/D39969 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D39969: Set error status in ObjectFile::LoadInMemory if it is not set

clayborg added a comment. And yes, if the write memory can only write fewer byte than requested, it won't be an error if at least some bytes were written https://reviews.llvm.org/D39969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

Re: [Lldb-commits] [PATCH] D42280: Wrap all references to build artifacts in the LLDB testsuite in TestBase::getBuildArtifact()

That sounds like a great idea. It should make a nice half-way between the regular SB tests and the inline tests. The latter are super easy to write, which is nice, but hard to debug - particularly when you have to insert some more error output because the test only fails on a bot or some syste

Re: [Lldb-commits] [PATCH] D42195: [lldb] Generic base for testing gdb-remote behavior

> On Jan 22, 2018, at 3:10 AM, Pavel Labath via Phabricator > wrote: > > labath added subscribers: krytarowski, jingham, davide. > labath added a comment. > > In https://reviews.llvm.org/D42195#982035, @owenpshaw wrote: > >> - Added yaml2obj dependency. It it okay to be an unconditional dep

[Lldb-commits] [lldb] r323163 - [lldb] Fix some C++ virtual method call bugs in LLDB expression evaluation by

Author: lhames Date: Mon Jan 22 15:53:56 2018 New Revision: 323163 URL: http://llvm.org/viewvc/llvm-project?rev=323163&view=rev Log: [lldb] Fix some C++ virtual method call bugs in LLDB expression evaluation by building method override tables for CXXMethodDecls in DWARFASTParserClang::CompleteTyp

[Lldb-commits] [PATCH] D41997: Build virtual override tables in DWARFASTParserClang::CompleteTypeFromDWARF

lhames accepted this revision. lhames added a comment. Committed in r323163. Comment at: Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2106 +// a vtable entry) from overloads (which require distinct entries). +static bool isOverload(clang::CXXMethodDecl *m1, clang::CXXMethod

[Lldb-commits] [PATCH] D41997: Build virtual override tables in DWARFASTParserClang::CompleteTypeFromDWARF

clayborg added a comment. Sounds good then. Repository: rL LLVM https://reviews.llvm.org/D41997 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D42277: Use test-specific module caches to avoid stale header conflicts

vsk updated this revision to Diff 131000. vsk added a comment. - Skip tests which fail when -fmodules is passed (https://bugs.llvm.org/show_bug.cgi?id=36048). https://reviews.llvm.org/D42277 Files: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-cpp/TestDataForm