labath added a comment.
This is making the windows unit tests fail:
http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/7378/steps/run%20unit%20tests/logs/stdio.
If I understand correctly, this changes FindTypes to **not** search by regex.
If that's the case, then the `SymbolFilePDBTe
Author: labath
Date: Fri Dec 22 02:26:59 2017
New Revision: 321353
URL: http://llvm.org/viewvc/llvm-project?rev=321353&view=rev
Log:
Enable TestReadMemCString on non-darwin targets
The test works fine on linux, and I believe other targets should not
have an issue with as well. If they do, we can
Author: labath
Date: Fri Dec 22 03:09:21 2017
New Revision: 321355
URL: http://llvm.org/viewvc/llvm-project?rev=321355&view=rev
Log:
debugserver: Propagate environment in launch-mode (pr35671)
Summary:
Make sure we propagate environment when starting debugserver with a pre-loaded
inferior. AFAIK,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321355: debugserver: Propagate environment in launch-mode
(pr35671) (authored by labath, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D41352
Files:
lldb/trunk/tools/debugserver/sourc
We should fix the test case to not require regex, or add
SymbolFile::FindTypesByRegex(...) and pass that through to public API if
needed. Not sure where the test is failing (gtest, or public API test).
> On Dec 22, 2017, at 2:01 AM, Pavel Labath via Phabricator
> wrote:
>
> labath added a com
The url provided times out but my guess is these two unit tests are
what are failing.
lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp
- TEST_F(SymbolFilePDBTests, TestRegexNameMatch)
- TEST_F(SymbolFilePDBTests, TestMaxMatches)
The first one is testing regex name matching which was decided i
asmith created this revision.
asmith added reviewers: zturner, lldb-commits, labath, clayborg.
https://reviews.llvm.org/D41086 fixed an exception in
FindTypes()/FindTypesByRegex() and caused two lldb unit test to fail. This
change updates the unit tests to pass again.
Related review:
https://re
asmith updated this revision to Diff 128069.
asmith retitled this revision from "[lldb] Fix crash when parsing the type of a
function without any arguments" to "Fix crash when parsing the type of a
function without any arguments".
asmith edited the summary of this revision.
Repository:
rL LLVM
zturner added a comment.
This was originally written as a unit test because at the time we didn't have
`lldb-test`. To be honest I think it's time to remove these checked in
binaries and convert everything to FileCheck tests. There's a couple of
reasons this is more practical. For starters,
