[Lldb-commits] [PATCH] D37154: lldb-mi: -var-update can hang when traversing complex types with pointers

ted added a comment. We want to go down into a pointer if it's the original parent, but not into a child that's a pointer. To avoid skipping children of a top-level pointer/reference, I think we need to do the type check in the loop. https://reviews.llvm.org/D37154 _

[Lldb-commits] [PATCH] D37154: lldb-mi: -var-update can hang when traversing complex types with pointers

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Makes sense even though this can be quite expensive. https://reviews.llvm.org/D37154 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D36598: cmake + xcode: prevent gtests from using includes from project root

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. This LGTM. https://reviews.llvm.org/D36598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] r312267 - [TypeSystem] Reduce code duplication merging two almost identical functions.

Author: davide Date: Thu Aug 31 11:47:49 2017 New Revision: 312267 URL: http://llvm.org/viewvc/llvm-project?rev=312267&view=rev Log: [TypeSystem] Reduce code duplication merging two almost identical functions. Modified: lldb/trunk/source/Symbol/TypeSystem.cpp Modified: lldb/trunk/source/Symb

[Lldb-commits] [PATCH] D37295: [lldb] Adjust UpdateExternalModuleListIfNeeded method for the case of *.dwo

alexshap added a comment. @clayborg, many thanks for the review, i've added above a comment with more details about the issue (to the best my knowledge). Repository: rL LLVM https://reviews.llvm.org/D37295 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D37295: [lldb] Adjust UpdateExternalModuleListIfNeeded method for the case of *.dwo

clayborg added a comment. Thanks for the info. Does this seem like it is a compiler bug? Seems like there should be a DW_AT_comp_dir if the DW_AT_GNU_dwo_name is relative? Is it written in the DWO spec that if the DW_AT_comp_dir is empty then it is referring to itself? I would rather not hack L

[Lldb-commits] [lldb] r312270 - lldb-mi: -var-update can hang when traversing complex types with pointers

Author: ted Date: Thu Aug 31 12:22:33 2017 New Revision: 312270 URL: http://llvm.org/viewvc/llvm-project?rev=312270&view=rev Log: lldb-mi: -var-update can hang when traversing complex types with pointers Summary: -var-update calls CMICmdCmdVarUpdate::ExamineSBValueForChange to check if a varObj

[Lldb-commits] [PATCH] D37295: [lldb] Adjust UpdateExternalModuleListIfNeeded method for the case of *.dwo

alexshap added a comment. @clayborg - yeah, many thanks for the comments > Does this seem like it is a compiler bug yeah, i think it might be the case, although right now i can't say for sure and i need to consult with the DWO spec > If this is a long released compiler generating this, then we