Re: [Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

labath added a reviewer: zturner. labath added a comment. cmake 2.8 is still widely used (Ubuntu 14.04 LTS for one, but there are people around using even longer lived versions of RedHat). I don't think we should bump the version over a tiny detail like this. I'm pretty sure there is a way to r

Re: [Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

zturner added a subscriber: zturner. zturner added a comment. Agree, the build should work with 2.8.12, but feel free to take advantage of newer cmake features if they're present Repository: rL LLVM http://reviews.llvm.org/D19685 ___ lldb-commits

Re: [Lldb-commits] [PATCH] D19690: Split out console and file writing cases in TestCommandScriptImmediateOutput

fjricci added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py:29 @@ -30,1 +28,3 @@ +"""Test that LLDB correctly allows scripted commands to set immediate output to the console

Re: [Lldb-commits] [lldb] r267861 - Revert "Fixed a bug where const this would cause parser errors about $__lldb_expr."

Pavel, thank you for reverting this. I have no idea how I was able to run the testsuite with this code still in there – I’ll Sean > On Apr 28, 2016, at 1:16 AM, Pavel Labath via lldb-commits > wrote: > > Author: labath > Date: Thu Apr 28 03:16:19 2016 > New Revision: 267861 > > URL: http:

Re: [Lldb-commits] [PATCH] D19690: Split out console and file writing cases in TestCommandScriptImmediateOutput

granata.enrico accepted this revision. This revision is now accepted and ready to land. Comment at: packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py:29 @@ -30,1 +28,3 @@ +"""Test that LLDB correctly allows

Re: [Lldb-commits] [PATCH] D19690: Split out console and file writing cases in TestCommandScriptImmediateOutput

fjricci updated this revision to Diff 55619. fjricci added a comment. Update timeout to 10 seconds for console case http://reviews.llvm.org/D19690 Files: packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py Index: packages/Pytho

Re: [Lldb-commits] [lldb] r267861 - Revert "Fixed a bug where const this would cause parser errors about $__lldb_expr."

I think I’ve figured it out. The error was in the APInt code (which shouldn’t have been committed). It required a corresponding header change which I hadn’t committed (the change I wanted to commit had no corresponding header changes) but which of course were present locally. Sean > On Apr 29

Re: [Lldb-commits] [PATCH] D18017: Eliminate the TestStarted-XXX and TestFinished-XXX files from the test traces

tfiala added a comment. Can we close this now? http://reviews.llvm.org/D18017 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19690: Split out console and file writing cases in TestCommandScriptImmediateOutput

granata.enrico added a comment. LGTM http://reviews.llvm.org/D19690 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19680: XFail TestBitfields.py Python API tests.

tfiala added a comment. Sorry I missed, looked good! (We are failing this on OS X right now as well since it also started failing there). Repository: rL LLVM http://reviews.llvm.org/D19680 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

Re: [Lldb-commits] [PATCH] D18017: Eliminate the TestStarted-XXX and TestFinished-XXX files from the test traces

amccarth closed this revision. amccarth added a comment. This was submitted last month. r263122 http://reviews.llvm.org/D18017 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. I will the unix / cmake experts make the decision here. Repository: rL LLVM http://reviews.llvm.org/D19685 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [lldb] r268083 - [fix] Fixed a bug where const this would cause parser errors about $__lldb_expr.

Author: spyffe Date: Fri Apr 29 13:09:03 2016 New Revision: 268083 URL: http://llvm.org/viewvc/llvm-project?rev=268083&view=rev Log: [fix] Fixed a bug where const this would cause parser errors about $__lldb_expr. In templated const functions, trying to run an expression would produce the error

[Lldb-commits] Buildbot numbers for the week of 4/10/2016 - 4/16/2016

Hello everyone, Below are some buildbot numbers for the week of 4/10/2016 - 4/16/2016. Thanks Galina "Status change ratio" by active builder (percent of builds that changed the builder status from greed to red or from red to green): buildername

[Lldb-commits] Buildbot numbers for the last week of 4/17/2016 - 4/23/2016

Hello everyone, Below are some buildbot numbers for the last week of 4/17/2016 - 4/23/2016. Thanks Galina "Status change ratio" by active builder (percent of builds that changed the builder status from greed to red or from red to green): buildername

[Lldb-commits] [lldb] r268098 - Make sure LLDB can deal with forward declarations to enums without crashing or asserting.

Author: gclayton Date: Fri Apr 29 15:48:39 2016 New Revision: 268098 URL: http://llvm.org/viewvc/llvm-project?rev=268098&view=rev Log: Make sure LLDB can deal with forward declarations to enums without crashing or asserting. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/enum

[Lldb-commits] [lldb] r268101 - Fix TestGetVariables.py so it works correctly. We had duplicate static values showing up as we would find static variables in the Block and also in the compile unit. We

Author: gclayton Date: Fri Apr 29 16:00:38 2016 New Revision: 268101 URL: http://llvm.org/viewvc/llvm-project?rev=268101&view=rev Log: Fix TestGetVariables.py so it works correctly. We had duplicate static values showing up as we would find static variables in the Block and also in the compile u

[Lldb-commits] [lldb] r268110 - Watch out for compilers that generate bad bitfield info. If the bit size of a bitfield member doesn't lie within the bit bounds of the type itself, just leave it out so

Author: gclayton Date: Fri Apr 29 16:26:46 2016 New Revision: 268110 URL: http://llvm.org/viewvc/llvm-project?rev=268110&view=rev Log: Watch out for compilers that generate bad bitfield info. If the bit size of a bitfield member doesn't lie within the bit bounds of the type itself, just leave it

Re: [Lldb-commits] [lldb] r268110 - Watch out for compilers that generate bad bitfield info. If the bit size of a bitfield member doesn't lie within the bit bounds of the type itself, just leave it ou

If clang is generating bad debug info, do you think you should file a bug against clang for that? On Fri, Apr 29, 2016 at 2:32 PM Greg Clayton via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: gclayton > Date: Fri Apr 29 16:26:46 2016 > New Revision: 268110 > > URL: http://llvm.org

Re: [Lldb-commits] [lldb] r268110 - Watch out for compilers that generate bad bitfield info. If the bit size of a bitfield member doesn't lie within the bit bounds of the type itself, just leave it ou

Of course we filed a bug about this, and I'm pretty sure Adrian is done or close to done with the fix. Searching for a useful interpretation to your question all I can come up with is: "Why are you bothering to work around this rather than fixing clang." That is actually worth answering, since

Re: [Lldb-commits] [lldb] r268110 - Watch out for compilers that generate bad bitfield info. If the bit size of a bitfield member doesn't lie within the bit bounds of the type itself, just leave it ou

Just to be clear, I definitely think it should be fixed on the LLDB side, because even if it were fixed in clang, you still have to deal with old debug info. I just want to make sure that it's also fixed in clang, which it sounds like you said you did file a bug against. So I wasn't really saying

Re: [Lldb-commits] [lldb] r268098 - Make sure LLDB can deal with forward declarations to enums without crashing or asserting.

+self.expect('frame variable f.op', DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ['ops *', 'f.op', '*0x*']) +self.expect('frame variable *f.op', DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ['ops', '*f.op', '']) +self.expect('expr f.op', DATA_TYPES_DISPLAYED_CORREC

[Lldb-commits] [PATCH] D19751: Fix TestEnumTypes.py for 32 bit platforms.

chaoren created this revision. chaoren added a reviewer: clayborg. chaoren added a subscriber: lldb-commits. http://reviews.llvm.org/D19751 Files: packages/Python/lldbsuite/test/lang/c/enum_types/TestEnumTypes.py Index: packages/Python/lldbsuite/test/lang/c/enum_types/TestEnumTypes.py

Re: [Lldb-commits] [PATCH] D19751: Fix TestEnumTypes.py for 32 bit platforms.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268135: Fix TestEnumTypes.py for 32 bit platforms. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D19751?vs=55685&id=55686#toc Repository: rL LLVM http://reviews.llvm.org/D1

[Lldb-commits] [lldb] r268135 - Fix TestEnumTypes.py for 32 bit platforms.

Author: chaoren Date: Fri Apr 29 18:34:44 2016 New Revision: 268135 URL: http://llvm.org/viewvc/llvm-project?rev=268135&view=rev Log: Fix TestEnumTypes.py for 32 bit platforms. Reviewers: clayborg Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D19751 Modified: lld