labath added a reviewer: zturner.
labath added a comment.

cmake 2.8 is still widely used (Ubuntu 14.04 LTS for one, but there are people 
around using even longer lived versions of RedHat). I don't think we should 
bump the version over a tiny detail like this. I'm pretty sure there is a way 
to rewrite the target rules to be compatible with both cmake 2.8 and 3+. Adding 
zachary for more insight.

A couple of other random thoughts:

- LLVM specifies the minimum version as 2.8.12.2. I think it's safe to go up to 
that point. Would that make any difference in this case?
- For the NetBSD target, I think you are free to choose whichever minimal 
version of cmake you like (although I would suggest to not go too far). 
However, you still need to make sure the build works with cmake 2.8 for others. 
Is it possible to fix your libexecinfo problem by conditionally changing the 
minimum version, or setting setting some policy?


Repository:
  rL LLVM

http://reviews.llvm.org/D19685



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to