Author: bhushan.attarde
Date: Wed Jan 27 04:16:30 2016
New Revision: 258919
URL: http://llvm.org/viewvc/llvm-project?rev=258919&view=rev
Log:
[LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS
SUMMARY:
Get the load address for the address given by symbol and function.
labath added a comment.
I like it. I noticed two small issues when running it though:
- TestFdLeak calls `@expectedFailure`, the expectation fn needs to be updated
to return a tuple
- TestInferiorAssert calls `matchAndroid`, which now returns a tuple. condition
needs updating.
LGTM after that.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258921: Fix linking with LLVM_LINK_LLVM_DYLIB=ON (authored
by labath).
Changed prior to commit:
http://reviews.llvm.org/D16293?vs=45667&id=46116#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1629
Author: labath
Date: Wed Jan 27 05:02:02 2016
New Revision: 258921
URL: http://llvm.org/viewvc/llvm-project?rev=258921&view=rev
Log:
Fix linking with LLVM_LINK_LLVM_DYLIB=ON
Linking with LLVM shared libraries currently produces linker errors. This
works around the issue
(pr24953) by disabling l
Author: omjavaid
Date: Wed Jan 27 07:57:33 2016
New Revision: 258930
URL: http://llvm.org/viewvc/llvm-project?rev=258930&view=rev
Log:
Decorarte TestInferiorAssert xfails on AArch64 Linux
This patch decorates some of TestInferiorAssert test cases with
expectedFailureLinux on AArch64.
Modified:
omjavaid created this revision.
omjavaid added reviewers: tberghammer, clayborg.
omjavaid added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
This patch adds logic to detect if underlying binary is using arm hard float
abi and use that information while handling return
evgeny777 added a comment.
Greg, Enrico,
Can someone tell if it is possible to modify Python interface this way. Without
this modification user breakpoints will be hit when someone evaluates
expression and use Python interface. The lldb frontend ignores breakpoints,
lldb-mi does not, becauses
evgeny777 updated this revision to Diff 46129.
http://reviews.llvm.org/D15778
Files:
source/API/SBFrame.cpp
Index: source/API/SBFrame.cpp
===
--- source/API/SBFrame.cpp
+++ source/API/SBFrame.cpp
@@ -1389,6 +1389,7 @@
lld
Hi,
could we get this patch applied to the 3.8 branch?
thanks,
pl
On 27 January 2016 at 11:02, Pavel Labath via lldb-commits
wrote:
> Author: labath
> Date: Wed Jan 27 05:02:02 2016
> New Revision: 258921
>
> URL: http://llvm.org/viewvc/llvm-project?rev=258921&view=rev
> Log:
> Fix linking wit
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good with a few nits inline
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:418
@@ +417,3 @@
+bool
+ABISysV_arm::IsArmHardFloat (Thread *thread) const
Hi Omair,
Can you send me some logs about the failure you see for this test both on
arm and aarch64 Linux? The test is passing reliably on android both for arm
and aarch64 so I would like to understand what is the difference.
Thanks,
Tamas
On Wed, Jan 27, 2016 at 2:01 PM Omair Javaid via lldb-co
granata.enrico added a comment.
It looks like this code is default constructing a SBExpressionOptions(), which
at the end of the day is a fancy wrapper for EvaluateExpressionOptions
This last object gets default constructed with
m_ignore_breakpoints (false),
I wonder whether that is a useful
On Tue, Jan 26, 2016 at 5:43 PM, Zachary Turner wrote:
> zturner updated this revision to Diff 46086.
> zturner added a comment.
>
> Add back the check for `six.callable`. Also added a detailed comment
> explaining what this atrocity actually does.
>
Yeah - I was thinking that actually caught s
Yea so basically what it does is allow you to use the same decorator with
arguments or without arguments. Like this:
@expectedFailureWindows # Python actually calls
expectedFailureWindows(func)
@expectedFailureWindows(debug_info='dwarf') # Python calls
expectedFailureWindows(debug_info='dwarf')
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D16615#337359, @zturner wrote:
> If the goal is to delete all the highly specialized decorators (after all,
> expectedFailureWindows is just expectedFailureAll(oslis
zturner added a subscriber: zturner.
zturner added a comment.
Yea so basically what it does is allow you to use the same decorator with
arguments or without arguments. Like this:
@expectedFailureWindows # Python actually calls
expectedFailureWindows(func)
@expectedFailureWindows(debug_info='dw
Author: amccarth
Date: Wed Jan 27 11:03:25 2016
New Revision: 258943
URL: http://llvm.org/viewvc/llvm-project?rev=258943&view=rev
Log:
XFail TestCPPAuto on Windows until we can find the root problem.
llvm.org/pr26339
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/auto/TestCPPAu
> On Jan 27, 2016, at 8:25 AM, Enrico Granata via lldb-commits
> wrote:
>
> granata.enrico added a comment.
>
> It looks like this code is default constructing a SBExpressionOptions(),
> which at the end of the day is a fancy wrapper for EvaluateExpressionOptions
>
> This last object gets de
> On Jan 27, 2016, at 9:20 AM, Jim Ingham via lldb-commits
> wrote:
>
>
>> On Jan 27, 2016, at 8:25 AM, Enrico Granata via lldb-commits
>> wrote:
>>
>> granata.enrico added a comment.
>>
>> It looks like this code is default constructing a SBExpressionOptions(),
>> which at the end of the
Zach is the lldb cmake owner. Zach, does this seem OK for 3.8?
On Wed, Jan 27, 2016 at 7:13 AM, Pavel Labath wrote:
> Hi,
>
> could we get this patch applied to the 3.8 branch?
>
> thanks,
> pl
>
>
> On 27 January 2016 at 11:02, Pavel Labath via lldb-commits
> wrote:
>> Author: labath
>> Date: W
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Change over to use a "Thread &" as argument to "bool
ABISysV_arm::IsArmHardFloat(Thread *)" and this is good to go.
http://reviews.llvm.org/D16627
___
clayborg added a comment.
And fix all of the tberghammer's comments as well.
http://reviews.llvm.org/D16627
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Yea I think this is fine.
On Wed, Jan 27, 2016 at 9:29 AM Hans Wennborg wrote:
> Zach is the lldb cmake owner. Zach, does this seem OK for 3.8?
>
> On Wed, Jan 27, 2016 at 7:13 AM, Pavel Labath wrote:
> > Hi,
> >
> > could we get this patch applied to the 3.8 branch?
> >
> > thanks,
> > pl
> >
Just a heads up, `isinstance(foo, basestring)` doesn't work in Python 3.
You need to use `isinstance(foo, six.string_types)`. I'm checking in a fix
for this, but just wanted to let you know so you can keep this in the back
of your head for future.
On Wed, Jan 27, 2016 at 2:20 AM Bhushan D. Attard
Also please add `from __future__ import print_function` to the top of every
new test file you create. Sorry this didn't get caught during review, no
worries.
On Wed, Jan 27, 2016 at 10:42 AM Zachary Turner wrote:
> Just a heads up, `isinstance(foo, basestring)` doesn't work in Python 3.
> You n
Author: zturner
Date: Wed Jan 27 12:49:35 2016
New Revision: 258967
URL: http://llvm.org/viewvc/llvm-project?rev=258967&view=rev
Log:
Fix some python 3 incompatibilities that went in overnight.
* basestring is not a thing anymore. Must use `six.string_types`.
* Must use from __future__ import pr
Author: zturner
Date: Wed Jan 27 12:49:31 2016
New Revision: 258966
URL: http://llvm.org/viewvc/llvm-project?rev=258966&view=rev
Log:
Refactor some of the xfail / skip decorators to share logic.
Previously the logic of skipIf and expectedFailure were 99%
the same, but they took different sets of
Author: zturner
Date: Wed Jan 27 12:49:25 2016
New Revision: 258965
URL: http://llvm.org/viewvc/llvm-project?rev=258965&view=rev
Log:
Don't automtically try to import pexpect in lldbpexpect.
Since pexpect doesn't exist on Windows, tests which are xfail'ed
are not being run at all because they are
Merged in r258964, thanks. (I accidentally committed some local
changes too; reverted those in r258968.)
On Wed, Jan 27, 2016 at 10:06 AM, Zachary Turner wrote:
> Yea I think this is fine.
>
> On Wed, Jan 27, 2016 at 9:29 AM Hans Wennborg wrote:
>>
>> Zach is the lldb cmake owner. Zach, does thi
Author: zturner
Date: Wed Jan 27 13:00:51 2016
New Revision: 258969
URL: http://llvm.org/viewvc/llvm-project?rev=258969&view=rev
Log:
Resubmit r258759 with proper unicode handling.
Instead of opening the file in unicode mode, we need only encode
data which potentially has non-ASCII characters as
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Hi Zach,
I think this CL (or one of your other recent related CL) caused some
regression on the Linux builder. You can see the failed build here:
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/10736
Can you take a look (if you need help or you think it isn't caused by one
Gah, I really thought this woudl work. I will revert again.
On Wed, Jan 27, 2016 at 11:48 AM Tamas Berghammer
wrote:
> Hi Zach,
>
> I think this CL (or one of your other recent related CL) caused some
> regression on the Linux builder. You can see the failed build here:
> http://lab.llvm.org:80
Author: zturner
Date: Wed Jan 27 13:47:28 2016
New Revision: 258978
URL: http://llvm.org/viewvc/llvm-project?rev=258978&view=rev
Log:
Revert "Resubmit r258759 with proper unicode handling."
This reverts commit 2c79d60214e146b13b233392a859b4f79340e90e.
Modified:
lldb/trunk/packages/Python/ll
Author: gclayton
Date: Wed Jan 27 18:16:11 2016
New Revision: 259003
URL: http://llvm.org/viewvc/llvm-project?rev=259003&view=rev
Log:
A while back in revison 244716 we added support for getting the host OS version
info from debugserver. We added keys to "qHostInfo" that were "osmajor",
"osminor
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: clayborg, labath, zturner.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Herald added subscribers: dsanders, srhines, danalbert, tberghammer, emaste.
autoconf su
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Woot. Kill it dead.
Repository:
rL LLVM
http://reviews.llvm.org/D16662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lis
krytarowski added a comment.
1. I was trying to comment out `DBG` registers (as unsupported by NetBSD) from
`RegisterInfos_x86_64.h` with the following patch:
diff --git
a/lldb-git/patches/patch-lldb_source_Plugins_Process_Utility_RegisterInfos__x86__64.h
b/lldb-git/patches/patch-lldb_sourc
Author: tfiala
Date: Thu Jan 28 01:36:44 2016
New Revision: 259027
URL: http://llvm.org/viewvc/llvm-project?rev=259027&view=rev
Log:
modify Xcode build to use cmake/ninja for internal llvm/clang
This change restores the Xcode build to working after Makefile support
was stripped from LLVM and clan
39 matches
Mail list logo
