Re: [Lldb-commits] [lldb] r258485 - Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation

Hi Hans, Could you please add this to the release branch? Thanks, Bhushan -Original Message- From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf Of Bhushan D. Attarde via lldb-commits Sent: 22 January 2016 10:32 To: lldb-commits@lists.llvm.org Subject: [Lldb-commi

[Lldb-commits] [lldb] r258684 - [LLDB][MIPS] Fix TestExprsChar.py

Author: slthakur Date: Mon Jan 25 06:27:46 2016 New Revision: 258684 URL: http://llvm.org/viewvc/llvm-project?rev=258684&view=rev Log: [LLDB][MIPS] Fix TestExprsChar.py Patch by Nitesh Jain. Summary: When incorrect type used for 'char' then (at least) one of the expression evaluates to incorrec

Re: [Lldb-commits] [PATCH] D16132: [LLDB][MIPS] Fix TestExprsChar.py

sagar closed this revision. sagar added a comment. Committed in revision 258684 Repository: rL LLVM http://reviews.llvm.org/D16132 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] r258685 - [LLDB][MIPS] Fix TestPrintStackTraces.py

Author: slthakur Date: Mon Jan 25 06:33:03 2016 New Revision: 258685 URL: http://llvm.org/viewvc/llvm-project?rev=258685&view=rev Log: [LLDB][MIPS] Fix TestPrintStackTraces.py Patch by Nitesh Jain. Summary: The thread_start function in libc doesn't contain any epilogue and prologue instructions

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

ldrumm added a subscriber: ldrumm. ldrumm added a comment. This differential seems to have introduced a regression on x86_64 Android, where `std::bad_alloc` is thrown during process attach. I've reverted this locally, and filed a bug , but as this is

Re: [Lldb-commits] [PATCH] D16136: [LLDB][MIPS] Fix TestPrintStackTraces.py

sagar closed this revision. sagar added a comment. Committed in revision 258685. Repository: rL LLVM http://reviews.llvm.org/D16136 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

ravitheja added a comment. Hello, Ok I will take a look. http://reviews.llvm.org/D16107 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

clayborg added a comment. This kind of stuff: struct UserArea { GPR gpr; FPR fpr; DBG dbg; }; Was done on MacOSX systems because we have thread_get_state() and thread_set_state() that take a flavor (enumeration) that specifies which registers we should read

[Lldb-commits] [lldb] r258704 - Fix TestSourceManager.py on Windows.

Author: amccarth Date: Mon Jan 25 13:13:35 2016 New Revision: 258704 URL: http://llvm.org/viewvc/llvm-project?rev=258704&view=rev Log: Fix TestSourceManager.py on Windows. Python 3.5 is picky about writing strings to binary files, so we now open the file in text mode, and we explicitly set the ne

Re: [Lldb-commits] [lldb] r258485 - Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation

SGTM if Greg approves. On Mon, Jan 25, 2016 at 2:03 AM, Bhushan Attarde wrote: > Could you please add this to the release branch? > > Thanks, > Bhushan > > > -Original Message- > From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf Of > Bhushan D. Attarde via lldb-co

Re: [Lldb-commits] [PATCH] D16397: [LLDB] Consider only valid symbols while resolving by address

amccarth added a subscriber: amccarth. amccarth added a comment. This patch broke approximately 10 tests on Windows, mostly related to thread step-over, thread step-out, etc. We probably need to fix something in PECOFF::GetSymTab that's causing all the symbols to be rejected. I'll look into

Re: [Lldb-commits] [PATCH] D16397: [LLDB] Consider only valid symbols while resolving by address

Also various other formatting problems. Please run clang-format in the future. Steps to running clang-format 1. Compile it with "ninja clang-format" 2. Add your bin directory to PATH 3. Stage your changes with git add as you normally do 4. Run "git clang-format" On Mon, Jan 25, 2016 at 11:51 AM

Re: [Lldb-commits] [PATCH] D16397: [LLDB] Consider only valid symbols while resolving by address

zturner added a subscriber: zturner. zturner added a comment. Also various other formatting problems. Please run clang-format in the future. Steps to running clang-format 1. Compile it with "ninja clang-format" 2. Add your bin directory to PATH 3. Stage your changes with git add as you normally

Re: [Lldb-commits] [PATCH] D16477: Make all x86 target builds on MSVC use the amd64_x86 toolchain

gkistanova accepted this revision. gkistanova added a comment. This revision is now accepted and ready to land. LGTM Thanks Galina http://reviews.llvm.org/D16477 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] r258741 - Fix swig typemap for SBEvent.

Author: zturner Date: Mon Jan 25 17:21:09 2016 New Revision: 258741 URL: http://llvm.org/viewvc/llvm-project?rev=258741&view=rev Log: Fix swig typemap for SBEvent. This needs to be able to handle bytes, strings, and bytearray objects. In Python 2 this was easy because bytes and strings are the sa

[Lldb-commits] [lldb] r258742 - Fix more occurrences of string/bytes/bytearray in swig typemaps.

Author: zturner Date: Mon Jan 25 17:21:13 2016 New Revision: 258742 URL: http://llvm.org/viewvc/llvm-project?rev=258742&view=rev Log: Fix more occurrences of string/bytes/bytearray in swig typemaps. Modified: lldb/trunk/scripts/Python/python-typemaps.swig Modified: lldb/trunk/scripts/Python/

[Lldb-commits] [lldb] r258743 - Fix some issues with bytes and strings in Python 3.

Author: zturner Date: Mon Jan 25 17:21:18 2016 New Revision: 258743 URL: http://llvm.org/viewvc/llvm-project?rev=258743&view=rev Log: Fix some issues with bytes and strings in Python 3. SBProcess::ReadMemory and other related functions such as WriteMemory are returning Python string() objects. T

[Lldb-commits] [lldb] r258751 - Fix TestSyntheticCapping for Python 3.

Author: zturner Date: Mon Jan 25 18:07:09 2016 New Revision: 258751 URL: http://llvm.org/viewvc/llvm-project?rev=258751&view=rev Log: Fix TestSyntheticCapping for Python 3. In Python 3, whitespace inconsistences are errors. This synthetic provider had mixed tabs and spaces, as well as inconsiste

[Lldb-commits] [PATCH] D16563: Set symbol types for function symbols loaded from PE/COFF

amccarth created this revision. amccarth added reviewers: zturner, clayborg. amccarth added a subscriber: lldb-commits. This fixes the regression of several tests on Windows after rL258621. The root problem is that ObjectFilePECOFF was not setting type information for the symbols, and the new CL

Re: [Lldb-commits] [PATCH] D16563: Set symbol types for function symbols loaded from PE/COFF

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine. http://reviews.llvm.org/D16563 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D16563: Set symbol types for function symbols loaded from PE/COFF

zturner added inline comments. Comment at: include/lldb/Core/RangeMap.h:1230 @@ -1229,3 +1229,3 @@ typename Collection::const_iterator pos; -for(pos = m_entries.begin(); pos != m_entries.end(); pos++) +for (pos = m_entries.begin();

Re: [Lldb-commits] [PATCH] D16563: Set symbol types for function symbols loaded from PE/COFF

amccarth marked 2 inline comments as done. Comment at: include/lldb/Core/RangeMap.h:1230 @@ -1229,3 +1229,3 @@ typename Collection::const_iterator pos; -for(pos = m_entries.begin(); pos != m_entries.end(); pos++) +for (pos = m_entri

Re: [Lldb-commits] [PATCH] D16563: Set symbol types for function symbols loaded from PE/COFF

zturner added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:183 @@ +182,3 @@ +} +return lldb::eSymbolTypeInvalid; +} amccarth wrote: > zturner wrote: > > Instead of returning `eSymbolTypeInvalid` here, how about > > `e

Re: [Lldb-commits] [PATCH] D16563: Set symbol types for function symbols loaded from PE/COFF

amccarth updated this revision to Diff 45933. amccarth marked an inline comment as done. amccarth added a comment. Mostly clang-format. http://reviews.llvm.org/D16563 Files: include/lldb/Core/RangeMap.h include/lldb/Symbol/Symtab.h source/Core/Module.cpp source/Plugins/ObjectFile/PECOFF

Re: [Lldb-commits] [PATCH] D16563: Set symbol types for function symbols loaded from PE/COFF

amccarth added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:195 @@ -182,3 +194,3 @@ m_coff_header_opt (), m_sect_headers () { After discussion with a COFF expert, it seems wise to postpone trying to do anything mor

[Lldb-commits] [lldb] r258758 - Set symbol types for function symbols loaded from PE/COFF

Author: amccarth Date: Mon Jan 25 18:58:09 2016 New Revision: 258758 URL: http://llvm.org/viewvc/llvm-project?rev=258758&view=rev Log: Set symbol types for function symbols loaded from PE/COFF This fixes the regression of several tests on Windows after rL258621. The root problem is that ObjectFi

Re: [Lldb-commits] [PATCH] D16563: Set symbol types for function symbols loaded from PE/COFF

This revision was automatically updated to reflect the committed changes. Closed by commit rL258758: Set symbol types for function symbols loaded from PE/COFF (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D16563?vs=45933&id=45935#toc Repository: rL LLVM http://rev

[Lldb-commits] [lldb] r258759 - Write the session log file in UTF-8.

Author: zturner Date: Mon Jan 25 18:59:42 2016 New Revision: 258759 URL: http://llvm.org/viewvc/llvm-project?rev=258759&view=rev Log: Write the session log file in UTF-8. Previously we were writing in the default encoding, which depends on the operating system and is not guaranteed to be unicode

[Lldb-commits] [lldb] r258761 - Remove XFAIL Windows from a test that was fixed by r258758.

Author: zturner Date: Mon Jan 25 19:09:38 2016 New Revision: 258761 URL: http://llvm.org/viewvc/llvm-project?rev=258761&view=rev Log: Remove XFAIL Windows from a test that was fixed by r258758. Modified: lldb/trunk/packages/Python/lldbsuite/test/python_api/function_symbol/TestSymbolAPI.py M

[Lldb-commits] [lldb] r258763 - Fix the lldbinline tests so they make well-formed Makefiles.

Author: spyffe Date: Mon Jan 25 19:15:57 2016 New Revision: 258763 URL: http://llvm.org/viewvc/llvm-project?rev=258763&view=rev Log: Fix the lldbinline tests so they make well-formed Makefiles. lldbinline tests previously did not run correctly unless there was already a Makefile for them. This w

[Lldb-commits] [lldb] r258764 - Fix TestRerun.py on Windows.

Author: zturner Date: Mon Jan 25 19:19:50 2016 New Revision: 258764 URL: http://llvm.org/viewvc/llvm-project?rev=258764&view=rev Log: Fix TestRerun.py on Windows. This is another example of a test that was looking for the thread at index 0 instead of requesting the thread that was stopped at the

[Lldb-commits] LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 9 PM Pacific time today. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r258791 - Reverting r258759 as it is breaking the OSX build

Author: enrico Date: Mon Jan 25 22:53:10 2016 New Revision: 258791 URL: http://llvm.org/viewvc/llvm-project?rev=258791&view=rev Log: Reverting r258759 as it is breaking the OSX build Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/char1632_t/TestChar1632T.py lldb/trunk/pack