SGTM if Greg approves.
On Mon, Jan 25, 2016 at 2:03 AM, Bhushan Attarde <bhushan.atta...@imgtec.com> wrote: > Could you please add this to the release branch? > > Thanks, > Bhushan > > > -----Original Message----- > From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf Of > Bhushan D. Attarde via lldb-commits > Sent: 22 January 2016 10:32 > To: lldb-commits@lists.llvm.org > Subject: [Lldb-commits] [lldb] r258485 - Use "_$" prefix instead of "$" for > dynamic checker function inserted by LLDB during expression evaluation > > Author: bhushan.attarde > Date: Thu Jan 21 23:02:02 2016 > New Revision: 258485 > > URL: http://llvm.org/viewvc/llvm-project?rev=258485&view=rev > Log: > Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB > during expression evaluation > > SUMMARY: > The symbol "$" has a special meaning for MIPS i.e it is marker for > temporary symbols for MIPS. > So this patch uses additional _ prefix for "$__lldb_valid_pointer_check" > so that it wont be marked as temporary symbol in case of MIPS. > > Reviewers: clayborg, spyffe > Subscribers: dean, emaste, mohit.bhakkad, sagar, jaydeep, lldb-commits > Differential http://reviews.llvm.org/D14111 > > Modified: > lldb/trunk/source/Expression/IRDynamicChecks.cpp > > Modified: lldb/trunk/source/Expression/IRDynamicChecks.cpp > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/IRDynamicChecks.cpp?rev=258485&r1=258484&r2=258485&view=diff > ============================================================================== > --- lldb/trunk/source/Expression/IRDynamicChecks.cpp (original) > +++ lldb/trunk/source/Expression/IRDynamicChecks.cpp Thu Jan 21 23:02:02 > +++ 2016 > @@ -35,12 +35,12 @@ using namespace lldb_private; > > static char ID; > > -#define VALID_POINTER_CHECK_NAME "$__lldb_valid_pointer_check" > +#define VALID_POINTER_CHECK_NAME "_$__lldb_valid_pointer_check" > #define VALID_OBJC_OBJECT_CHECK_NAME "$__lldb_objc_object_check" > > static const char g_valid_pointer_check_text[] = "extern \"C\" void\n" > -"$__lldb_valid_pointer_check (unsigned char *$__lldb_arg_ptr)\n" > +"_$__lldb_valid_pointer_check (unsigned char *$__lldb_arg_ptr)\n" > "{\n" > " unsigned char $__lldb_local_val = *$__lldb_arg_ptr;\n" > "}"; > > > _______________________________________________ > lldb-commits mailing list > lldb-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
