Author: tfiala
Date: Wed Oct 28 10:24:19 2015
New Revision: 251522
URL: http://llvm.org/viewvc/llvm-project?rev=251522&view=rev
Log:
Fix build break on OS X from cleanup check-in.
I'll track down why our CI is not sending out emails on build breaks.
Modified:
lldb/trunk/source/Core/IOHandler
ovyalov added a comment.
Hi,
looks like TestHelloWorld and TestInferiorAssert began to fail after this
change -
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/7880
Could you mark these tests as XFAILs for now?
http://reviews.llvm.org/D14118
Hello everyone,
I continue works to reduce buildbot noise.
E-mail notification has been changed in the buildmaster. Now it should not
count interrupted builds to figure out if notification should be send.
So, some people might want to reconsider the notification rules for their
personal notifiers.
zturner added inline comments.
Comment at: source/Plugins/Process/Windows/Common/ProcessWindowsForward.h:20
@@ +19,1 @@
+#endif
\ No newline at end of file
Put a newline here
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump
Author: spyffe
Date: Wed Oct 28 12:14:27 2015
New Revision: 251527
URL: http://llvm.org/viewvc/llvm-project?rev=251527&view=rev
Log:
Don't codesign lldbserver if debugserver codesigning is disabled, because it
probably won't work.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified:
amccarth added inline comments.
Comment at: source/Plugins/Process/Windows/Common/ProcessWindowsForward.h:20
@@ +19,1 @@
+#endif
\ No newline at end of file
zturner wrote:
> Put a newline here
Actually, this file is obsolete, so I'm deleting it instead. It was i
Author: sas
Date: Wed Oct 28 12:34:45 2015
New Revision: 251530
URL: http://llvm.org/viewvc/llvm-project?rev=251530&view=rev
Log:
Avoid using `..` in paths for include dirs.
Summary:
This breaks when using a symlink from llvm/tools/lldb to the lldb source
tree, instead of cloning directly as a ch
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251530: Avoid using `..` in paths for include dirs.
(authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D14089?vs=38454&id=38670#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1408
Author: ravitheja
Date: Wed Oct 28 04:47:29 2015
New Revision: 251505
URL: http://llvm.org/viewvc/llvm-project?rev=251505&view=rev
Log:
Changes for Bug 17384
Summary:
Virtual dynamic shared objects, or vdso files were
not loaded for Linux OS.In Bug 17384 the call
stack could not be unwinded fro
Hi,
I actually checked these two testcases, they are passing at my end,
could u send me the logs and the lldb executables , so that I can check at my
end ? I think I can try to resolve it, in other case I will mark them as XFAILS.
-Original Message-
From: Oleksiy Vyalov [mailto:
ravitheja updated this revision to Diff 38637.
ravitheja added a comment.
Updates for previous comments.
http://reviews.llvm.org/D14118
Files:
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h
test/functiona
ovyalov added a comment.
You can get test logs from this link -
https://pantheon.corp.google.com/storage/browser/lldb_test_traces/lldb-x86_64-ubuntu-14.04-cmake/?project=android-devtools-lldb-build
I suspect that there are a few problems here:
1. TestHelloWorld - there is a race within the test
Author: gclayton
Date: Wed Oct 28 13:04:38 2015
New Revision: 251537
URL: http://llvm.org/viewvc/llvm-project?rev=251537&view=rev
Log:
Make core files not crash when you load a core file into LLDB with just "lldb
-c core".
To do this I added a few new ways to determine the OS from PT_NOTE notes
Author: ovyalov
Date: Wed Oct 28 13:36:11 2015
New Revision: 251542
URL: http://llvm.org/viewvc/llvm-project?rev=251542&view=rev
Log:
Mark TestHelloWorld and TestInferiorAssert.py as XFAIL due llvm.org/pr25338.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/inferior-ass
ovyalov added a comment.
Greg, is it ok to submit the CL?
http://reviews.llvm.org/D14126
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: zturner
Date: Wed Oct 28 14:18:53 2015
New Revision: 251544
URL: http://llvm.org/viewvc/llvm-project?rev=251544&view=rev
Log:
Try to fix the linux buildbot.
It's complaining that it doesn't under the "import" command, so
I guess I need this hashbang at the beginning so that it knows
it's
Author: ovyalov
Date: Wed Oct 28 14:49:50 2015
New Revision: 251547
URL: http://llvm.org/viewvc/llvm-project?rev=251547&view=rev
Log:
Make lldb-gdbserver to take explicit socket scheme as command line argument.
http://reviews.llvm.org/D14126
Modified:
lldb/trunk/source/Plugins/Process/gdb-
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.h
/lldb/trunk/tools/lldb-server/Acceptor.cpp
/lldb/trun
Author: amccarth
Date: Wed Oct 28 14:59:18 2015
New Revision: 251549
URL: http://llvm.org/viewvc/llvm-project?rev=251549&view=rev
Log:
Add check for __main__ in dotest.py to ensure problems with multiprocessing on
some Windows machines.
Modified:
lldb/trunk/test/dotest.py
Modified: lldb/tru
Author: spyffe
Date: Wed Oct 28 15:07:46 2015
New Revision: 251550
URL: http://llvm.org/viewvc/llvm-project?rev=251550&view=rev
Log:
Removed an unecessary code-signing phase on lldb-tool.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
zturner created this revision.
zturner added a reviewer: tfiala.
zturner added a subscriber: lldb-commits.
This patch disables the ability to run
`packages/Python/lldbsuite/test/dotest.py` as a standalone script by explicitly
erroring out if it detects that to be the case. Then, it fixes up the
Author: gclayton
Date: Wed Oct 28 15:49:34 2015
New Revision: 251555
URL: http://llvm.org/viewvc/llvm-project?rev=251555&view=rev
Log:
Don't crash when opening a fuzzed mach-o file that has bad dyld trie data.
Modified:
lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
Modif
Author: eugenezelenko
Date: Wed Oct 28 15:53:04 2015
New Revision: 251556
URL: http://llvm.org/viewvc/llvm-project?rev=251556&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in some files in
include/lldb/Core; other minor fixes.
Modified:
lldb/trunk/include/lldb/Core/ModuleSpec.h
zturner created this revision.
zturner added a reviewer: amccarth.
zturner added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
If you have PTVS [https://github.com/Microsoft/PTVS] installed, you can open
this solution in Visual Studio and get an integrated
Author: enrico
Date: Wed Oct 28 17:08:09 2015
New Revision: 251559
URL: http://llvm.org/viewvc/llvm-project?rev=251559&view=rev
Log:
Skip this test is the test suite is running in a mode where it has no
WindowServer access
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/rdar-1
Author: eugenezelenko
Date: Wed Oct 28 17:11:25 2015
New Revision: 251561
URL: http://llvm.org/viewvc/llvm-project?rev=251561&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in remaining files in
include/lldb/Core; other minor fixes.
Modified:
lldb/trunk/include/lldb/Core/STLUtil
Author: ovyalov
Date: Wed Oct 28 17:21:02 2015
New Revision: 251563
URL: http://llvm.org/viewvc/llvm-project?rev=251563&view=rev
Log:
Remove unused SUN_LEN macro for Android.
Modified:
lldb/trunk/source/Host/posix/DomainSocket.cpp
Modified: lldb/trunk/source/Host/posix/DomainSocket.cpp
URL:
zturner created this revision.
zturner added a reviewer: tfiala.
zturner added a subscriber: lldb-commits.
The purpose of this file is to fill in the gaps where `six` is lacking support
for some operation that we need.
Initially this just provides a replacement for the `commands` module which is
Author: jingham
Date: Wed Oct 28 17:23:17 2015
New Revision: 251564
URL: http://llvm.org/viewvc/llvm-project?rev=251564&view=rev
Log:
Change Target::EvaluateExpression to take an ExecutionContextScope * rather
than a
StackFrame * (StackFrame is an ExecutionContextScope.) That allows you to call
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
Another case where sleep-and-retry avoids file access errors on Windows.
http://reviews.llvm.org/D14163
Files:
packages/Python/lldbsuite/test/lldbtest.py
Index: packages/Python/lldbs
zturner added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1823-1830
@@ -1822,3 +1822,10 @@
-os.rename(src, dst)
+try:
+os.rename(src, dst)
+except:
+
amccarth added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1823-1830
@@ -1822,3 +1822,10 @@
-os.rename(src, dst)
+try:
+os.rename(src, dst)
+except:
+
Author: jmolenda
Date: Wed Oct 28 18:23:44 2015
New Revision: 251578
URL: http://llvm.org/viewvc/llvm-project?rev=251578&view=rev
Log:
Initialize data_len to 0 in source/Plugins/Platform/Android/AdbClient.cpp
Modified:
lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
Modified: lldb/
Author: gclayton
Date: Wed Oct 28 18:26:59 2015
New Revision: 251579
URL: http://llvm.org/viewvc/llvm-project?rev=251579&view=rev
Log:
Make sure we don't over specify an architecture when we connect to KDP and use
the CPU type and subtype to fill out an architecture. We do this by letting the
ve
Author: jmolenda
Date: Wed Oct 28 18:31:03 2015
New Revision: 251580
URL: http://llvm.org/viewvc/llvm-project?rev=251580&view=rev
Log:
Revert r251578. I was in the middle of editing the commit message
and decided to not commit the change, but accidentally committed
it anyway.
This was based on a
Author: enrico
Date: Wed Oct 28 18:36:44 2015
New Revision: 251581
URL: http://llvm.org/viewvc/llvm-project?rev=251581&view=rev
Log:
Remove an unused local variable
Modified:
lldb/trunk/source/DataFormatters/TypeCategoryMap.cpp
Modified: lldb/trunk/source/DataFormatters/TypeCategoryMap.cpp
U
Author: jmolenda
Date: Wed Oct 28 18:49:55 2015
New Revision: 251583
URL: http://llvm.org/viewvc/llvm-project?rev=251583&view=rev
Log:
Fix potential null deref; after SymbolContextSpecifier::SymbolContextMatches
has tested that sc.function is null, it would try to deref sc.function.
It should be c
Author: jmolenda
Date: Wed Oct 28 19:08:03 2015
New Revision: 251584
URL: http://llvm.org/viewvc/llvm-project?rev=251584&view=rev
Log:
Static analyzer noticed that a null get_pending_items_caller could
be used. Guard against that.
Modified:
lldb/trunk/source/Plugins/SystemRuntime/MacOSX/App
Author: jmolenda
Date: Wed Oct 28 19:13:42 2015
New Revision: 251585
URL: http://llvm.org/viewvc/llvm-project?rev=251585&view=rev
Log:
Explicitly cast size_t var to (uint64_t) when printf format is PRIx64.
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/R
Author: jmolenda
Date: Wed Oct 28 19:21:14 2015
New Revision: 251586
URL: http://llvm.org/viewvc/llvm-project?rev=251586&view=rev
Log:
Xcode suggested enabling a "no common blocks" warning
(whatever that is) and wanted to clean up some duplicated
entries in the project files.
Modified:
lldb
Author: eugenezelenko
Date: Wed Oct 28 19:27:24 2015
New Revision: 251587
URL: http://llvm.org/viewvc/llvm-project?rev=251587&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in include/lldb/Expression and
Host; other minor fixes.
Modified:
lldb/trunk/include/lldb/Expression/Expre
chaoren created this revision.
chaoren added reviewers: sas, ovyalov.
chaoren added a subscriber: lldb-commits.
http://reviews.llvm.org/D14166
Files:
cmake/modules/LLDBConfig.cmake
Index: cmake/modules/LLDBConfig.cmake
===
--- cma
chaoren resigned from this revision.
chaoren removed a reviewer: chaoren.
chaoren added a comment.
Seems legit. But I've never built standalone, so I probably shouldn't be a
reviewer for this.
http://reviews.llvm.org/D13819
___
lldb-commits mailing
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D14166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
Author: chaoren
Date: Wed Oct 28 19:48:38 2015
New Revision: 251589
URL: http://llvm.org/viewvc/llvm-project?rev=251589&view=rev
Log:
Correctly include LLVM_EXTERNAL_CLANG_SOURCE_DIR.
Reviewers: sas, ovyalov
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D14166
Modifi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251589: Correctly include LLVM_EXTERNAL_CLANG_SOURCE_DIR.
(authored by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D14166?vs=38700&id=38702#toc
Repository:
rL LLVM
http://reviews.llvm
tfiala created this revision.
tfiala added reviewers: labath, zturner, jasonmolenda.
tfiala added a subscriber: lldb-commits.
Distributions that put lldb binaries in /usr/bin and whatnot are going to put
argdumper in the same place. argdumper is way too generic a name. Rename to
lldb-argdumper
Author: labath
Date: Wed Oct 28 20:18:45 2015
New Revision: 251590
URL: http://llvm.org/viewvc/llvm-project?rev=251590&view=rev
Log:
Leave TestAttachResume as flakey on linux
there must be (at least) one more race hidden there...
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functiona
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good.
argdumper should probably go to /usr/libexec, but then I guess we won't be able
to find it, so that's a different story...
http://reviews.llvm.org/D14169
_
tfiala added a comment.
In http://reviews.llvm.org/D14169#277545, @labath wrote:
> Looks good.
>
> argdumper should probably go to /usr/libexec, but then I guess we won't be
> able to find it, so that's a different story...
Exactly right. That will require more work.
http://reviews.llvm.org/
krytarowski added a comment.
I have successfully compiled this patch on FreeBSD.
$ uname -a
FreeBSD 10.1-RELEASE-p19 FreeBSD 10.1-RELEASE-p19 #0: Sat Aug 22 03:55:09 UTC
2015 r...@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64
Repository:
rL LLVM
http://reviews.
krytarowski added a comment.
I have successfully compiled this patch on FreeBSD.
$ uname -a
FreeBSD 10.1-RELEASE-p19 FreeBSD 10.1-RELEASE-p19 #0: Sat Aug 22 03:55:09 UTC
2015 r...@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64
Repository:
rL LLVM
http://reviews.
On 28 October 2015 at 18:04, Greg Clayton via lldb-commits
wrote:
> +// LLDB_NT_OWNER_CORE and LLDB_NT_OWNER_LINUX note contants
> +#define NT_PRSTATUS 1
> +#define NT_PRFPREG 2
> +#define NT_PRPSINFO 3
> +#define NT_TASKSTRUCT 4
> +#define NT_AUXV
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks good.
We were having trouble running the script from the top level earlier and were
directly calling the one that you're disabling. That'll be nice to get the top
level one working aga
tfiala added a comment.
> scripts/Python/finish-swig-Python-LLDB.sh
Hmm I think there is a python implementation of this script that I may have
missed. Checking on that now.
http://reviews.llvm.org/D14169
___
lldb-commits mailing list
lldb-commi
tfiala added a comment.
Just one question on the python 3 return code for non-exceptional exit.
Comment at: packages/Python/lldbsuite/support/seven.py:12
@@ +11,3 @@
+import subprocess
+return (0, subprocess.check_output(command, shell=True))
+exc
tfiala added a comment.
In http://reviews.llvm.org/D14169#277587, @tfiala wrote:
> > scripts/Python/finish-swig-Python-LLDB.sh
>
>
> Hmm I think there is a python implementation of this script that I may have
> missed. Checking on that now.
Yes there is. I need to adjust one other place. I'
tfiala updated this revision to Diff 38715.
tfiala added a comment.
Fixed up one missed spot, the python-based class completion script.
I think the original clean build and test run on Linux missed this because I
don't think we actually use it on Linux. It's primarily useful on OS X 10.11
and
tfiala added a comment.
I'm out the next couple days at the LLVM conference. I'm going to put this in.
We'll revert it out if it causes any trouble on Windows and fix it up.
http://reviews.llvm.org/D14169
___
lldb-commits mailing list
lldb-commit
Author: tfiala
Date: Thu Oct 29 00:07:12 2015
New Revision: 251616
URL: http://llvm.org/viewvc/llvm-project?rev=251616&view=rev
Log:
Rename argdumper to lldb-argdumper
http://reviews.llvm.org/D14169
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
lldb/trunk/scripts/Python/finish-swig
tfiala closed this revision.
tfiala added a comment.
Closed by commit:
$ svn commit
Sendinglldb.xcodeproj/project.pbxproj
Sendingscripts/Python/finish-swig-Python-LLDB.sh
Sendingscripts/Python/finishSwigPythonLLDB.py
Sendingsource/Host/macosx/Host.mm
Se
zturner added inline comments.
Comment at: packages/Python/lldbsuite/support/seven.py:12
@@ +11,3 @@
+import subprocess
+return (0, subprocess.check_output(command, shell=True))
+except subprocess.CalledProcessError as e:
tfiala wro
62 matches
Mail list logo
