zturner added inline comments.
================
Comment at: source/Plugins/Process/Windows/Common/ProcessWindowsForward.h:20
@@ +19,1 @@
+#endif
\ No newline at end of file
----------------
Put a newline here
================
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.h:22
@@ -21,3 +21,3 @@
class ProcessWinMiniDump : public lldb_private::Process
{
----------------
I was expecting this to also derive from `ProcessWindows`, because I thought
that was the whole point of moving `ProcessWindows` to common and then making
`ProcessWindowsLive` inherit from it. Is there goign to be some work on this
in a followup patch or did I misunderstand the purpose of raising that up to
the common area?
http://reviews.llvm.org/D14136
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
