Re: [Lldb-commits] [PATCH] D14042: Add more NetBSD platform glue for lldb

2015-10-24 Thread Kamil Rytarowski via lldb-commits
krytarowski added a subscriber: brucem. krytarowski added a comment. +brucem, committer of the previous NetBSD glue Repository: rL LLVM http://reviews.llvm.org/D14042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org

Re: [Lldb-commits] [PATCH] D14020: Port the python api decorator to use test categories

2015-10-24 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. I like it. http://reviews.llvm.org/D14020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [Lldb-commits] [PATCH] D14023: Fix uses of range / xrange for Python 3

2015-10-24 Thread Todd Fiala via lldb-commits
tfiala added inline comments. Comment at: test/lang/go/types/TestGoASTContext.py:134 @@ -131,3 +133,3 @@ self.assertEqual(5, v.GetNumChildren()) -for i in xrange(5): +for i in six.moves.xrange(5): self.assertEqual(str(i + 1), v.GetChildAtIndex

Re: [Lldb-commits] [PATCH] D14023: Fix uses of range / xrange for Python 3

2015-10-24 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. > I've been putting most of this stuff in withouty review, but I figure every > once in a while I should pass one your way as a sanity check to make sure I'm > still on the right path. That'

Re: [Lldb-commits] [PATCH] D14028: Convert long to int and portably detect integral types

2015-10-24 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D14028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] r251221 - Remove some unnecessary macosx.internal SDK settings in

2015-10-24 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Sun Oct 25 01:51:37 2015 New Revision: 251221 URL: http://llvm.org/viewvc/llvm-project?rev=251221&view=rev Log: Remove some unnecessary macosx.internal SDK settings in the debugserver xcode project file. Modified: lldb/trunk/tools/debugserver/debugserver.xcodeproj/proje