tfiala accepted this revision.
tfiala added a reviewer: tfiala.
tfiala added a comment.
This revision is now accepted and ready to land.
Accepting with given changes.
http://reviews.llvm.org/D13124
___
lldb-commits mailing list
lldb-commits@lists.ll
jasonmolenda added a comment.
Looks good to me, I don't have anything beyond Pavel's suggestions. I don't
know the format of the ARM .exidx .extab unwind info so I don't have any
feedback on the parsing of that.
I forgot about that code in RegisterContextLLDB::GetFullUnwindPlanForFrame()
for
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D13245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
dawn added a subscriber: lldb-commits.
Users:
paulherman (Author)
http://reviews.llvm.org/rL247836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: spyffe
Date: Tue Sep 29 17:52:50 2015
New Revision: 248842
URL: http://llvm.org/viewvc/llvm-project?rev=248842&view=rev
Log:
Removed a bunch of dependencies of Materializer on ClangUserExpression.
Instead we now just generically use UserExpression.
Modified:
lldb/trunk/source/Expressi
Author: tfiala
Date: Tue Sep 29 18:06:56 2015
New Revision: 248846
URL: http://llvm.org/viewvc/llvm-project?rev=248846&view=rev
Log:
Skipping TestAttachDenied.py on Linux as it is hanging on a buildbot after
r248834.
I'll track down what is happening here.
Modified:
lldb/trunk/test/functio
ovyalov added inline comments.
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:341
@@ -347,1 +340,3 @@
+AdbClient adb(m_device_id);
+
StreamString command;
I tried this CL on my device and it's failing to download a symbol
jasonmolenda added a subscriber: jasonmolenda.
jasonmolenda added a comment.
Greg's out this week, he or Jim may want to comment.
I was curious about this method IncrementFalseAlarmsAndReviseHitCount, there
weren't any calls to it. A little digging shows that the one use of it was
removed in r
dawn accepted this commit.
dawn added a comment.
> Clang (the LLDB compiler) does not ask for the value ScNSpacGl in the global
> namespace, but just for a value named ScNSpacGl.
Ok, I've opened a separate bug for this then,
https://llvm.org/bugs/show_bug.cgi?id=24994.
Users:
paulherman (A
zturner added a subscriber: zturner.
zturner added a comment.
Can you add a test for this?
Repository:
rL LLVM
http://reviews.llvm.org/D13241
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Can you add a test for this?
On Tue, Sep 29, 2015 at 5:41 PM Jason Molenda via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> jasonmolenda added a subscriber: jasonmolenda.
> jasonmolenda added a comment.
>
> Greg's out this week, he or Jim may want to comment.
>
> I was curious about this
Does timeout not work?
On Tue, Sep 29, 2015 at 4:06 PM, Todd Fiala via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: tfiala
> Date: Tue Sep 29 18:06:56 2015
> New Revision: 248846
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248846&view=rev
> Log:
> Skipping TestAttachDenied.py
dawn added a subscriber: dawn.
dawn added a comment.
Bug https://llvm.org/bugs/show_bug.cgi?id=24995 opened for "regressions" after
this commit.
Users:
paulherman (Author)
http://reviews.llvm.org/rL247836
___
lldb-commits mailing list
lldb-commi
dawn accepted this revision.
dawn added a comment.
This revision is now accepted and ready to land.
Please apply requested changes, then it's good to commit. Thanks for fixing
this!
Comment at: source/Commands/CommandObjectExpression.cpp:306
@@ -306,7 +305,3 @@
if (m_
mohit.bhakkad added a comment.
Jason, in MIPS watch registers, last 3 bits of watchpoint addresses are masked
by IRW(instruction, read, write types) flags,
so machine gives exception for any address having other bits same to the actual
watch address execept last 3 bits.
Comment at line number 7
enlight planned changes to this revision.
enlight added a comment.
I'll submit a revised patch that contains an explanation of the generator
expressions to aid future maintainers/contributors.
Comment at: cmake/modules/LLDBConfig.cmake:61
@@ +60,3 @@
+ # below, otherwise C
jasonmolenda added a comment.
I see, this seems reasonable to me.
Repository:
rL LLVM
http://reviews.llvm.org/D13241
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ki.stfu accepted this revision.
ki.stfu added a comment.
lgtm apart a lack of description about the changes in
tools/lldb-mi/MICmdCmdSupportList.cpp
Comment at: tools/lldb-mi/MICmdCmdExec.h:58
@@ -57,2 +57,3 @@
bool Acknowledge() override;
+bool ParseArgs() override;
ki.stfu requested changes to this revision.
This revision now requires changes to proceed.
Comment at: tools/lldb-mi/MICmdCmdExec.h:64
@@ -62,2 +63,3 @@
private:
lldb::SBCommandReturnObject m_lldbResult;
+const CMIUtilString m_constStrArgStart; // StopAtEntry - run to
ki.stfu added a comment.
Could you make one additional cleanup here please?
Repository:
rL LLVM
http://reviews.llvm.org/D12977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
enlight created this revision.
enlight added reviewers: brucem, zturner.
enlight added a subscriber: lldb-commits.
enlight set the repository for this revision to rL LLVM.
Previously `CMAKE_BUILD_TYPE` was used to determine whether to link in
`python27.lib` or `python27_d.lib`, unfortunately this
brucem added a comment.
This looks good to me and like the correct fix. Leaving it for zturner to give
the official nod of approval though.
Repository:
rL LLVM
http://reviews.llvm.org/D13234
___
lldb-commits mailing list
lldb-commits@lists.llvm.
brucem requested changes to this revision.
brucem added a reviewer: brucem.
This revision now requires changes to proceed.
Comment at: tools/lldb-server/lldb-gdbserver.cpp:30
@@ -30,2 +29,3 @@
#include "lldb/Core/PluginManager.h"
+#include "lldb/Host/common/GetOptInc.h"
#include
krytarowski updated this revision to Diff 35950.
krytarowski added a comment.
Use proper include.
Repository:
rL LLVM
http://reviews.llvm.org/D12748
Files:
tools/lldb-server/lldb-gdbserver.cpp
Index: tools/lldb-server/lldb-gdbserver.cpp
krytarowski added inline comments.
Comment at: include/lldb/Config/config.h.cmake:6
@@ +5,3 @@
+#else
+#define CONFIG_H
+
krytarowski wrote:
> brucem wrote:
> > brucem wrote:
> > > This should be `LLDB_CONFIG_CONFIG_H` rather than just `CONFIG_H`.
> > >
> > > Als
enlight created this revision.
enlight added reviewers: brucem, zturner.
enlight added a subscriber: lldb-commits.
enlight set the repository for this revision to rL LLVM.
After a developer builds LLDB from source on Windows (assuming they've built it
with Python support enabled), they may be som
tberghammer marked 3 inline comments as done.
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:340
@@ -346,1 +339,3 @@
[this](std::string* s) {
+AdbClient adb(m_device_id);
+
ovyalov wrote:
> Could you reuse adb variable defined
Author: tberghammer
Date: Tue Sep 29 06:04:18 2015
New Revision: 248788
URL: http://llvm.org/viewvc/llvm-project?rev=248788&view=rev
Log:
Change oat symbolization code for android to work on non-rooted devices
On android when debugging an apk we run lldb-server as application user
because the sel
This revision was automatically updated to reflect the committed changes.
tberghammer marked an inline comment as done.
Closed by commit rL248788: Change oat symbolization code for android to work on
non-rooted devices (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/
mohit.bhakkad created this revision.
mohit.bhakkad added a reviewer: clayborg.
mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain,
lldb-commits.
mohit.bhakkad set the repository for this revision to rL LLVM.
Revise hit counts when hit a false positive
Repository:
rL LLVM
ht
Author: labath
Date: Tue Sep 29 07:42:56 2015
New Revision: 248790
URL: http://llvm.org/viewvc/llvm-project?rev=248790&view=rev
Log:
Enable test_create_after_attach_with_dwarf_and_popen on linux
The test still remains XTIMEOUTed. Will remove that as well if it turns out its
passing.
Modified:
KLapshin updated the summary for this revision.
KLapshin updated this revision to Diff 35969.
Repository:
rL LLVM
http://reviews.llvm.org/D12977
Files:
test/tools/lldb-mi/control/TestMiExec.py
tools/lldb-mi/MICmdCmdExec.cpp
tools/lldb-mi/MICmdCmdExec.h
tools/lldb-mi/MICmdCmdSupportList
tberghammer created this revision.
tberghammer added a reviewer: jasonmolenda.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
.ARM.exidx/.ARM.extab sections contain unwind information used on ARM
architecture from unwinding from an exception.
http://r
KLapshin marked an inline comment as done.
KLapshin added a comment.
In http://reviews.llvm.org/D12977#255390, @ki.stfu wrote:
> lgtm apart a lack of description about the changes in
> tools/lldb-mi/MICmdCmdSupportList.cpp
I added description about changes in list-features cmd handler in revie
KLapshin marked an inline comment as done.
KLapshin added a comment.
m_lldbResult usage has beed removed in ExecRun::Acknowledge() method,
corresponding member removed from cmd class.
Repository:
rL LLVM
http://reviews.llvm.org/D12977
___
lldb-c
EwanCrawford created this revision.
EwanCrawford added reviewers: jingham, clayborg.
EwanCrawford added subscribers: lldb-commits, domipheus, ADodds, dean.
EwanCrawford set the repository for this revision to rL LLVM.
Herald added subscribers: srhines, danalbert, tberghammer.
This patch adds a new
labath added a subscriber: labath.
labath added a comment.
I don't know much about the arm unwind info, but I have some style comments
from a casual read-through.
Comment at: include/lldb/Symbol/UnwindTable.h:71
@@ -67,4 +70,3 @@
-DWARFCallFrameInfo* m_eh_frame;
-Comp
ki.stfu requested changes to this revision.
This revision now requires changes to proceed.
Comment at: test/tools/lldb-mi/control/TestMiExec.py:16
@@ +15,3 @@
+@skipIfFreeBSD # Failure presumably due to StopAtEntry most likely not
implemented
+def test_lldbmi_exec_run(sel
zturner added a comment.
This looks great. This has always really annoyed me. One thing I want to
point out based on your summary of the patch. A user *must* build Python
himself, even if he is building a release version of LLDB. You *cannot* use
the version that is installed on the system.
zturner added inline comments.
Comment at: cmake/modules/LLDBConfig.cmake:61
@@ +60,3 @@
+ # below, otherwise CMake will replace the whitespace with a semicolon in
some contexts (which would stuff things up).
+ set (PYTHON_EXECUTABLE
$<$:${PYTHON_DEBUG_EXE}>$<$>:${PYTH
enlight added inline comments.
Comment at: cmake/modules/LLDBConfig.cmake:61
@@ +60,3 @@
+ # below, otherwise CMake will replace the whitespace with a semicolon in
some contexts (which would stuff things up).
+ set (PYTHON_EXECUTABLE
$<$:${PYTHON_DEBUG_EXE}>$<$>:${PYTH
KLapshin updated this revision to Diff 36005.
KLapshin added a comment.
I realized what m_events.empty check in Listener::FindNextEventInternal()
method returned event collection is NOT empty - probably because list.empty()
just compare begin != end pointers, but pointers may be absolutely inval
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
If the above if / else is equivalent, I prefer if you change it to that before
comitting. If not, feel free to commit as is.
Comment at: cmake/modules/LLDBConfig.cmake:61
KLapshin added inline comments.
Comment at: test/tools/lldb-mi/control/TestMiExec.py:16
@@ +15,3 @@
+@skipIfFreeBSD # Failure presumably due to StopAtEntry most likely not
implemented
+def test_lldbmi_exec_run(self):
+"""Test that 'lldb-mi --interpreter' can stop
tfiala added a comment.
Hey Zachary,
Have you seen diff 5 or diff 6 on Windows yet? What results did you get? I
think I'm just waiting on a clean Windows run at this point.
Thanks!
-Todd
http://reviews.llvm.org/D13124
___
lldb-commits mailing
dawn added a subscriber: lldb-commits.
Users:
paulherman (Author)
http://reviews.llvm.org/rL247746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Sorry got sidetracked this morning. I'll check it out now
On Tue, Sep 29, 2015 at 12:12 PM Todd Fiala wrote:
> tfiala added a comment.
>
> Hey Zachary,
>
> Have you seen diff 5 or diff 6 on Windows yet? What results did you get?
> I think I'm just waiting on a clean Windows run at this point.
tfiala added a comment.
Great, much appreciated, Zachary!
http://reviews.llvm.org/D13124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added inline comments.
Comment at: test/test_runner/lib/process_control.py:214
@@ +213,3 @@
+"""
+raise Exception("platform needs to implement")
+
Should this return `False` now that this is not supported on Windows, or do you
think this i
tfiala added a comment.
> Does that look right to you?
That result looks right - the two soft terminate tests get skipped when it's
not reported.
If you ran the lldb test suite with that setup, they should work as well as
they did before the change. (If they don't, I'm missing a lower level
Unless you make significant other changes, feel free to just commit. I
don't have any other concerns. Thanks for working on this!
On Tue, Sep 29, 2015 at 12:51 PM Todd Fiala wrote:
> tfiala added a comment.
>
> > Does that look right to you?
>
>
> That result looks right - the two soft termina
Great, thanks! Will do after I fix up your bits. Out for a bit but will
get this in the afternoon.
On Tue, Sep 29, 2015 at 12:53 PM, Zachary Turner wrote:
> Unless you make significant other changes, feel free to just commit. I
> don't have any other concerns. Thanks for working on this!
>
>
tfiala added inline comments.
Comment at: test/test_runner/lib/process_control.py:214
@@ +213,3 @@
+"""
+raise Exception("platform needs to implement")
+
zturner wrote:
> Should this return `False` now that this is not supported on Windows, or do
dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
This commit caused a regression when evaluating globals inside a namespace.
See comments in the following narrowed test case. Can you have a look please?
(Note: test case was tested with clang based o
ribrdb created this revision.
ribrdb added a reviewer: tfiala.
ribrdb added a subscriber: lldb-commits.
ribrdb set the repository for this revision to rL LLVM.
This implements basic line editing for the interactive python interpreter on
linux.
No tab completion, but at least backspace works.
Rep
ribrdb updated this revision to Diff 36031.
ribrdb added a comment.
Fix cmake build.
Repository:
rL LLVM
http://reviews.llvm.org/D13149
Files:
cmake/LLDBDependencies.cmake
lldb.xcodeproj/project.pbxproj
source/API/SystemInitializerFull.cpp
source/Plugins/LanguageRuntime/CMakeLists.tx
zturner created this revision.
zturner added a reviewer: clayborg.
zturner added a subscriber: lldb-commits.
Hi Greg,
This patch is pretty straightforward, but I'm posting it here because the fact
that you were explicitly casting to reference through an instance suggests that
maybe there's a de
sas created this revision.
sas added a reviewer: clayborg.
sas added a subscriber: lldb-commits.
We were missing the symbol for the version number.
http://reviews.llvm.org/D13271
Files:
cmake/LLDBDependencies.cmake
source/CMakeLists.txt
Index: source/CMakeLists.txt
=
sivachandra added a subscriber: sivachandra.
sivachandra added a comment.
Calling this a regression is probably harsh. Without looking into it much, my
feeling here is that Clang (the LLDB compiler) does not ask for the value
ScNSpacGl in the global namespace, but just for a value named ScNSpacG
tfiala updated this revision to Diff 36043.
tfiala added a comment.
Fixes for Windows per previous comments, for posterity's sake.
This is the patch I will be committing.
http://reviews.llvm.org/D13124
Files:
test/dosep.py
test/test_runner/README.txt
test/test_runner/lib/lldb_utils.py
tfiala closed this revision.
tfiala added a comment.
Committed here:
svn commit
Sendingtest/dosep.py
Adding test/test_runner
Adding test/test_runner/README.txt
Adding test/test_runner/lib
Adding test/test_runner/lib/lldb_utils.py
Adding
Author: tfiala
Date: Tue Sep 29 17:19:06 2015
New Revision: 248834
URL: http://llvm.org/viewvc/llvm-project?rev=248834&view=rev
Log:
test runner: switch to pure-Python timeout mechanism
The timeout mechanism has been implemented in python,
so there is no more dependence on external utilities
for
62 matches
Mail list logo
