zturner added inline comments.
================
Comment at: test/test_runner/lib/process_control.py:214
@@ +213,3 @@
+ """
+ raise Exception("platform needs to implement")
+
----------------
Should this return `False` now that this is not supported on Windows, or do you
think this is still ok? It's probably just of theoretical concern.
================
Comment at: test/test_runner/lib/process_control.py:229
@@ +228,3 @@
+ """
+ raise Exception("platform needs to implement")
+
----------------
Change this to:
# It's not actually documented what return code Popen.terminate()
# passes to TerminateProcess. Experimentation shows that it's always
# 1, but there's no guarantee that's true. Hopefully this check
# works well enough to be sufficient.
return returncode != 0
With these changes I get the following output:
d:\src\llvm\tools\lldb\test\test_runner\test>python process_control_tests.py
....ss
----------------------------------------------------------------------
Ran 6 tests in 1.208s
OK (skipped=2)
Does that look right to you?
http://reviews.llvm.org/D13124
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
