Re: [Lldb-commits] [PATCH] D12746: The pipe2(2) call is supported on NetBSD

I think the main reason behind it is that we have about three build systems. Any check you write will need to be implemented in all of them. Maybe when autoconf goes away, we can do a build check in cmake and xcode can just hardcode -DPIPE2_SUPPORTED=0, since it is only used on darwin anyway. On 1

Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used.

abidh requested changes to this revision. abidh added a comment. This revision now requires changes to proceed. We dont use the lldb_private stuff inside lldb-mi. Please see the discussion in the following thread. http://lists.llvm.org/pipermail/lldb-dev/2015-March/007047.html Repository: rL

[Lldb-commits] [lldb] r247256 - Fix an AttributeError in dotest.py if --executable points to a wrong place

Author: ki.stfu Date: Thu Sep 10 04:24:43 2015 New Revision: 247256 URL: http://llvm.org/viewvc/llvm-project?rev=247256&view=rev Log: Fix an AttributeError in dotest.py if --executable points to a wrong place This patch fixes the following case: ``` $ ./dotest.py --executable=~/p/llvm/build_nin

Re: [Lldb-commits] TestFormattersBoolRefPtr.py on OSX

I don't know about any recent compiler update, about the build bot, but will try to figure it out. The current versions: Darwin Yings-Mac-Pro.local 14.4.0 Darwin Kernel Version 14.4.0: Thu May 28 11:35:04 PDT 2015; root:xnu-2782.30.5~1/RELEASE_X86_64 x86_64 Apple LLVM version 6.1.0 (clang-602.0.53

[Lldb-commits] [lldb] r247262 - New RenderScript command to break on all kernels

Author: ewancrawford Date: Thu Sep 10 05:08:48 2015 New Revision: 247262 URL: http://llvm.org/viewvc/llvm-project?rev=247262&view=rev Log: New RenderScript command to break on all kernels Patch adds a command to RenderScript plugin allowing users to automatically set breakpoints on every RS kern

Re: [Lldb-commits] [PATCH] D12728: New RenderScript command to break on all kernels

This revision was automatically updated to reflect the committed changes. Closed by commit rL247262: New RenderScript command to break on all kernels (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D12728?vs=34327&id=34424#toc Repository: rL LLVM http://reviews.

[Lldb-commits] [lldb] r247267 - Fix crash in lldb-server caused by an API change in LLVM

Author: tberghammer Date: Thu Sep 10 06:08:41 2015 New Revision: 247267 URL: http://llvm.org/viewvc/llvm-project?rev=247267&view=rev Log: Fix crash in lldb-server caused by an API change in LLVM Modified: lldb/trunk/tools/lldb-server/LLDBServerUtilities.cpp Modified: lldb/trunk/tools/lldb-se

[Lldb-commits] [PATCH] D12755: Improve the arm/aarch64 mapping symbol handling

tberghammer created this revision. tberghammer added a reviewer: clayborg. tberghammer added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. Improve the arm/aarch64 mapping symbol handling Change the mapping symbol handling to handle the case when the mapping symbols are

[Lldb-commits] [PATCH] D12756: Build Plugin/JITLoader/GDB on all platforms.

brucem created this revision. brucem added reviewers: clayborg, labath. brucem added a subscriber: lldb-commits. We currently link to this on all platforms, so don't need to re-include it into the LLDB_USED_LIBS. Also don't need to special case building it for every supported platform. http://rev

[Lldb-commits] [PATCH] D12757: Fix prologue end handling when code compiled by gcc

tberghammer created this revision. tberghammer added a reviewer: clayborg. tberghammer added a subscriber: lldb-commits. Fix prologue end handling when code compiled by gcc GCC don't use the is_prologue_end flag to mark the first instruction after the prologue. Instead of it it is issuing a line

Re: [Lldb-commits] [PATCH] D12756: Build Plugin/JITLoader/GDB on all platforms.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D12756 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [lldb] r247284 - Build Plugin/JITLoader/GDB on all platforms.

Author: brucem Date: Thu Sep 10 09:28:49 2015 New Revision: 247284 URL: http://llvm.org/viewvc/llvm-project?rev=247284&view=rev Log: Build Plugin/JITLoader/GDB on all platforms. Summary: We currently link to this on all platforms, so don't need to re-include it into the LLDB_USED_LIBS. Also don't

Re: [Lldb-commits] [PATCH] D12756: Build Plugin/JITLoader/GDB on all platforms.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247284: Build Plugin/JITLoader/GDB on all platforms. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D12756?vs=34434&id=3#toc Repository: rL LLVM http://reviews.llvm.org/D

[Lldb-commits] [PATCH] D12762: Clean up building & linking of Process/elf-core.

brucem created this revision. brucem added reviewers: clayborg, labath. brucem added a subscriber: lldb-commits. * cmake/LLDBDependencies.cmake: elf-core is already included globally in LLDB_USED_LIBS, so it doesn't need to be re-added on individual platforms. * lib/Makefile: elf-core is link

[Lldb-commits] [PATCH] D12764: [lldb-mi] Remove MIUtilSystem*.

brucem created this revision. brucem added reviewers: ki.stfu, domipheus, abidh. brucem added a subscriber: lldb-commits. This platform-specific code wasn't fully implemented and wasn't actually needed. There was one call for the log file path and that has been addressed. http://reviews.llvm.org/

Re: [Lldb-commits] [PATCH] D12764: [lldb-mi] Remove MIUtilSystem*.

abidh requested changes to this revision. abidh added a comment. This revision now requires changes to proceed. There is a check on m_strMediumFileDirectory in CMICmnLogMediumFile::FileFormFileNamePath which may needs to be updated. Otherwise looks ok to me. http://reviews.llvm.org/D12764 _

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

clayborg added a comment. In http://reviews.llvm.org/D12079#242998, @jaydeep wrote: > In http://reviews.llvm.org/D12079#242742, @clayborg wrote: > > > So DumpAddress() in FormatEntity.cpp is a generic "dump any address by > > describing it". You can't just change the code to suit your needs for

Re: [Lldb-commits] [PATCH] D12750: Link NetBSD with execinfo (CMAKE build)

sas added a subscriber: sas. sas requested changes to this revision. sas added a reviewer: sas. This revision now requires changes to proceed. Comment at: cmake/LLDBDependencies.cmake:152 @@ -153,1 +151,3 @@ +# On FreeBSD/NetBSD backtrace() is provided by libexecinfo, not libc. +i

Re: [Lldb-commits] [PATCH] D12755: Improve the arm/aarch64 mapping symbol handling

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12755 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12749: Link liblldb.so with LLVMObjCARCOpts.a

sas added a subscriber: sas. sas accepted this revision. sas added a reviewer: sas. sas added a comment. This revision is now accepted and ready to land. I suppose this is not a NetBSD issue and the Makefiles just got out of sync with the CMake build system. Correct? Repository: rL LLVM http

Re: [Lldb-commits] [PATCH] D12659: Use SI_KERNEL on platforms defining it

sas added a subscriber: sas. sas accepted this revision. sas added a reviewer: sas. sas added a comment. This revision is now accepted and ready to land. Makes sense. Adding a tiny comment explaining which platforms get SI_KERNEL might be a good idea here. Repository: rL LLVM http://reviews.

Re: [Lldb-commits] [PATCH] D12757: Fix prologue end handling when code compiled by gcc

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. see inlined comments. Comment at: source/Symbol/LineTable.cpp:107-117 @@ -106,3 +106,13 @@ if (!entries.empty() && entries.back().file_addr == file_addr) +

Re: [Lldb-commits] [PATCH] D12749: Link liblldb.so with LLVMObjCARCOpts.a

krytarowski added a comment. In http://reviews.llvm.org/D12749#243410, @sas wrote: > I suppose this is not a NetBSD issue and the Makefiles just got out of sync > with the CMake build system. Correct? It seems so. Repository: rL LLVM http://reviews.llvm.org/D12749 _

Re: [Lldb-commits] [lldb] r247082 - Implement a Target::GetTypeSystemForLanguage API, as well as provide helpers on the TypeSystem to get numeric types of specific sizes and signedness

> On Sep 9, 2015, at 3:58 PM, Ryan Brown wrote: > > > > On Wed, Sep 9, 2015 at 2:57 PM Enrico Granata > wrote: >> On Sep 9, 2015, at 2:47 PM, Ryan Brown > > wrote: >> >> >> On Tue, Sep 8, 2015 at 3:10 PM Enrico Granata via lldb-commits >

Re: [Lldb-commits] [PATCH] D12755: Improve the arm/aarch64 mapping symbol handling

sas added a subscriber: sas. sas accepted this revision. sas added a reviewer: sas. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1857 @@ -1856,1 +1856,3 @@ +// Find the arm/aarch64 maping symbol character in the given symbol name. Maping symbols have the +// form

[Lldb-commits] [lldb] r247329 - A little more cleanup in the build script that creates a list of archive directories to make things more clear.

Author: gclayton Date: Thu Sep 10 14:46:25 2015 New Revision: 247329 URL: http://llvm.org/viewvc/llvm-project?rev=247329&view=rev Log: A little more cleanup in the build script that creates a list of archive directories to make things more clear. Modified: lldb/trunk/scripts/build-llvm.pl

Re: [Lldb-commits] [PATCH] D12750: Link NetBSD with execinfo (CMAKE build)

krytarowski updated this revision to Diff 34490. krytarowski added a comment. typo Repository: rL LLVM http://reviews.llvm.org/D12750 Files: cmake/LLDBDependencies.cmake Index: cmake/LLDBDependencies.cmake === --- cmake/LLDBD

Re: [Lldb-commits] [PATCH] D12659: Use SI_KERNEL on platforms defining it

krytarowski added a comment. In http://reviews.llvm.org/D12659#243415, @sas wrote: > Makes sense. Adding a tiny comment explaining which platforms get SI_KERNEL > might be a good idea here. Can I replace the following comment: // Linux will occasionally send spurious SI_KERNEL codes. // (

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

paulherman added a comment. Ping. http://reviews.llvm.org/D12658 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So a few themes I would like to get fixed: - Don't parse everything in DWARF in case we ever need it (like parsing all namespaces and their contained variables, parse and cache a

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

paulherman added a comment. I agree with most of your comments and will fix them. One thing I noticed is that Block::GetDeclContext() does not do the right thing (see inline comment). About creating a CompilerDecl class, I agree with you. I used CompilerDeclContext since it was just a void* an

Re: [Lldb-commits] [PATCH] D12659: Use SI_KERNEL on platforms defining it

emaste added a comment. In http://reviews.llvm.org/D12659#243729, @krytarowski wrote: > In http://reviews.llvm.org/D12659#243415, @sas wrote: > > > > > > To something more generic: > > // Some platforms will occasionally send nonstandard spurious SI_KERNEL > codes. > // One way to get this i

Re: [Lldb-commits] [PATCH] D12762: Clean up building & linking of Process/elf-core.

emaste added a subscriber: emaste. emaste accepted this revision. emaste added a reviewer: emaste. emaste added a comment. LGTM too http://reviews.llvm.org/D12762 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

Re: [Lldb-commits] [PATCH] D12746: The pipe2(2) call is supported on NetBSD

emaste added a subscriber: emaste. Comment at: source/Host/posix/PipePosix.cpp:39 @@ -38,3 +38,3 @@ -// pipe2 is supported by Linux, FreeBSD v10 and higher. +// pipe2 is supported by Linux, FreeBSD v10 and higher, NetBSD 6.0 and newer // TODO: Add more platforms that support pi

Re: [Lldb-commits] [PATCH] D12659: Use SI_KERNEL on platforms defining it

krytarowski updated this revision to Diff 34510. krytarowski added a comment. Rework the comment regarding SI_KERNEL. Repository: rL LLVM http://reviews.llvm.org/D12659 Files: source/Plugins/Process/POSIX/CrashReason.cpp Index: source/Plugins/Process/POSIX/CrashReason.cpp

Re: [Lldb-commits] [PATCH] D12746: The pipe2(2) call is supported on NetBSD

krytarowski added inline comments. Comment at: source/Host/posix/PipePosix.cpp:39 @@ -38,3 +38,3 @@ -// pipe2 is supported by Linux, FreeBSD v10 and higher. +// pipe2 is supported by Linux, FreeBSD v10 and higher, NetBSD 6.0 and newer // TODO: Add more platforms that support pi

Re: [Lldb-commits] [PATCH] D12746: The pipe2(2) call is supported on NetBSD

krytarowski updated this revision to Diff 34512. krytarowski added a comment. rediff the comment Repository: rL LLVM http://reviews.llvm.org/D12746 Files: source/Host/posix/PipePosix.cpp Index: source/Host/posix/PipePosix.cpp ===

Re: [Lldb-commits] [PATCH] D12764: [lldb-mi] Remove MIUtilSystem*.

brucem updated this revision to Diff 34514. brucem added a comment. Removing an error check that is no longer needed and the corresponding error message. A broader cleanup is possible here, but I would rather do that as a separate commit. http://reviews.llvm.org/D12764 Files: lldb.xcodeproj/

Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used.

dawn added a comment. In http://reviews.llvm.org/D12115#243093, @abidh wrote: > We dont use the lldb_private stuff inside lldb-mi. Please see the discussion > in the following thread. > http://lists.llvm.org/pipermail/lldb-dev/2015-March/007047.html Thank you for your review and for the link.

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg added a comment. In http://reviews.llvm.org/D12658#243863, @paulherman wrote: > I agree with most of your comments and will fix them. > > One thing I noticed is that Block::GetDeclContext() does not do the right > thing (see inline comment). Yep, we only ever needed the function decl

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

paulherman added a comment. I believe that the approach of CompilerDeclContext::FindDecls could be better. But then this kind of forces CompilerDeclContext to inherit CompilerDecl (a function is both a DeclContext and a Decl) and I believe that creating a class for each possible entity is an ov

[Lldb-commits] [lldb] r247366 - Clean up building & linking of Process/elf-core.

Author: brucem Date: Thu Sep 10 19:31:33 2015 New Revision: 247366 URL: http://llvm.org/viewvc/llvm-project?rev=247366&view=rev Log: Clean up building & linking of Process/elf-core. Summary: * cmake/LLDBDependencies.cmake: elf-core is already included globally in LLDB_USED_LIBS, so it doesn't n

Re: [Lldb-commits] [PATCH] D12762: Clean up building & linking of Process/elf-core.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247366: Clean up building & linking of Process/elf-core. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D12762?vs=34445&id=34517#toc Repository: rL LLVM http://reviews.llvm.o

Re: [Lldb-commits] [PATCH] D12749: Link liblldb.so with LLVMObjCARCOpts.a

brucem added a subscriber: brucem. brucem added a comment. Yes, Ted Woodward and others have mentioned having this issue on the buildbots. Repository: rL LLVM http://reviews.llvm.org/D12749 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

Re: [Lldb-commits] [PATCH] D12750: Link NetBSD with execinfo (CMAKE build)

brucem added a subscriber: brucem. brucem requested changes to this revision. brucem added a reviewer: brucem. This revision now requires changes to proceed. Comment at: cmake/LLDBDependencies.cmake:152 @@ -153,1 +151,3 @@ +# On FreeBSD/NetBSD backtrace() is provided by libexecinf

Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used.

The FileSpec is not even used for anything is it? If you want to use the RegularExpression, then use llvm's regular expression. Honestly LLDB's regular expression should be deprecated anyway, there's no reason to have an LLDB regex and an LLVM regex when just one will suffice On Thu, Sep 10, 201

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep added a comment. In http://reviews.llvm.org/D12079#243390, @clayborg wrote: > In http://reviews.llvm.org/D12079#242998, @jaydeep wrote: > > > In http://reviews.llvm.org/D12079#242742, @clayborg wrote: > > > > > So DumpAddress() in FormatEntity.cpp is a generic "dump any address by > > >

[Lldb-commits] [lldb] r247383 - Link liblldb.so with LLVMObjCARCOpts.a

Author: brucem Date: Thu Sep 10 22:52:08 2015 New Revision: 247383 URL: http://llvm.org/viewvc/llvm-project?rev=247383&view=rev Log: Link liblldb.so with LLVMObjCARCOpts.a Summary: Problems reported on NetBSD: ``` llvm[4]: Linking Debug+Asserts executable lldb /tmp/build-llvm/Debug+Asserts/lib/l

Re: [Lldb-commits] [PATCH] D12749: Link liblldb.so with LLVMObjCARCOpts.a

This revision was automatically updated to reflect the committed changes. Closed by commit rL247383: Link liblldb.so with LLVMObjCARCOpts.a (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D12749?vs=34400&id=34527#toc Repository: rL LLVM http://reviews.llvm.org/D12749

[Lldb-commits] [PATCH] D12792: Clean up build of JITLoader/GDB in autoconf build.

brucem created this revision. brucem added reviewers: labath, clayborg, emaste. brucem added a subscriber: lldb-commits. This builds on all platforms, so remove duplication in build configuration. http://reviews.llvm.org/D12792 Files: lib/Makefile source/Plugins/JITLoader/GDB/Makefile sour

Re: [Lldb-commits] [PATCH] D12749: Link liblldb.so with LLVMObjCARCOpts.a

brucem added a comment. I needed this fix in place to test some other build system changes, so I landed it. Thanks! Repository: rL LLVM http://reviews.llvm.org/D12749 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.or

Re: [Lldb-commits] [PATCH] D12764: [lldb-mi] Remove MIUtilSystem*.

ki.stfu accepted this revision. ki.stfu added a comment. lgtm http://reviews.llvm.org/D12764 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r247388 - [lldb-mi] Remove MIUtilSystem*.

Author: brucem Date: Thu Sep 10 23:50:44 2015 New Revision: 247388 URL: http://llvm.org/viewvc/llvm-project?rev=247388&view=rev Log: [lldb-mi] Remove MIUtilSystem*. Summary: This platform-specific code wasn't fully implemented and wasn't actually needed. There was one call for the log file path a

Re: [Lldb-commits] [PATCH] D12764: [lldb-mi] Remove MIUtilSystem*.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247388: [lldb-mi] Remove MIUtilSystem*. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D12764?vs=34514&id=34531#toc Repository: rL LLVM http://reviews.llvm.org/D12764 Files:

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep added a comment. In http://reviews.llvm.org/D12079#244059, @jaydeep wrote: > In http://reviews.llvm.org/D12079#243390, @clayborg wrote: > > > In http://reviews.llvm.org/D12079#242998, @jaydeep wrote: > > > > > In http://reviews.llvm.org/D12079#242742, @clayborg wrote: > > > > > > > So Dum

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep updated this revision to Diff 34532. jaydeep added a comment. In this patch: Modified DumpAddress() to print compressed address for microMIPS. Repository: rL LLVM http://reviews.llvm.org/D12079 Files: source/Core/FormatEntity.cpp source/Plugins/Disassembler/llvm/DisassemblerLLVMC

Re: [Lldb-commits] [PATCH] D12764: [lldb-mi] Remove MIUtilSystem*.

brucem added a comment. This seems to have broken 2 tests. I have to step out for about 3 hours, but will fix it when I return. Repository: rL LLVM http://reviews.llvm.org/D12764 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://l

Re: [Lldb-commits] [PATCH] D12764: [lldb-mi] Remove MIUtilSystem*.

brucem added a comment. The error is not setting m_bInitialized in the Initialize method on the LogMediumFile class. Will fix when back at computer. Repository: rL LLVM http://reviews.llvm.org/D12764 ___ lldb-commits mailing list lldb-commits@l