The FileSpec is not even used for anything is it? If you want to use the RegularExpression, then use llvm's regular expression. Honestly LLDB's regular expression should be deprecated anyway, there's no reason to have an LLDB regex and an LLVM regex when just one will suffice
On Thu, Sep 10, 2015 at 5:04 PM Dawn Perchik <dawn+l...@burble.org> wrote: > dawn added a comment. > > In http://reviews.llvm.org/D12115#243093, @abidh wrote: > > > We dont use the lldb_private stuff inside lldb-mi. Please see the > discussion in the following thread. > > http://lists.llvm.org/pipermail/lldb-dev/2015-March/007047.html > > > Thank you for your review and for the link. I agree in general and have > avoided lldb_private myself, but this means duplicated code which is > arguably worse. I think it's time to make lldb-mi a proper part of lldb to > avoid reinventing the wheel, or adding SB APIs that make no sense outside > of lldb-mi. But I am sympathetic to both arguments so will revise. > > > Repository: > rL LLVM > > http://reviews.llvm.org/D12115 > > > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
