labath marked an inline comment as done.
labath added a comment.
Passing around pointers (shared or otherwise) encourages people to litter the
code with null pointer checks. For the next cleanup, I would like to move these
checks to a single place and then convert more of these functions to take
Author: labath
Date: Fri Aug 21 04:13:53 2015
New Revision: 245681
URL: http://llvm.org/viewvc/llvm-project?rev=245681&view=rev
Log:
[NativeProcessLinux] Reduce the number of casts
Summary:
NPL used to be peppered with casts of the NativeThreadProtocol objects into
NativeThreadLinux. I
move thes
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245681: [NativeProcessLinux] Reduce the number of casts
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D12187?vs=32673&id=32805#toc
Repository:
rL LLVM
http://reviews.llvm.or
tberghammer added a comment.
Thanks for the info about the plans. If you plan to move to this direction then
it make sense to leave these functions with reference arguments.
Side note: Why we use a shared_ptr for NTL? I would expect a unique_ptr would
be sufficient in NPL (or possibly a store b
tberghammer resigned from this revision.
tberghammer removed a reviewer: tberghammer.
tberghammer added a comment.
I leave this review to the others as I have no idea about how library loading
works on Windows. (On Linux/Android we use a breakpoint on a special symbol
exposed by the linker)
ht
Author: labath
Date: Fri Aug 21 05:38:31 2015
New Revision: 245687
URL: http://llvm.org/viewvc/llvm-project?rev=245687&view=rev
Log:
Add repro test case for bug #24530
Modified:
lldb/trunk/test/functionalities/signal/raise/TestRaise.py
Modified: lldb/trunk/test/functionalities/signal/raise/T
Author: tberghammer
Date: Fri Aug 21 05:49:09 2015
New Revision: 245690
URL: http://llvm.org/viewvc/llvm-project?rev=245690&view=rev
Log:
Fix assertion failure caused by r245546
Change the way EmulateInstruction::eContextPopRegisterOffStack handled
in UnwindAssemblyInstEmulation::WriteRegister to
Author: labath
Date: Fri Aug 21 05:52:02 2015
New Revision: 245691
URL: http://llvm.org/viewvc/llvm-project?rev=245691&view=rev
Log:
Increase timeout in TestExpressionInSyscall
test times out on the windows->android buildbot (probably due to android
emulator being slow)
Modified:
lldb/trun
tberghammer created this revision.
tberghammer added reviewers: sas, clayborg.
tberghammer added a subscriber: lldb-commits.
Add absolute load address support for the DynamicLoader plugins
The POSIX linker generally reports the load bias for the loaded
libraries but in some case it is useful to h
tberghammer added a comment.
Fixed by http://reviews.llvm.org/rL245546
Repository:
rL LLVM
http://reviews.llvm.org/D11947
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tberghammer
Date: Fri Aug 21 07:14:47 2015
New Revision: 245695
URL: http://llvm.org/viewvc/llvm-project?rev=245695&view=rev
Log:
Fix type of dw_form_t in dwarf.h
Modified:
lldb/trunk/include/lldb/Core/dwarf.h
Modified: lldb/trunk/include/lldb/Core/dwarf.h
URL:
http://llvm.org/viewv
Author: tberghammer
Date: Fri Aug 21 07:14:50 2015
New Revision: 245696
URL: http://llvm.org/viewvc/llvm-project?rev=245696&view=rev
Log:
Fix BuildAddressRangeTable function when no debug arranges present
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
Modified: lld
labath created this revision.
labath added a reviewer: tberghammer.
labath added a subscriber: lldb-commits.
Most NPL private functions took (shared) pointers to threads as arguments. This
meant that the
callee could not be sure if the pointer was valid and so most functions were
peppered with
n
tberghammer created this revision.
tberghammer added reviewers: clayborg, labath.
tberghammer added a subscriber: lldb-commits.
Add support for DW_FORM_GNU_[addr,str]_index
These are 2 new value currently in experimental status used when split debug
info is enabled.
Note: This CL is part of a l
tberghammer added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h:56
@@ -55,2 +55,3 @@
dw_addr_t GetBaseAddress() const { return m_base_addr; }
+dw_addr_t GetAddrBase() const { return 0; } // TODO: Read out
DW_AT_addr_base from the par
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Fix buffer overflow for fixed_form_sizes
The array is indexed by the value in the DW_FORM filed what can be
bigger then the size of the array. This CL add bound checking
labath added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp:24
@@ -25,1 +23,3 @@
+static DWARFFormValue::FixedFormSizes
+g_form_sizes_addr4 {
0, // 0x00 unused
Will these be linker-initialized? As I understand it, we are tryin
labath added a comment.
Looks reasonable at a first glance, but I'll leave the review to someone else.
http://reviews.llvm.org/D12238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good (I assume when you dropped const from the argument it was
intentional)
http://reviews.llvm.org/D12237
___
lldb-commits mail
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D12218
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
I agree that this change has caused many problems and is quite large to commit
to a release branch with little testing.
I do really want to get to a Scalar and RegisterValue that uses llvm::APInt and
llvm::APFloat as soon as possible, but seeing as this patch has continually
caused crashes it s
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D12233
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:179
@@ -178,3 +178,3 @@
bool prev_die_had_children = false;
-cons
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Looks good, a few changes needed.
We might consider changing FormValue::AsCString() to take a "SymbolFileDWARF*"
instead of the data extractor for .debug_str and .debug_str_offs
Author: sas
Date: Fri Aug 21 11:51:56 2015
New Revision: 245708
URL: http://llvm.org/viewvc/llvm-project?rev=245708&view=rev
Log:
Implement handling of `library:` keys in thread stop replies.
Summary:
When a windows remote stops because of a DLL load/unload, the debug server
sends a stop reply pa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245708: Implement handling of `library:` keys in thread stop
replies. (authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D12218?vs=32766&id=32835#toc
Repository:
rL LLVM
http://revi
sas created this revision.
sas added reviewers: clayborg, zturner.
sas added a subscriber: lldb-commits.
This commit implements basic DidAttach and DidLaunch for the windows
DynamicLoader plugin which allow us to load shared libraries from the
inferior.
At the moment, I'm unsure how we're going t
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Fine for now.
http://reviews.llvm.org/D12245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
zturner added a comment.
Can you verify that this does not break local debugging on Windows?
http://reviews.llvm.org/D12245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sas updated this revision to Diff 32842.
sas added a comment.
Style.
http://reviews.llvm.org/D12245
Files:
source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp
Index: source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp
sas added a comment.
@zturner, will do before submitting.
http://reviews.llvm.org/D12245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
I'm not happy about this.
lldb builds fine on Linux for me. What's the build problem on mips? I
also don't see the relation between r245240 (which was also a large
patch) and this, but I haven't looked closely and am not familiar with
the code.
In general it would be nice if merge requests don't
Tested on Windows, I don't see any problems, so lgtm.
If you're going to be doing a non-trivial amount of work on ProcessWindows
or DynamicLoaderWindows, would it be possible for you to set up a Windows
box you can test from? I'm happy to help you get this set up if you need.
On Fri, Aug 21, 201
sas added a comment.
Thanks for the testing. I'll definitely setup a windows box.
http://reviews.llvm.org/D12245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sas
Date: Fri Aug 21 14:28:34 2015
New Revision: 245725
URL: http://llvm.org/viewvc/llvm-project?rev=245725&view=rev
Log:
Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD.
Summary:
This commit implements basic DidAttach and DidLaunch for the windows
DynamicLoader plugi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245725: Implement basic DidAttach and DidLaunch for
DynamicLoaderWindowsDYLD. (authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D12245?vs=32842&id=32853#toc
Repository:
rL LLVM
htt
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: zturner
Date: Fri Aug 21 17:11:21 2015
New Revision: 245748
URL: http://llvm.org/viewvc/llvm-project?rev=245748&view=rev
Log:
Skip TestCreateAfterAttach on Windows.
As with every other platform, this test occasionally hangs on
Windows.
Modified:
lldb/trunk/test/functionalities/threa
Author: zturner
Date: Fri Aug 21 17:11:09 2015
New Revision: 245747
URL: http://llvm.org/viewvc/llvm-project?rev=245747&view=rev
Log:
XFAIL Tests that require C++ exceptions on Windows.
clang-cl does not yet support C++ exceptions, so these tests will
not even compile.
Re-enabling these tests is
Author: zturner
Date: Fri Aug 21 17:11:40 2015
New Revision: 245750
URL: http://llvm.org/viewvc/llvm-project?rev=245750&view=rev
Log:
Fix TestPaths on Windows.
Modified:
lldb/trunk/test/functionalities/paths/TestPaths.py
Modified: lldb/trunk/test/functionalities/paths/TestPaths.py
URL:
http
Author: zturner
Date: Fri Aug 21 17:11:50 2015
New Revision: 245751
URL: http://llvm.org/viewvc/llvm-project?rev=245751&view=rev
Log:
XFAIL pthreads test on Windows.
This test needs to be ported to c++ threads.
Modified:
lldb/trunk/test/functionalities/expr-doesnt-deadlock/TestExprDoesntBloc
Author: zturner
Date: Fri Aug 21 17:11:31 2015
New Revision: 245749
URL: http://llvm.org/viewvc/llvm-project?rev=245749&view=rev
Log:
XFAIL the last Windows test that calls a function in the target.
Modified:
lldb/trunk/test/lang/cpp/static_methods/TestCPPStaticMethods.py
Modified: lldb/trun
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Looks good. I'm guessing that at some point the RegisterContext and
ExceptionRecord stuff will be moved to Common?
http://reviews.llvm.org/D12252
___
Author: zturner
Date: Fri Aug 21 18:57:25 2015
New Revision: 245765
URL: http://llvm.org/viewvc/llvm-project?rev=245765&view=rev
Log:
Revert "Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD."
This reverts commit 7749a10ddbe22767d0e055753c674fcde7f28d39.
This commit introduce
Hi Stephane, I'm sorry but I had to revert this change. When I tested it
locally, I did it without running the full test suite, but when I did run
the full test suite it showed about 15-20 new test failures. I should have
caught this earlier by running the full test suite, so sorry about that.
I
By the way, I'm actively working on getting the test suite completely
running on a buildbot, but I need to get down to a green baseline first.
Still a few weeks out, but hopefully this type of thing will be caught
automatically in the future.
On Fri, Aug 21, 2015 at 5:00 PM Zachary Turner wrote:
sas added a comment.
Not a problem at all. Sorry for breaking the tests.
I'm setting up a Windows VM now to be able to run these tests. I'll let you
know if I'm stuck.
Repository:
rL LLVM
http://reviews.llvm.org/D12245
___
lldb-commits mailing
47 matches
Mail list logo
