Author: sas Date: Fri Aug 21 14:28:34 2015 New Revision: 245725 URL: http://llvm.org/viewvc/llvm-project?rev=245725&view=rev Log: Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD.
Summary: This commit implements basic DidAttach and DidLaunch for the windows DynamicLoader plugin which allow us to load shared libraries from the inferior. At the moment, I'm unsure how we're going to gather the load address of the main module over gdb protocol so I always use an offset of 0, which works well for processes we create ourselves (no randomization). I will address this point later on. Reviewers: clayborg, zturner Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D12245 Modified: lldb/trunk/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp Modified: lldb/trunk/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp?rev=245725&r1=245724&r2=245725&view=diff ============================================================================== --- lldb/trunk/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp (original) +++ lldb/trunk/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp Fri Aug 21 14:28:34 2015 @@ -9,6 +9,7 @@ #include "DynamicLoaderWindowsDYLD.h" +#include "lldb/Core/Log.h" #include "lldb/Core/PluginManager.h" #include "lldb/Target/Process.h" #include "lldb/Target/Target.h" @@ -72,11 +73,38 @@ DynamicLoaderWindowsDYLD::CreateInstance void DynamicLoaderWindowsDYLD::DidAttach() { + Log *log(GetLogIfAnyCategoriesSet(LIBLLDB_LOG_DYNAMIC_LOADER)); + if (log) + log->Printf("DynamicLoaderWindowsDYLD::%s()", __FUNCTION__); + + DidLaunch(); + + m_process->LoadModules(); } void DynamicLoaderWindowsDYLD::DidLaunch() { + Log *log(GetLogIfAnyCategoriesSet(LIBLLDB_LOG_DYNAMIC_LOADER)); + if (log) + log->Printf("DynamicLoaderWindowsDYLD::%s()", __FUNCTION__); + + ModuleSP executable = GetTargetExecutable(); + + if (!executable.get()) + return; + + ModuleList module_list; + module_list.Append(executable); + // FIXME: We probably should not always use 0 as the load address + // here. Testing showed that when debugging a process that we start + // ourselves, there's no randomization of the load address of the + // main module, therefore an offset of 0 will be valid. + // If we attach to an already running process, this is probably + // going to be wrong and we'll have to get the load address somehow. + UpdateLoadedSections(executable, LLDB_INVALID_ADDRESS, 0); + + m_process->GetTarget().ModulesDidLoad(module_list); } Error _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
