[Lldb-commits] [PATCH] D11935: Fetch SDK version from PlatformAndroid

tberghammer created this revision. tberghammer added a reviewer: ovyalov. tberghammer added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. Fetch SDK version from PlatformAndroid The SDK version implies the features supported by a given android device. This

[Lldb-commits] [PATCH] D11936: Download symbol file for .oat files on android

tberghammer created this revision. tberghammer added a reviewer: ovyalov. tberghammer added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. Download symbol file for .oat files on android On android .oat files (compiled java code) don't have symbol informatio

Re: [Lldb-commits] [PATCH] D11935: Fetch SDK version from PlatformAndroid

ovyalov added a comment. Please see my comments. Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:284 @@ +283,3 @@ +std::string version_string; +RunShellCommand("getprop ro.build.version.sdk", +GetWorkingDirectory(), Co

Re: [Lldb-commits] [PATCH] D11790: Fix ObjC++ types Class and id being defined in C and C++ expressions.

spyffe added a comment. It looks like this patch does not use "language" to determine which language the expression parser runs in, but rather to allow lookups specifically of "id" and "Class" if the current frame is not Objective-C++. Is that correct? http://reviews.llvm.org/D11790 __

Re: [Lldb-commits] [PATCH] D11936: Download symbol file for .oat files on android

ovyalov added a comment. Please see my comments. Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:306 @@ +305,3 @@ +if (!module_sp->GetPlatformFileSpec()) +return Error("No platform file specified"); + indentation. Co

Re: [Lldb-commits] [PATCH] D11790: Fix ObjC++ types Class and id being defined in C and C++ expressions.

spyffe requested changes to this revision. spyffe added a comment. This revision now requires changes to proceed. Ooh, I'm reading the patch at the beginning of ClangUserExpression::Evaluate again and it does look like this patch sets language based on the language of the containing frame, and t

Re: [Lldb-commits] [PATCH] D11935: Fetch SDK version from PlatformAndroid

tberghammer updated this revision to Diff 31822. tberghammer added a comment. Address review comments http://reviews.llvm.org/D11935 Files: source/Plugins/Platform/Android/PlatformAndroid.cpp source/Plugins/Platform/Android/PlatformAndroid.h Index: source/Plugins/Platform/Android/PlatformA

Re: [Lldb-commits] [PATCH] D11935: Fetch SDK version from PlatformAndroid

ovyalov accepted this revision. ovyalov added a comment. This revision is now accepted and ready to land. Looks good. Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:292 @@ +291,3 @@ + 1); +if (error.Fail() || status != 0 || v

Re: [Lldb-commits] [PATCH] D11790: Fix ObjC++ types Class and id being defined in C and C++ expressions.

paulherman added a comment. The idea is that, as I user, I do not expect the identifiers "Class" and "id" to not be available - I don't think I've seen a warning or notice about that when evaluating expressions. I believe that setting the language based on the current frame is a good guess. I

Re: [Lldb-commits] [PATCH] D11672: [MIPS] Handle false positives for MIPS hardware watchpoints

clayborg accepted this revision. clayborg added a comment. Looks fine. Repository: rL LLVM http://reviews.llvm.org/D11672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D11930: [MIPS]Handle floating point and aggregate return types in SysV-mips [32 bit] ABI

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Init the variables and this is good to go. Comment at: source/Plugins/ABI/SysV-mips/ABISysV_mips.cpp:426-428 @@ -425,3 +425,5 @@ bool is_signed; +

Re: [Lldb-commits] [PATCH] D11519: [MIPS] Use qfThreadID if qC packet is not supported by target

clayborg added a comment. Lets just not send the OS then since it is very unreliable when the target if first attaching or launching and just always back up to using qfThreadID if first qProcessInfo and then qC are not implemented. We need some way to get the pid, so lets just do it.

Re: [Lldb-commits] [PATCH] D11936: Download symbol file for .oat files on android

tberghammer updated this revision to Diff 31826. tberghammer marked 8 inline comments as done. tberghammer added a comment. Address comments http://reviews.llvm.org/D11936 Files: include/lldb/Target/Platform.h source/Plugins/Platform/Android/PlatformAndroid.cpp source/Plugins/Platform/And

Re: [Lldb-commits] [PATCH] D11936: Download symbol file for .oat files on android

tberghammer added a comment. See responds inline Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:325 @@ +324,3 @@ + &tmpdir, + 1); + ovyalov wrote: > Please add constant for timeou

[Lldb-commits] [PATCH] D11947: Improve instruction emulation based stack unwinding

tberghammer created this revision. tberghammer added a reviewer: jasonmolenda. tberghammer added a subscriber: lldb-commits. Herald added a subscriber: aemerson. Improve instruction emulation based stack unwinding On ARM there is no difference between a pop and a load instruction so a register ca

Re: [Lldb-commits] [PATCH] D11947: Improve instruction emulation based stack unwinding

tberghammer updated this revision to Diff 31828. http://reviews.llvm.org/D11947 Files: source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp Index: so

Re: [Lldb-commits] [PATCH] D11747: [MIPS] Support standard GDB remote stop reply packet for watchpoint

clayborg added a subscriber: clayborg. clayborg requested changes to this revision. clayborg added a reviewer: clayborg. clayborg added a comment. This revision now requires changes to proceed. See inlined comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommuni

Re: [Lldb-commits] [PATCH] D11936: Download symbol file for .oat files on android

ovyalov accepted this revision. ovyalov added a comment. This revision is now accepted and ready to land. LGTM Comment at: source/Utility/ModuleCache.cpp:207 @@ +206,3 @@ + +FileSpec symfile_spec((cached_module_sp->GetFileSpec ().GetPath () + ".sym").c_str (), false); +

Re: [Lldb-commits] [lldb] r243091 - Handle old style S packet correctly

Ping? On Wed, Aug 5, 2015 at 1:20 PM, Hans Wennborg wrote: > Ping? > > On Wed, Jul 29, 2015 at 8:56 AM, Hans Wennborg wrote: >> Greg, I believe you're the code owner here. OK to merge? >> >> On Tue, Jul 28, 2015 at 9:05 PM, Bhushan Attarde >> wrote: >>> Hi Hans, >>> >>> Could you please add thi

[Lldb-commits] [lldb] r244663 - Don't crash if the file we want to touch doesn't exist.

Author: gclayton Date: Tue Aug 11 16:01:32 2015 New Revision: 244663 URL: http://llvm.org/viewvc/llvm-project?rev=244663&view=rev Log: Don't crash if the file we want to touch doesn't exist. Modified: lldb/trunk/test/dosep.py Modified: lldb/trunk/test/dosep.py URL: http://llvm.org/viewvc/l

Re: [Lldb-commits] [lldb] r243091 - Handle old style S packet correctly

(cc'ing the new list address) On Tue, Aug 11, 2015 at 2:03 PM, Hans Wennborg wrote: > r244664. > > Thanks, > Hans > > On Tue, Aug 11, 2015 at 1:59 PM, Greg Clayton wrote: >> Yep, OK to merge. >> >>> On Jul 29, 2015, at 8:56 AM, Hans Wennborg wrote: >>> >>> Greg, I believe you're the code owner

[Lldb-commits] [lldb] r244681 - Added missing files from checking regarding:

Author: gclayton Date: Tue Aug 11 16:49:32 2015 New Revision: 244681 URL: http://llvm.org/viewvc/llvm-project?rev=244681&view=rev Log: Added missing files from checking regarding: http://reviews.llvm.org/D8712 Added: lldb/trunk/include/lldb/Symbol/TypeSystem.h lldb/trunk/source/Symbol/T

Re: [Lldb-commits] [PATCH] D8712: Introduce a TypeSystem interface to support adding non-clang languages.

clayborg closed this revision. clayborg added a comment. Committed an updated version of this with the following two revisions: Committed revision 244679. Committed revision 244681. Repository: rL LLVM http://reviews.llvm.org/D8712 ___ lldb-comm

[Lldb-commits] [lldb] r244683 - Fix a infinite loop when killing a process that is in the middle of loading shared libraries.

Author: gclayton Date: Tue Aug 11 17:07:46 2015 New Revision: 244683 URL: http://llvm.org/viewvc/llvm-project?rev=244683&view=rev Log: Fix a infinite loop when killing a process that is in the middle of loading shared libraries. The issue was we were sending a "qSymbol::" packet and it we were a

[Lldb-commits] [PATCH] D11962: Mark TestCModules as XFAIL on OSX

ovyalov created this revision. ovyalov added reviewers: spyffe, chying, clayborg. ovyalov added a subscriber: lldb-commits. Mark TestCModules as XFAIL on OSX in order to make build bot green - http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/4722 http://reviews.llvm.org/D11962 F

[Lldb-commits] [PATCH] D11967: Export snprintf to avoid linking error with liblldb on Windows.

chaoren created this revision. chaoren added reviewers: zturner, ovyalov. chaoren added a subscriber: lldb-commits. http://reviews.llvm.org/D11967 Files: include/lldb/Host/windows/win32.h Index: include/lldb/Host/windows/win32.h =

Re: [Lldb-commits] [PATCH] D11843: Make dosep output status by overwriting the same line.

chaoren added a comment. Ping? http://reviews.llvm.org/D11843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D11962: Mark TestCModules as XFAIL on OSX

chying added a comment. Could you add the related bug to comments or argument? llvm.org/pr24302 http://reviews.llvm.org/D11962 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r244710 - Export snprintf to avoid linking error with liblldb on Windows.

Author: chaoren Date: Tue Aug 11 20:22:24 2015 New Revision: 244710 URL: http://llvm.org/viewvc/llvm-project?rev=244710&view=rev Log: Export snprintf to avoid linking error with liblldb on Windows. Reviewers: zturner, ovyalov Subscribers: lldb-commits Differential Revision: http://reviews.llvm.

Re: [Lldb-commits] [PATCH] D11967: Export snprintf to avoid linking error with liblldb on Windows.

ovyalov accepted this revision. ovyalov added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D11967 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

Re: [Lldb-commits] [PATCH] D11967: Export snprintf to avoid linking error with liblldb on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rL244710: Export snprintf to avoid linking error with liblldb on Windows. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D11967?vs=31884&id=31896#toc Repository: rL LLVM http:

Re: [Lldb-commits] [PATCH] D11843: Make dosep output status by overwriting the same line.

Sorry, will get to this first thing tomorroow On Tue, Aug 11, 2015 at 4:47 PM Chaoren Lin wrote: > chaoren added a comment. > > Ping? > > > http://reviews.llvm.org/D11843 > > > > ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.ll

Re: [Lldb-commits] [PATCH] D11967: Export snprintf to avoid linking error with liblldb on Windows.

You need to use LIBLLDB_API instead of __declspec(export). Otherwise someone linking against liblldb and trying to call this won't work correctly. Check the annotation given to the classes in the SB headers for the exact name of the macro. On Tue, Aug 11, 2015 at 6:23 PM Chaoren Lin wrote: > T

Re: [Lldb-commits] [PATCH] D11967: Export snprintf to avoid linking error with liblldb on Windows.

chaoren added a subscriber: chaoren. chaoren added a comment. Sorry! I'll fix this as soon as I get home. I have a question though, isn't this only a problem if whatever's linking against lldb includes this header? This isn't in the API, so that shouldn't happen. I also don't know if it's correct

Re: [Lldb-commits] [PATCH] D11962: Mark TestCModules as XFAIL on OSX

chying accepted this revision. chying added a comment. This revision is now accepted and ready to land. Sorry I mean in the code, like, @expectedFailureDarwin('llvm.org/pr24302') Otherwise, looks good to me. http://reviews.llvm.org/D11962 ___ lldb-c

Re: [Lldb-commits] [PATCH] D11967: Export snprintf to avoid linking error with liblldb on Windows.

True that it only needs to be included if it's part of the api. Are we sure it can't happen through a transitive include? As long as the user of liblldb doesn't see the declaration it shouldn't be a problem. On Tue, Aug 11, 2015 at 6:54 PM Chaoren Lin via lldb-commits < lldb-commits@lists.llvm.o

Re: [Lldb-commits] [PATCH] D11967: Export snprintf to avoid linking error with liblldb on Windows.

> Are we sure it can't happen through a transitive include? In that case, whatever included it is breaking the API Coding rules . On Tue, Aug 11, 2015 at 7:12 PM, Zachary Turner wrote: > True that it only needs to be included if it's part of the ap

[Lldb-commits] [lldb] r244716 - Have debugserver send the OS version string plus

Author: jmolenda Date: Tue Aug 11 22:27:33 2015 New Revision: 244716 URL: http://llvm.org/viewvc/llvm-project?rev=244716&view=rev Log: Have debugserver send the OS version string plus major, minor, and patchlevel in the qHostInfo reply. Document that qHostInfo may report major/minor/patch separa

Re: [Lldb-commits] [PATCH] D11672: [MIPS] Handle false positives for MIPS hardware watchpoints

jaydeep added a comment. Hi jingham, Could you please review this? Thanks. Repository: rL LLVM http://reviews.llvm.org/D11672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D11971: Remove DNBConfig.h

brucem created this revision. brucem added reviewers: clayborg, jasonmolenda. brucem added a subscriber: lldb-commits. This was no longer needed and hasn't been needed since r143244 in 2011. This removes everything associated with generating or using it. http://reviews.llvm.org/D11971 Files: