Re: [Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

2018-12-14 Thread Zachary Turner via lldb-commits
If you do decide to unsilence it, then just mark those skip and file bugs for them being flaky. On Fri, Dec 14, 2018 at 11:11 AM Stella Stamenova wrote: > An unexpected pass makes the bot red. I might un-silence it despite the > couple of issues left anyway, but it’s something to be aware of. >

Re: [Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

2018-12-14 Thread Stella Stamenova via lldb-commits
An unexpected pass makes the bot red. I might un-silence it despite the couple of issues left anyway, but it’s something to be aware of. Thanks, -Stella From: Zachary Turner Sent: Friday, December 14, 2018 11:04 AM To: Stella Stamenova Cc: reviews+d55575+public+5ea6161324294...@reviews.llvm.or

Re: [Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

2018-12-14 Thread Zachary Turner via lldb-commits
An unexpected pass won't make the bot red will it? If so, one option is to mark them skip, just to make sure we can get the bot turned on as quickly as possible. On Fri, Dec 14, 2018 at 10:56 AM Stella Stamenova wrote: > It’s actually not green – the unexpected passes are counted as a failure.

Re: [Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

2018-12-14 Thread Stella Stamenova via lldb-commits
It’s actually not green – the unexpected passes are counted as a failure. With Pavel’s change to add the gcc builder, most of those can now be enabled, so I am going to do that today, but there’s still a couple that are “unexpectedly passing” when they are in fact failing. We’ll need to fix that

Re: [Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

2018-12-14 Thread Zachary Turner via lldb-commits
I've fixed it. It looks like the bot should be green again once this test starts passing. Can you make it noisy and starting to send emails now? On Fri, Dec 14, 2018 at 10:42 AM Zachary Turner wrote: > Ahh, that seems easy enough to fix. Just need to change the 7 to a > {{.*}}. Since we're a

Re: [Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

2018-12-14 Thread Zachary Turner via lldb-commits
Ahh, that seems easy enough to fix. Just need to change the 7 to a {{.*}}. Since we're actually compiling and running a process on the buildbot, different versions of Windows will affect this. On Fri, Dec 14, 2018 at 10:39 AM Stella Stamenova via Phabricator < revi...@reviews.llvm.org> wrote: >

Re: [Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

2018-12-14 Thread Zachary Turner via lldb-commits
I can't access the buildbot right now, it's just timing out and never loading the webpage. If you have it open and can paste the output here I can try to figure out what's wrong, otherwise I'll have to wait for it to become available again. On Fri, Dec 14, 2018 at 10:31 AM Stella Stamenova via Ph