Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

> On Oct 19, 2018, at 5:37 PM, Vedant Kumar wrote: > > Hi Stella, > > The logs are really helpful, thanks. This part is unexpected: > > python Finding frames between main and sink(), retn-pc=0x4005b8 > python GetCallEdges: Attempting to parse call site info for main > pyth

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

Hi Stella, The logs are really helpful, thanks. This part is unexpected: python Finding frames between main and sink(), retn-pc=0x4005b8 python GetCallEdges: Attempting to parse call site info for main python CollectCallEdges: Found call site info in main python

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

Hey Vedant, I’ve attached the logs from Linux. Most of the tests now pass on Windows with the exception of TestSteppingOutWithArtificialFrames and TestTailCallFrameSBAPI. Both of these attempt to get a specific frame by calling GetFrameAtIndex which only works partially on Windows right now. I

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

Once we’re no longer using DIA this should be a lot easier to control on our side On Tue, Oct 16, 2018 at 11:17 AM Vedant Kumar wrote: > > > On Oct 16, 2018, at 10:59 AM, Stella Stamenova > wrote: > > The windows error is because the names are different, as you expected: > > AssertionError: 'voi

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

> On Oct 16, 2018, at 10:59 AM, Stella Stamenova wrote: > > The windows error is because the names are different, as you expected: > > AssertionError: 'void sink(void)' != 'sink()' > > You can probably update the test to look for a different name on Windows > (though if I recall correctly,

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

The windows error is because the names are different, as you expected: AssertionError: 'void sink(void)' != 'sink()' You can probably update the test to look for a different name on Windows (though if I recall correctly, different versions of the DIA sdk provide different detail on the names, s

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

> On Oct 15, 2018, at 4:46 PM, Frédéric Riss wrote: > > > >> On Oct 15, 2018, at 4:40 PM, Vedant Kumar > > wrote: >> >> >> >>> On Oct 15, 2018, at 3:47 PM, Stella Stamenova via Phabricator >>> mailto:revi...@reviews.llvm.org>> wrote: >>> >>> stella.stamenova added

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

> On Oct 15, 2018, at 4:40 PM, Vedant Kumar wrote: > > > >> On Oct 15, 2018, at 3:47 PM, Stella Stamenova via Phabricator >> wrote: >> >> stella.stamenova added a comment. >> >> In https://reviews.llvm.org/D50478#1262717, @vsk wrote: >> >>> In https://reviews.llvm.org/D50478#1262710, @st

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

> On Oct 15, 2018, at 3:47 PM, Stella Stamenova via Phabricator > wrote: > > stella.stamenova added a comment. > > In https://reviews.llvm.org/D50478#1262717, @vsk wrote: > >> In https://reviews.llvm.org/D50478#1262710, @stella.stamenova wrote: >> >>> Unfortunately, the bots are broken beca

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

https://reviews.llvm.org/D53002 Is the thread I'm referring to. On Thu, Oct 11, 2018 at 2:59 PM Zachary Turner via Phabricator < revi...@reviews.llvm.org> wrote: > zturner added a subscriber: vsk. > zturner added a comment. > > See the other email thread. The bots have been broken since Septemb

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

See the other email thread. The bots have been broken since September, all of them complain about missing FileCheck executable On Thu, Oct 11, 2018 at 2:58 PM Vedant Kumar via Phabricator < revi...@reviews.llvm.org> wrote: > vsk added a comment. > > In https://reviews.llvm.org/D50478#1262710, @s