Re: [Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

I have some ideas for how to run the different variants as separate tests, but I'll save it for the next RFC :) On Wed, Apr 4, 2018 at 10:24 AM Jonas Devlieghere wrote: > > > On Apr 4, 2018, at 5:12 PM, Adrian Prantl wrote: > > > > > > > >> On Apr 4, 2018, at 9:07 AM, Zachary Turner wrote: > >

Re: [Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

> On Apr 4, 2018, at 5:12 PM, Adrian Prantl wrote: > > > >> On Apr 4, 2018, at 9:07 AM, Zachary Turner wrote: >> >> Sure, but getting lit to run one file at a time is a nice incremental step >> towards that and can make both patches easier to review. > > Agreed, I just want to make sure th

Re: [Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

> On Apr 4, 2018, at 9:07 AM, Zachary Turner wrote: > > Sure, but getting lit to run one file at a time is a nice incremental step > towards that and can make both patches easier to review. Agreed, I just want to make sure that we are all on the same page as to which direction we want to evo

Re: [Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

Sure, but getting lit to run one file at a time is a nice incremental step towards that and can make both patches easier to review. On Wed, Apr 4, 2018 at 9:02 AM Adrian Prantl wrote: > > On Apr 4, 2018, at 8:53 AM, Pavel Labath wrote: > > > > On Wed, 4 Apr 2018 at 16:47, Zachary Turner wrote:

Re: [Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

> On Apr 4, 2018, at 8:53 AM, Pavel Labath wrote: > > > > On Wed, 4 Apr 2018 at 16:47, Zachary Turner > wrote: > > On Wed, Apr 4, 2018 at 8:11 AM Jonas Devlieghere via Phabricator > mailto:revi...@reviews.llvm.org>> wrote: > JDevlieghere added a comment. > > In

Re: [Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

On Wed, 4 Apr 2018 at 16:47, Zachary Turner wrote: > > On Wed, Apr 4, 2018 at 8:11 AM Jonas Devlieghere via Phabricator < > revi...@reviews.llvm.org> wrote: > >> JDevlieghere added a comment. >> >> In https://reviews.llvm.org/D45215#1056917, @zturner wrote: >> >> > I haven’t had time to look at t

Re: [Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

On Wed, Apr 4, 2018 at 8:11 AM Jonas Devlieghere via Phabricator < revi...@reviews.llvm.org> wrote: > JDevlieghere added a comment. > > In https://reviews.llvm.org/D45215#1056917, @zturner wrote: > > > I haven’t had time to look at this in detail yet, but when I originally > had > > this idea I t

Re: [Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

I haven’t had time to look at this in detail yet, but when I originally had this idea I thought we would use lit’s discovery mechanism to find all .py files, and then invoke them using dotest.py in single process mode with a path to a specific file. Why do we need run lines? On Wed, Apr 4, 2018 at