This revision was automatically updated to reflect the committed changes.
Closed by commit rL265349: Implement `target modules dump objfile` (authored by
amccarth).
Changed prior to commit:
http://reviews.llvm.org/D18464?vs=52624&id=52626#toc
Repository:
rL LLVM
http://reviews.llvm.org/D184
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks for making all the changes.
http://reviews.llvm.org/D18464
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:
amccarth updated this revision to Diff 52624.
amccarth added a comment.
Removed the per-file header from the common code and make the
ObjectFileELF::Dump print its own header like the others.
http://reviews.llvm.org/D18464
Files:
source/Commands/CommandObjectTarget.cpp
source/Plugins/Objec
amccarth added inline comments.
Comment at: source/Commands/CommandObjectTarget.cpp:1568
@@ +1567,3 @@
+ObjectFile *objfile = module->GetObjectFile();
+strm.Printf("'%s':\n", objfile->GetFileSpec().GetCString());
+strm.IndentMore();
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: source/Commands/CommandObjectTarget.cpp:1568
@@ +1567,3 @@
+ObjectFile *objfile = module->GetObjectFile();
+
amccarth updated this revision to Diff 52618.
amccarth added a comment.
Removed the "headers for" string, but kept the name of the file, as not all of
the ObjectFile::Dump implementations (e.g., ELF) print the file name.
http://reviews.llvm.org/D18464
Files:
source/Commands/CommandObjectTarg
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Close, we just need to remove the "Headers for" string. See inlined comment.
Comment at: source/Commands/CommandObjectTarget.cpp:1568
@@ +1567,3 @@
+
amccarth updated this revision to Diff 52588.
amccarth added a comment.
OK, this now dumps headers for the ObjectFiles of the modules rather than the
modules themselves, using `target modules dump objfile` as suggested.
My only concern here is that the SB API has a module dump, but no object fil
clayborg added a comment.
In http://reviews.llvm.org/D18464#389612, @zturner wrote:
> FWIW I believe we do actually want many of the PE headers, although I have to
> say I don't like the format of the output.It seems like we could break
> this up into smaller chunks like section headers, pe
zturner added a subscriber: zturner.
zturner added a comment.
FWIW I believe we do actually want many of the PE headers, although I have to
say I don't like the format of the output.It seems like we could break this
up into smaller chunks like section headers, pe headers, binary headers, deb
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I would limit this scope to dumping ObjectFiles since that seems to be what you
want. So this command should probably change from:
(lldb) target modules dump headers
to:
(l
amccarth added a comment.
Ping.
http://reviews.llvm.org/D18464
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amccarth added a comment.
Literally:
Dumping headers for 1 module(s).
Headers for 'd:\src\fizzbuzz\a.exe':
Module d:\src\fizzbuzz\a.exe
04189230: ObjectFilePECOFF, file = 'd:\src\fizzbuzz\a.exe', arch = i386
SectID Type File Address
amccarth added a comment.
I'm using it with PE files (Windows), so I see
A table of where the debug info exists
MSDOS Header
COFF Header
PECOFF header
a table of section headers (.rdata, .bss, etc.).
The section headers table is redundant with `target modules dump sections`, but
I don't see ano
clayborg added a comment.
What does some sample output of this look like? I can't remember what
module->Dump(...) does.
http://reviews.llvm.org/D18464
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
15 matches
Mail list logo
