clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

I would limit this scope to dumping ObjectFiles since that seems to be what you 
want. So this command should probably change from:

  (lldb) target modules dump headers

to:

  (lldb) target modules dump objfile

Then CommandObjectTargetModulesDump would just get the ObjectFile from any 
modules in the arguments and call ObjectFile::Dump(...) instead of 
module->Dump() since module->Dump() dumps the module itself, and the object 
file and the symbol file. We already have a "target modules dump symfile", so 
"target modules dump objfile" makes more sense here.


http://reviews.llvm.org/D18464



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to