This revision was automatically updated to reflect the committed changes.
Closed by commit rL262255: Fix TestInlines.py on Windows (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D17650?vs=49208&id=49409#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17650
Files:
amccarth added a comment.
I'm going to interpret silence as consent. This review was mostly FYI.
http://reviews.llvm.org/D17650
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added inline comments.
Comment at: packages/Python/lldbsuite/test/lang/cpp/inlines/inlines.h:1-4
@@ +1,4 @@
+int inner_inline (int inner_input, int mod_value);
+int outer_inline (int outer_input);
+int not_inlined_2 (int input);
+int not_inlined_1 (int input);
zturner added a comment.
I don't know where we draw the line between `test/lang` and
`test/functionalities` but I feel like the purpose of this test is just to make
sure LLDB has the general ability to handle setting breakpoints on inline call
sites. With that in mind, it make more sense to ha
