tfiala added a comment.
Can this be closed out?
http://reviews.llvm.org/D15318
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
> I just got a clean build
And by that, I mean a clean test run.
On Tue, Dec 8, 2015 at 8:17 AM, Todd Fiala wrote:
> Okay cool.
>
> I just got a clean build here on a local OS X machine. Thanks for
> addressing that, Pavel! I looked at the diffs and they made sense vs. the
> behavior I saw la
Okay cool.
I just got a clean build here on a local OS X machine. Thanks for
addressing that, Pavel! I looked at the diffs and they made sense vs. the
behavior I saw last night.
On Tue, Dec 8, 2015 at 7:58 AM, Pavel Labath wrote:
> I'm still waiting for the buildbots to finish, but yeah, it's
I'm still waiting for the buildbots to finish, but yeah, it's looking
good so far.
On 8 December 2015 at 15:51, Todd Fiala via lldb-commits
wrote:
> I think Pavel cleared this up. I'm checking now. If there's anything
> remaining, I'll resolve it after I see what happens.
>
> On Mon, Dec 7, 201
tfiala added a subscriber: tfiala.
tfiala added a comment.
I think Pavel cleared this up. I'm checking now. If there's anything
remaining, I'll resolve it after I see what happens.
http://reviews.llvm.org/D15318
___
lldb-commits mailing list
lldb-
I think Pavel cleared this up. I'm checking now. If there's anything
remaining, I'll resolve it after I see what happens.
On Mon, Dec 7, 2015 at 9:59 PM, Zachary Turner wrote:
> zturner added a comment.
>
> To be clear, we explicitly set the LLDB_TEST environment variable as part
> of initiali
To be clear, we explicitly set the LLDB_TEST environment variable as part
of initialization, and it's now trying to read the value of the environment
variable before it's been set. At least I think anyway, I'm going off of
memory, don't have code in front of me.
On Mon, Dec 7, 2015 at 9:58 PM Zac
zturner added a comment.
To be clear, we explicitly set the LLDB_TEST environment variable as part
of initialization, and it's now trying to read the value of the environment
variable before it's been set. At least I think anyway, I'm going off of
memory, don't have code in front of me.
http://
zturner added a subscriber: zturner.
zturner added a comment.
Hmm, yea that code path only gets run on OSX. I think the problem is that
I changed the order that happens in. It now happens right when you import
`configuration` for the first time, and it used to happen explicitly in
`main()`. So
Hmm, yea that code path only gets run on OSX. I think the problem is that
I changed the order that happens in. It now happens right when you import
`configuration` for the first time, and it used to happen explicitly in
`main()`. So maybe just make that function public, and call in the same
plac
tfiala added a comment.
Here's what I'm seeing so far (as of r254983) when running on OS X:
$ test/dotest.py --results-formatter
lldbsuite.test.basic_results_formatter.BasicResultsFormatter
Traceback (most recent call last):
File "test/dotest.py", line 6, in
import lldbsuite.test
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Yep, sounds good. I saw it go in. I'll do a couple runs here but I'm sure
we'll fix up anything if something breaks. I much prefer to get it in :-)
http://reviews.llvm.org/D15318
__
zturner added a comment.
This is mostly mechanical, and since it looks like we have 2 people making big
changes at the same time I'll go ahead and put this in so we don't step on each
others' toes. But feel free to revert if this breaks anything. If you do
experience any errors, it is most li
13 matches
Mail list logo
