Re: [Lldb-commits] [PATCH] D15065: Define new builder_netbsd

2015-12-05 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL254853: Define new builder_netbsd (authored by kamil). Changed prior to commit: http://reviews.llvm.org/D15065?vs=41363&id=41991#toc Repository: rL LLVM http://reviews.llvm.org/D15065 Files: lldb/

Re: [Lldb-commits] [PATCH] D15065: Define new builder_netbsd

2015-12-03 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. I'm not sure exactly how these were divided up initially, but I'd suspect a substantial amount of it is similar along the vein of POSIX vs. non-POSIX, probably with some diffs for OS X support

Re: [Lldb-commits] [PATCH] D15065: Define new builder_netbsd

2015-11-29 Thread Zachary Turner via lldb-commits
Ok, if there's already precedent for duplicating the files then go ahead and follow the pattern. Although I'm not sure I'm crazy about duplicating files on the off chance that something might be different someday. In any case, lgtm. On Sun, Nov 29, 2015 at 8:01 PM Kamil Rytarowski wrote: > kry

Re: [Lldb-commits] [PATCH] D15065: Define new builder_netbsd

2015-11-29 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In http://reviews.llvm.org/D15065#298279, @zturner wrote: > This doesn't look substantially different than builder_freebsd. Assuming > there is no practical difference, how about just using that for both > freebsd and netbsd? The linux2, win32 and freebsd targets

Re: [Lldb-commits] [PATCH] D15065: Define new builder_netbsd

2015-11-29 Thread Zachary Turner via lldb-commits
zturner added a subscriber: zturner. zturner added a comment. This doesn't look substantially different than builder_freebsd. Assuming there is no practical difference, how about just using that for both freebsd and netbsd? Repository: rL LLVM http://reviews.llvm.org/D15065 __

Re: [Lldb-commits] [PATCH] D15065: Define new builder_netbsd

2015-11-29 Thread Zachary Turner via lldb-commits
This doesn't look substantially different than builder_freebsd. Assuming there is no practical difference, how about just using that for both freebsd and netbsd? On Sun, Nov 29, 2015 at 6:17 PM Kamil Rytarowski via lldb-commits < lldb-commits@lists.llvm.org> wrote: > krytarowski created this rev