Re: [Lldb-commits] [lldb] r348319 - [build.py] Disable tests on non-Windows.

2018-12-05 Thread Zachary Turner via lldb-commits
It should be, but I haven’t tested any of the non Windows paths at all yet, so while that seems like a logical fix, there’s probably something else that would break, like not having a clang-cl environment. So the thinking was to just disable them until i can implement and test support for other pla

Re: [Lldb-commits] [lldb] r348319 - [build.py] Disable tests on non-Windows.

2018-12-05 Thread Pavel Labath via lldb-commits
On 05/12/2018 16:03, Zachary Turner wrote: If you can commit the same fix I did for the other two that would be great, otherwise I’ll get to it when i get into the office in ~2 hours The thing is, I'm not sure if that's the right fix here. I mean, this script should be able to compile with cl

Re: [Lldb-commits] [lldb] r348319 - [build.py] Disable tests on non-Windows.

2018-12-05 Thread Zachary Turner via lldb-commits
If you can commit the same fix I did for the other two that would be great, otherwise I’ll get to it when i get into the office in ~2 hours On Wed, Dec 5, 2018 at 3:03 AM Pavel Labath wrote: > On 05/12/2018 00:56, Zachary Turner via lldb-commits wrote: > > Author: zturner > > Date: Tue Dec 4 15:

Re: [Lldb-commits] [lldb] r348319 - [build.py] Disable tests on non-Windows.

2018-12-05 Thread Pavel Labath via lldb-commits
On 05/12/2018 00:56, Zachary Turner via lldb-commits wrote: Author: zturner Date: Tue Dec 4 15:56:25 2018 New Revision: 348319 URL: http://llvm.org/viewvc/llvm-project?rev=348319&view=rev Log: [build.py] Disable tests on non-Windows. This won't work until we get the GCC / clang builder impleme

[Lldb-commits] [lldb] r348319 - [build.py] Disable tests on non-Windows.

2018-12-04 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Dec 4 15:56:25 2018 New Revision: 348319 URL: http://llvm.org/viewvc/llvm-project?rev=348319&view=rev Log: [build.py] Disable tests on non-Windows. This won't work until we get the GCC / clang builder implemented. Modified: lldb/trunk/lit/BuildScript/modes.test