It should be, but I haven’t tested any of the non Windows paths at all yet, so while that seems like a logical fix, there’s probably something else that would break, like not having a clang-cl environment. So the thinking was to just disable them until i can implement and test support for other platforms On Wed, Dec 5, 2018 at 7:35 AM Pavel Labath <pa...@labath.sk> wrote:
> On 05/12/2018 16:03, Zachary Turner wrote: > > If you can commit the same fix I did for the other two that would be > > great, otherwise I’ll get to it when i get into the office in ~2 hours > > > The thing is, I'm not sure if that's the right fix here. I mean, this > script should be able to compile with clang-cl on linux, right? > > The easiest way to fix this would be to check env is not None before > printing it out, but it wasn't clear to me whether you intended for it > to be (possibly) None at this point in the code, so I figured its best > to let you figure that out. >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
