Re: [Lldb-commits] [lldb] r330314 - Attempt to fix TestMiniDump on windows

2018-04-20 Thread Pavel Labath via lldb-commits
On Thu, 19 Apr 2018 at 18:11, Leonard Mosescu wrote: > The mix of backward and forward slashes doesn't impact my current project but it would be nice to have a consistent path syntax (both within a single path and also cross platforms). >> Leonard, is it reasonable to assume that all paths in t

Re: [Lldb-commits] [lldb] r330314 - Attempt to fix TestMiniDump on windows

2018-04-19 Thread Leonard Mosescu via lldb-commits
The mix of backward and forward slashes doesn't impact my current project but it would be nice to have a consistent path syntax (both within a single path and also cross platforms). > Leonard, is it reasonable to assume that all paths in the minidumps will be > absolute (and thus resolving is poi

Re: [Lldb-commits] [lldb] r330314 - Attempt to fix TestMiniDump on windows

2018-04-19 Thread Pavel Labath via lldb-commits
Yes, I noticed that as well, but I did not want to change it, as it wasn't related to the problem I was trying to fix. I agree that not resolving the path sounds like a better idea. Leonard, is it reasonable to assume that all paths in the minidumps will be absolute (and thus resolving is pointles

Re: [Lldb-commits] [lldb] r330314 - Attempt to fix TestMiniDump on windows

2018-04-19 Thread Greg Clayton via lldb-commits
Any reason we are trying to resolve the path with the 2nd true argument to FileSpec? If you still want to resolve the path, I would suggest checking if GetArchitecture() is compatible with any host architectures before passing true. > On Apr 19, 2018, at 2:38 AM, Pavel Labath via lldb-commits

[Lldb-commits] [lldb] r330314 - Attempt to fix TestMiniDump on windows

2018-04-19 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Apr 19 02:38:42 2018 New Revision: 330314 URL: http://llvm.org/viewvc/llvm-project?rev=330314&view=rev Log: Attempt to fix TestMiniDump on windows It was failing because the modules names were coming out as C:\Windows\System32/MSVCP120D.dll (last separator is a forward sl