Re: [Lldb-commits] [lldb] r252381 - Python 3 - Don't use unbuffered I/O in text mode.

2015-11-09 Thread Todd Fiala via lldb-commits
Sounds good. Not super critical, but I'd definitely rather it stay unbuffered where possible. On Mon, Nov 9, 2015 at 1:10 PM, Zachary Turner wrote: > Hmm, ok. I'll loop back around to this when I get some cycles. Still > working on Python 3 stuff so I don't think this will fall off my radar >

Re: [Lldb-commits] [lldb] r252381 - Python 3 - Don't use unbuffered I/O in text mode.

2015-11-09 Thread Zachary Turner via lldb-commits
Hmm, ok. I'll loop back around to this when I get some cycles. Still working on Python 3 stuff so I don't think this will fall off my radar On Mon, Nov 9, 2015 at 12:56 PM Todd Fiala wrote: > The reason you probably want this unbuffered is for cases where you > crash. When a dotest.py process

Re: [Lldb-commits] [lldb] r252381 - Python 3 - Don't use unbuffered I/O in text mode.

2015-11-09 Thread Todd Fiala via lldb-commits
The reason you probably want this unbuffered is for cases where you crash. When a dotest.py process crashes, the buffered content won't necessarily get flushed. So the session file may or may not contain the last thing that happened in that case. I think we want it unbuffered where we can. -Todd

[Lldb-commits] [lldb] r252381 - Python 3 - Don't use unbuffered I/O in text mode.

2015-11-06 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Nov 6 19:08:15 2015 New Revision: 252381 URL: http://llvm.org/viewvc/llvm-project?rev=252381&view=rev Log: Python 3 - Don't use unbuffered I/O in text mode. This is unsupported in Python 3. This could also have been fixed by using "wb" instead of "w", but it doesn't se