Author: zturner Date: Fri Nov 6 19:08:15 2015 New Revision: 252381 URL: http://llvm.org/viewvc/llvm-project?rev=252381&view=rev Log: Python 3 - Don't use unbuffered I/O in text mode.
This is unsupported in Python 3. This could also have been fixed by using "wb" instead of "w", but it doesn't seem like writing the session log absolutely *needs* to be unbuffered. Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=252381&r1=252380&r2=252381&view=diff ============================================================================== --- lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py (original) +++ lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Fri Nov 6 19:08:15 2015 @@ -1413,8 +1413,8 @@ class Base(unittest2.TestCase): self.log_basename = self.getLogBasenameForCurrentTest() session_file = "{}.log".format(self.log_basename) - unbuffered = 0 # 0 is the constant for unbuffered - self.session = open(session_file, "w", unbuffered) + # Python 3 doesn't support unbuffered I/O in text mode. Open buffered. + self.session = open(session_file, "w") # Optimistically set __errored__, __failed__, __expected__ to False # initially. If the test errored/failed, the session info _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits