DavidSpickett wrote:
I suspect a missing unsupported annotation:
```
UNSUPPORTED: LLDB
(/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/bin/clang-arm) ::
test_FakeAttachedRunInTerminalLauncherAndCheckEnvironment
(TestDAP_runInTerminal.TestDAP_runInTerminal) (skipping due to the following
par
antmox wrote:
Hi! Looks like this patch broke lldb-arm-ubuntu bot :
https://lab.llvm.org/buildbot/#/builders/18/builds/5041
> Failed Tests (1):
> lldb-api :: tools/lldb-dap/runInTerminal/TestDAP_runInTerminal.py
Could you please look at this ?
https://github.com/llvm/llvm-project/pull/106919
vogelsgesang wrote:
see https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access for
instructions
https://github.com/llvm/llvm-project/pull/106919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
walter-erquinigo wrote:
@Da-Viper , you should request commit access!
https://github.com/llvm/llvm-project/pull/106919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/106919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Da-Viper wrote:
> @Da-Viper do you have the necessary permissions to merge PRs by yourself? Or
> do you need somebody to merge this on your behalf?
I don't have permissions
https://github.com/llvm/llvm-project/pull/106919
___
lldb-commits mailing list
vogelsgesang wrote:
@Da-Viper do you have the necessary permissions to merge PRs by yourself? Or do
you need somebody to merge this on your behalf?
https://github.com/llvm/llvm-project/pull/106919
___
lldb-commits mailing list
lldb-commits@lists.llvm.
https://github.com/walter-erquinigo approved this pull request.
nice!
https://github.com/llvm/llvm-project/pull/106919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Da-Viper wrote:
@walter-erquinigo Is there anything missing for this pull request ?
https://github.com/llvm/llvm-project/pull/106919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106919
>From d2bddca1753b4c960895f51d7eb80b6efa7dc986 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 17:26:11 +0100
Subject: [PATCH 1/9] [lldb-dap] Make environment option an object
---
.../tools/l
Da-Viper wrote:
> Nice improvement. Don't forget to write a test
Will do this evening
https://github.com/llvm/llvm-project/pull/106919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/106919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106919
>From d2bddca1753b4c960895f51d7eb80b6efa7dc986 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 17:26:11 +0100
Subject: [PATCH 1/8] [lldb-dap] Make environment option an object
---
.../tools/l
@@ -175,9 +175,10 @@
"type": "array",
"description": "Additional environment variables to set
when launching the program. E.g. `[\"FOO=1\", \"BAR\"]`",
"items": {
- "type": "string"
+
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106919
>From d2bddca1753b4c960895f51d7eb80b6efa7dc986 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 17:26:11 +0100
Subject: [PATCH 1/7] [lldb-dap] Make environment option an object
---
.../tools/l
https://github.com/walter-erquinigo requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/106919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1370,13 +1395,16 @@ CreateRunInTerminalReverseRequest(const
llvm::json::Object &launch_request,
if (!cwd.empty())
run_in_terminal_args.try_emplace("cwd", cwd);
- // We need to convert the input list of environments variables into a
- // dictionary
- std::vector e
https://github.com/JDevlieghere approved this pull request.
LGTM. I like having both options. That way we don't break existing use cases
while also supporting the more intuitive way of expressing this as a dictionary.
https://github.com/llvm/llvm-project/pull/106919
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106919
>From d2bddca1753b4c960895f51d7eb80b6efa7dc986 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 17:26:11 +0100
Subject: [PATCH 1/5] [lldb-dap] Make environment option an object
---
.../tools/l
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106919
>From d2bddca1753b4c960895f51d7eb80b6efa7dc986 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 17:26:11 +0100
Subject: [PATCH 1/4] [lldb-dap] Make environment option an object
---
.../tools/l
Da-Viper wrote:
> Can we modify this patch to support both formats? It should be easy to see if
> "env" is a dictionary, and if it is, use your new code. If it is an array,
> use the old parsing code. I would like to make sure this change doesn't break
> anyone that has existing launch configu
clayborg wrote:
Can we modify this patch to support both formats? It should be easy to see if
"env" is a dictionary, and if it is, use your new code. If it is an array, use
the old parsing code. I would like to make sure this change doesn't break
anyone that has existing launch configurations.
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106919
>From d2bddca1753b4c960895f51d7eb80b6efa7dc986 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 17:26:11 +0100
Subject: [PATCH 1/3] [lldb-dap] Make environment option an object
---
.../tools/l
vogelsgesang wrote:
> I am not sure if it possible to use a dict for sourceMaps since a source can
> map to multiple destination see test
Interestingly, CodeLLDB also uses an object, see
https://github.com/vadimcn/codelldb/blob/v1.10.0/MANUAL.md#source-path-remapping.
Probably they just don't
@@ -1831,7 +1831,13 @@ lldb::SBError LaunchProcess(const llvm::json::Object
&request) {
launch_info.SetArguments(MakeArgv(args).data(), true);
// Pass any environment variables along that the user specified.
- auto envs = GetStrings(arguments, "env");
+ auto envMap =
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106919
>From d2bddca1753b4c960895f51d7eb80b6efa7dc986 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 17:26:11 +0100
Subject: [PATCH 1/2] [lldb-dap] Make environment option an object
---
.../tools/l
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
87d904871fe96a01dfa1f254ca2a7639de67960c...d2bddca1753b4c960895f51d7eb80b6efa7dc986
lldb/
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106919
>From d2bddca1753b4c960895f51d7eb80b6efa7dc986 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 17:26:11 +0100
Subject: [PATCH] [lldb-dap] Make environment option an object
---
.../tools/lldb-
Da-Viper wrote:
@vogelsgesang I am not sure if it possible to use a dict for sourceMaps since a
source can map to multiple destination see test
https://github.com/llvm/llvm-project/blob/a9c71d36655bd188521c74ce7834983e8c2a86cc/lldb/test/API/tools/lldb-dap/breakpoint/TestDAP_setBreakpoints.py#L
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106919
>From 539d44a522e9e0563079ddbefb59e1b4b4caaca6 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 17:26:11 +0100
Subject: [PATCH 1/5] [lldb-dap] Make environment option an object
---
lldb/tools/
@@ -151,6 +152,26 @@ bool ObjectContainsKey(const llvm::json::Object &obj,
llvm::StringRef key);
/// strings, numbers or booleans.
std::vector GetStrings(const llvm::json::Object *obj,
llvm::StringRef key);
+/// Extract an object of key
@@ -194,9 +199,14 @@
"description": "Specify a source path to remap \"./\" to allow
full paths to be used when setting breakpoints in binaries that have relative
source paths."
},
"sourceMap": {
-"type": "array",
-
@@ -151,6 +152,26 @@ bool ObjectContainsKey(const llvm::json::Object &obj,
llvm::StringRef key);
/// strings, numbers or booleans.
std::vector GetStrings(const llvm::json::Object *obj,
llvm::StringRef key);
+/// Extract an object of key
@@ -299,9 +309,14 @@
"description": "Specify a source path to remap \"./\" to allow
full paths to be used when setting breakpoints in binaries that have relative
source paths."
},
"sourceMap": {
-"type": "array",
-
@@ -160,9 +160,14 @@
"default": "${workspaceRoot}"
},
"env": {
-"type": "array",
-"description": "Additional environment variables to set when
launching the program. This is an array of strings that co
@@ -151,6 +152,26 @@ bool ObjectContainsKey(const llvm::json::Object &obj,
llvm::StringRef key);
/// strings, numbers or booleans.
std::vector GetStrings(const llvm::json::Object *obj,
llvm::StringRef key);
+/// Extract an object of key
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106919
>From 539d44a522e9e0563079ddbefb59e1b4b4caaca6 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 17:26:11 +0100
Subject: [PATCH 1/4] [lldb-dap] Make environment option an object
---
lldb/tools/
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ec588175370a32dd40df86dc4672e65926817f25
864225ea1180f7e1098b6c64d1d29a617961583c --e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (Da-Viper)
Changes
Fixes #95137
---
Full diff: https://github.com/llvm/llvm-project/pull/106919.diff
5 Files Affected:
- (modified) lldb/tools/lldb-dap/JSONUtils.cpp (+33-6)
- (modified) lldb/tools/lldb-dap/JSONUtils.h (+21)
- (mo
https://github.com/Da-Viper created
https://github.com/llvm/llvm-project/pull/106919
Fixes #95137
>From 539d44a522e9e0563079ddbefb59e1b4b4caaca6 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 17:26:11 +0100
Subject: [PATCH 1/3] [lldb-dap] Make environment option an object
--
40 matches
Mail list logo
