================ @@ -1370,13 +1395,16 @@ CreateRunInTerminalReverseRequest(const llvm::json::Object &launch_request, if (!cwd.empty()) run_in_terminal_args.try_emplace("cwd", cwd); - // We need to convert the input list of environments variables into a - // dictionary - std::vector<std::string> envs = GetStrings(launch_request_arguments, "env"); + std::unordered_map<std::string, std::string> envMap = + GetStringMap(*launch_request_arguments, "env"); ---------------- walter-erquinigo wrote:
You are completely dropping for support for an array-based env list, and we can't do this because we'd be breaking tons of launch.json configs. You need to effectively support both formats: a map and an array. Convert `GetStringMap` into `GetEnv` that takes into account both formats. https://github.com/llvm/llvm-project/pull/106919 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits