https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/71457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/71457
>From 0a4b349d6299db6b2a0a6709c40d15b1a4a0f62a Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 8 Nov 2023 16:51:53 -0800
Subject: [PATCH] [lldb] Add Checksum to FileSpec
Store a Checksum in File
@@ -420,13 +428,17 @@ class FileSpec {
/// The lifetime of the StringRefs is tied to the lifetime of the FileSpec.
std::vector GetComponents() const;
+ /// Return the checksum for this FileSpec or all zeros if there is none.
+ const Checksum &GetChecksum() const { retu
clayborg wrote:
> > So I debugged lldb with lldb and adding a counter into the FileSpec
> > constructor and came up a max of 721833 files after trying to set a
> > breakpoint in Driver.cpp, so that storage is about 16.5MB which isn't too
> > bad. This goes up to 27.5MB with the FileSpec being
medismailben wrote:
> So I debugged lldb with lldb and adding a counter into the FileSpec
> constructor and came up a max of 721833 files after trying to set a
> breakpoint in Driver.cpp, so that storage is about 16.5MB which isn't too
> bad. This goes up to 27.5MB with the FileSpec being 40 b
clayborg wrote:
So I debugged lldb with lldb and adding a counter into the FileSpec constructor
and came up a max of 721833 files after trying to set a breakpoint in
Driver.cpp, so that storage is about 16.5MB which isn't too bad. This goes up
to 27.5MB with the FileSpec being 40 bytes, so not
@@ -420,13 +428,17 @@ class FileSpec {
/// The lifetime of the StringRefs is tied to the lifetime of the FileSpec.
std::vector GetComponents() const;
+ /// Return the checksum for this FileSpec or all zeros if there is none.
+ const Checksum &GetChecksum() const { retu
@@ -13,15 +13,18 @@
#include
#include
+#include "lldb/Utility/Checksum.h"
#include "lldb/Utility/ConstString.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/FileSystem.h"
#include "llvm/Support/FormatVariadic.h"
+#include "llvm/Support/MD5.h"
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/71457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM with comments.
https://github.com/llvm/llvm-project/pull/71457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
> Depends on #71456.
>
> I considered an alternative where we don't store the `Checksum` in the
> `FileSpec` but create a new `SupportFile` class that wraps a `Checksum` and a
> `FileSpec`. The reason I didn't got with this approach is because of the
> `FileSpecList`. The
https://github.com/bulbazord commented:
You pushed a commit from a different PR btw
https://github.com/llvm/llvm-project/pull/71457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/71457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -72,7 +75,8 @@ class FileSpec {
/// The style of the path
///
/// \see FileSpec::SetFile (const char *path)
- explicit FileSpec(llvm::StringRef path, Style style = Style::native);
+ explicit FileSpec(llvm::StringRef path, Style style = Style::native,
+
JDevlieghere wrote:
Depends on #71456.
I considered an alternative where we don't store the `Checksum` in the
`FileSpec` but create a new `SupportFile` class that wraps a `Checksum` and a
`FileSpec`. The reason I didn't got with this approach is because of the
`FileSpecList`. The latter has
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Store a Checksum in FileSpec. Its purpose is to store the MD5 hash added
to the DWARF 5 line table.
---
Full diff: https://github.com/llvm/llvm-project/pull/71457.diff
8 Files Affected:
- (added)
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/71457
Store a Checksum in FileSpec. Its purpose is to store the MD5 hash added
to the DWARF 5 line table.
>From 5ba3f9d6cd795bc091bacae75b7c51d815138d5b Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon,
17 matches
Mail list logo
