Re: [Lldb-commits] [PATCH] Fix for PR25300

2015-11-10 Thread Pavel Labath via lldb-commits
Looks great, thanks for fixing this. On 9 November 2015 at 22:08, Tim Northover wrote: > On 3 November 2015 at 07:38, Pavel Labath wrote: >> Looks good, but I'd like to avoid adding new "not remote ready" tests >> to the test suite. Your test looks like it should be easy to fix -- >> the only pr

Re: [Lldb-commits] [PATCH] Fix for PR25300

2015-11-09 Thread Tim Northover via lldb-commits
On 3 November 2015 at 07:38, Pavel Labath wrote: > Looks good, but I'd like to avoid adding new "not remote ready" tests > to the test suite. Your test looks like it should be easy to fix -- > the only problem there is the stdout redirection. If you *don't* > redirect the output, you should be abl

Re: [Lldb-commits] [PATCH] Fix for PR25300

2015-11-03 Thread Pavel Labath via lldb-commits
Hi, Looks good, but I'd like to avoid adding new "not remote ready" tests to the test suite. Your test looks like it should be easy to fix -- the only problem there is the stdout redirection. If you *don't* redirect the output, you should be able to access the stdout via self.process.GetSTDOUT() a

[Lldb-commits] [PATCH] Fix for PR25300

2015-10-23 Thread Tim Northover via lldb-commits
Hi, I decided to take a quick look at PR25300 (roughly, an '*' at the end of an environment variable crashes lldb-server). The issue is that during packet decompression (apparently even for uncompressed packets) there is basic RLE, triggered by '*', so it needs to be quoted in some way before bein