Hi, Looks good, but I'd like to avoid adding new "not remote ready" tests to the test suite. Your test looks like it should be easy to fix -- the only problem there is the stdout redirection. If you *don't* redirect the output, you should be able to access the stdout via self.process.GetSTDOUT() and verify that. Alternatively, you can have the inferior check the environment variable and set the exit status based on that.
pl On 3 November 2015 at 06:43, Tim Northover <t.p.northo...@gmail.com> wrote: > On 26 October 2015 at 01:49, Pavel Labath <lab...@google.com> wrote: >> For the testing, I would try writing a test which sets some >> environment variable, runs the inferior and has the inferior verify >> that the variable was passed correctly. You can model this based on >> some simple test in the test/ directory. TestFdLeak is the first that >> comes to mind. > > Thanks, I've done that in the attached patch, which is the > QEnvironmentHex fix. It seemed from comments on PR25300 that the other > fix was incomplete and probably needed more thought. > > OK to commit this one? > > Cheers. > > Tim. _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
