This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG69a326925071: Support AArch64 PAC elf-core register read
(authored by omjavaid).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99941/new/
https://reviews.llvm.org/D99941
___
lldb-commits mailing list
omjavaid marked an inline comment as done.
omjavaid added inline comments.
Comment at:
lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:32
+ if (pac_data.GetByteSize() > sizeof(uint64_t))
+opt_regsets.Set(RegisterInfoPOSIX_arm64::eRegsetMaskPAuth);
+
omjavaid updated this revision to Diff 340680.
omjavaid added a comment.
Resolved review comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99941/new/
https://reviews.llvm.org/D99941
Files:
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.cpp
lldb/source/Plugins/
labath added a comment.
Seems reasonable to me. I'm happy if @DavidSpickett is.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99941/new/
https://reviews.llvm.org/D99941
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
DavidSpickett added inline comments.
Comment at:
lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:32
+ if (pac_data.GetByteSize() > sizeof(uint64_t))
+opt_regsets.Set(RegisterInfoPOSIX_arm64::eRegsetMaskPAuth);
+
How is the `sizeof()`
omjavaid created this revision.
omjavaid added reviewers: labath, DavidSpickett.
Herald added subscribers: danielkiss, kristof.beyls.
omjavaid requested review of this revision.
This adds support for reading AArch64 Pointer Authentication regset
from elf-core file. Also includes a test-case for th
