DavidSpickett added inline comments.
================
Comment at:
lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:32
+ if (pac_data.GetByteSize() > sizeof(uint64_t))
+ opt_regsets.Set(RegisterInfoPOSIX_arm64::eRegsetMaskPAuth);
+
----------------
How is the `sizeof()` calculated here? Is it the size of the masks themselves,
or a header block. (SVE above is clearly a header of some kind)
================
Comment at:
lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py:451
+ self.assertTrue(target, VALID_TARGET)
+ process = target.LoadCore("linux-aarch64-pac.core")
+
----------------
Do you need anything special to generate the core file? Might be worth noting
in the commit message.
Though I guess you can just compile a hello world on a Linux system with PAC.
================
Comment at:
lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py:453
+
+ values = {}
+ values["data_mask"] = "0x007f00000000000"
----------------
```
values = {
"data_mask": "...",
...
}
```
(or `dict(data_mask="...")`)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99941/new/
https://reviews.llvm.org/D99941
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
