[Lldb-commits] [PATCH] D90598: [lldb/DWARF] Fix implementation of DW_OP_convert

2020-11-03 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D90598#2369590 , @JDevlieghere wrote: > In D90598#2368826 , @dblaikie wrote: > >> That's my understanding. It means I'm not sure (though I'm not the expert >> here - certainly leave fina

[Lldb-commits] [PATCH] D90598: [lldb/DWARF] Fix implementation of DW_OP_convert

2020-11-02 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D90598#2368826 , @dblaikie wrote: > In D90598#2368020 , @labath wrote: > >> Judging by >> http://lists.llvm.org/pipermail/llvm-dev/2020-October/145990.html, dsymutil >> has a simil

[Lldb-commits] [PATCH] D90598: [lldb/DWARF] Fix implementation of DW_OP_convert

2020-11-02 Thread David Blaikie via Phabricator via lldb-commits
dblaikie added a comment. In D90598#2368020 , @labath wrote: > Judging by http://lists.llvm.org/pipermail/llvm-dev/2020-October/145990.html, > dsymutil has a similar bug... That's my understanding. It means I'm not sure (though I'm not the expert here -

[Lldb-commits] [PATCH] D90598: [lldb/DWARF] Fix implementation of DW_OP_convert

2020-11-02 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 302269. labath added a comment. Add (test) changes I accidentally left out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90598/new/ https://reviews.llvm.org/D90598 Files: lldb/source/Expression/DWARFExpressi

[Lldb-commits] [PATCH] D90598: [lldb/DWARF] Fix implementation of DW_OP_convert

2020-11-02 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Judging by http://lists.llvm.org/pipermail/llvm-dev/2020-October/145990.html, dsymutil has a similar bug... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90598/new/ https://reviews.llvm.org/D90598 _

[Lldb-commits] [PATCH] D90598: [lldb/DWARF] Fix implementation of DW_OP_convert

2020-11-02 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: JDevlieghere, aprantl, dblaikie. Herald added a project: LLDB. labath requested review of this revision. According to the standard the DW_OP_convert operand is an offset relative to the current compilation unit, not to the start of the debug_in