[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file

2020-08-19 Thread Med Ismail Bennani via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG868b45b5b31d: [lldb/interpreter] Add REPL-specific init file (authored by mib). Changed prior to commit: https://reviews.llvm.org/D86242?vs=286674

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file

2020-08-19 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/docs/man/lldb.rst:314 +If launched with a `REPL`_ option, it will first look for a REPL configuration +file, specific to the REPL language. I

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file

2020-08-19 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 286674. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86242/new/ https://reviews.llvm.org/D86242 Files: lldb/docs/man/lldb.rst lldb/include/lldb/API/SBCommandInterpreter.h lldb/include/lldb/Interpreter/Command

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file

2020-08-19 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 286673. mib added a comment. Update man page to reflect current implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86242/new/ https://reviews.llvm.org/D86242 Files: lldb/docs/man/lldb.rst lldb/inclu

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file

2020-08-19 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2183 /// whose name is "~/.lldbinit" followed by a "-" and the name of the program. -/// If this file doesn't exist, we fall back to just the "~/.lldbinit" file. -void CommandInterpreter::Sourc

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file

2020-08-19 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2183 /// whose name is "~/.lldbinit" followed by a "-" and the name of the program. -/// If this file doesn't exist, we fall back to just the "~/.lldbinit" file. -void CommandInterpret

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file

2020-08-19 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 286660. mib marked an inline comment as done. mib retitled this revision from "[lldb/interpreter] Add REPL-specific init file." to "[lldb/interpreter] Add REPL-specific init file". mib edited the summary of this revision. mib added a comment. Addressed @JDevliegh

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file.

2020-08-19 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added inline comments. Comment at: lldb/docs/man/lldb.rst:312 First, it will read the application specific init file whose name is ~/.lldbinit followed by a "-" and the name of the current program. This would JDevlieghere wrote: > I wonder if we should ha

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file.

2020-08-19 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/docs/man/lldb.rst:312 First, it will read the application specific init file whose name is ~/.lldbinit followed by a "-" and the name of the current program. This would I wonder if we should have the descri

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file.

2020-08-19 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 286648. mib added a comment. Fixed typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86242/new/ https://reviews.llvm.org/D86242 Files: lldb/docs/man/lldb.rst lldb/include/lldb/API/SBCommandInterpreter.h ll

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file.

2020-08-19 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib created this revision. mib added reviewers: JDevlieghere, jingham. mib added a project: LLDB. Herald added a subscriber: lldb-commits. mib requested review of this revision. This patch adds the infrostructure to add language specific REPL init files. It's the foundation work to a following pat