mib added inline comments.
================ Comment at: lldb/docs/man/lldb.rst:312 First, it will read the application specific init file whose name is ~/.lldbinit followed by a "-" and the name of the current program. This would ---------------- JDevlieghere wrote: > I wonder if we should have the description here, and refer to it from the > REPL section. Sounds good. ================ Comment at: lldb/include/lldb/API/SBCommandInterpreter.h:150 + void SourceInitFileInHomeDirectory(lldb::SBCommandReturnObject &result, + bool repl_enabled); ---------------- JDevlieghere wrote: > JDevlieghere wrote: > > nit: How about `is_repl` as this is not really something you turn on and > > off? > I'd also give it a default argument (`false`). Giving it a default argument caused ambiguity in some cases (mainly when generating the bindings) that's why I left it like this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86242/new/ https://reviews.llvm.org/D86242 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
